Re: [tianocore/edk2] Stdlib: Add calling convention to completion callbacks (#123)

["Palmer, Thomas" <thomas.palmer@hpe.com>]

Daryl,

	Thanks for your patches!  

	Have you compiled your changes with CLANG38? In my sandbox (which, admittedly I may have stale CLANG38 compiler options), the second argument must be a VOID* type or the compiler is upset.  CLANG can be more strict here than GCC


Regards,

Thomas Palmer

“I have only made this letter longer because I have not had the time to make it shorter” - Blaise Pascal

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Daryl McDaniel (EDK2 Lists)
Sent: Thursday, January 18, 2018 11:12 AM
To: edk2-devel@lists.01.org
Subject: Re: [edk2] [tianocore/edk2] Stdlib: Add calling convention to completion callbacks (#123)

Marco,

 

Thank you for your submission.

 

Can you please tell me which compiler you are using?

 

Thank you,

Daryl McDaniel

 

 

From: Marco Guerri [mailto:notifications@github.com]
Sent: Wednesday, January 17, 2018 7:22 AM
To: tianocore/edk2 <edk2@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [tianocore/edk2] Stdlib: Add calling convention to completion callbacks (#123)

 

When compiling in Unix environments, the ABI defaults to SysV.
Callbacks are invoked directly by the system firmware so they must necessarily use MS ABI.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Marco Guerri marco.guerri.dev@fastmail.com <mailto:marco.guerri.dev@fastmail.com> 

  _____  


You can view, comment on, or merge this pull request online at:


  https://github.com/tianocore/edk2/pull/123


Commit Summary


*	Stdlib: Add calling convention to completion callbacks


File Changes


*	M StdLib/EfiSocketLib/Ip4.c <https://github.com/tianocore/edk2/pull/123/files#diff-0>  (10) 
*	M StdLib/EfiSocketLib/Socket.h <https://github.com/tianocore/edk2/pull/123/files#diff-1>  (24) 
*	M StdLib/EfiSocketLib/Tcp4.c <https://github.com/tianocore/edk2/pull/123/files#diff-2>  (11) 
*	M StdLib/EfiSocketLib/Tcp6.c <https://github.com/tianocore/edk2/pull/123/files#diff-3>  (3) 
*	M StdLib/EfiSocketLib/Udp4.c <https://github.com/tianocore/edk2/pull/123/files#diff-4>  (30) 
*	M StdLib/EfiSocketLib/Udp6.c <https://github.com/tianocore/edk2/pull/123/files#diff-5>  (20) 


Patch Links:


*	https://github.com/tianocore/edk2/pull/123.patch
*	https://github.com/tianocore/edk2/pull/123.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <https://github.com/tianocore/edk2/pull/123> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AM0XkaIxBOrC6Kacm-Vqq6z4tgQFar04ks5tLhAHgaJpZM4RhgXz> .  <https://github.com/notifications/beacon/AM0XkfL19zucGfgYUKWjci6NI8umTOaaks5tLhAHgaJpZM4RhgXz.gif> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel