From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=15.241.48.72; helo=g9t5008.houston.hpe.com; envelope-from=thomas.palmer@hpe.com; receiver=edk2-devel@lists.01.org Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A576B2265A168 for ; Fri, 20 Apr 2018 09:00:07 -0700 (PDT) Received: from G1W8108.americas.hpqcorp.net (g1w8108.austin.hp.com [16.193.72.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id AA9D07A for ; Fri, 20 Apr 2018 16:00:06 +0000 (UTC) Received: from G9W8453.americas.hpqcorp.net (2002:10d8:a0d3::10d8:a0d3) by G1W8108.americas.hpqcorp.net (2002:10c1:483c::10c1:483c) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 20 Apr 2018 16:00:06 +0000 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (15.241.52.13) by G9W8453.americas.hpqcorp.net (16.216.160.211) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Fri, 20 Apr 2018 16:00:06 +0000 Received: from TU4PR8401MB1086.NAMPRD84.PROD.OUTLOOK.COM (10.169.48.9) by TU4PR8401MB1135.NAMPRD84.PROD.OUTLOOK.COM (10.169.48.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.13; Fri, 20 Apr 2018 16:00:04 +0000 Received: from TU4PR8401MB1086.NAMPRD84.PROD.OUTLOOK.COM ([fe80::7470:4972:d50d:a920]) by TU4PR8401MB1086.NAMPRD84.PROD.OUTLOOK.COM ([fe80::7470:4972:d50d:a920%16]) with mapi id 15.20.0696.013; Fri, 20 Apr 2018 16:00:03 +0000 From: "Palmer, Thomas" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Wang, Nickle (HPS SW)" , "Gao, Liming" , "Dong, Eric" , "Zeng, Star" , "Zhang, Chao B" Thread-Topic: [edk2] [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Update RouteConfig function Thread-Index: AQHT11RUMtPxGwCUq0qb0fQq+4c5r6QJRVsAgACNB8A= Date: Fri, 20 Apr 2018 16:00:03 +0000 Message-ID: References: <1524083495-31936-1-git-send-email-thomas.palmer@hpe.com> <3C0D5C461C9E904E8F62152F6274C0BB3BACB257@shsmsx102.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB3BACB257@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [15.211.195.15] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; TU4PR8401MB1135; 7:OKL+uLzqdNs+vtV2kYKmLe0nAOxmpRxLX1CDsA2RlEVW/p2oz84bdTDpCbTElVIflONCja6T3axi7gRP8xD4/jwlBwPwA9+6DOYe3qH4UO+NOW8GoS7ALgRl3mWN33jAfbGSBYvnGpoCARkUbqk1cAu3OCHy6421vLP6OT9i4RtLIh/yljtLGYBVBLTwM9OyUwHTRihH4joUfMDoWIyfanEZ9shzgEhcl3BS+kcN/HsB4msA7NbJfNgB5P4rH/K6 x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10019020)(366004)(346002)(376002)(396003)(39380400002)(39860400002)(51914003)(13464003)(11346002)(76176011)(59450400001)(446003)(476003)(486006)(102836004)(53546011)(186003)(8676002)(26005)(8936002)(53936002)(81166006)(6506007)(229853002)(2900100001)(3660700001)(3280700002)(6246003)(5250100002)(4326008)(7696005)(2501003)(478600001)(66066001)(33656002)(966005)(86362001)(74316002)(2906002)(316002)(5660300001)(6116002)(3846002)(25786009)(9686003)(7736002)(6306002)(305945005)(15650500001)(110136005)(54906003)(6436002)(55016002); DIR:OUT; SFP:1102; SCL:1; SRVR:TU4PR8401MB1135; H:TU4PR8401MB1086.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; MLV:sfv; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:(222181515654134); BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989080)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(8990040)(48565401081)(2017052603328)(7153060)(7193020); SRVR:TU4PR8401MB1135; x-ms-traffictypediagnostic: TU4PR8401MB1135: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(162533806227266)(222181515654134)(228905959029699)(17755550239193); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231232)(944501395)(52105095)(6055026)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:TU4PR8401MB1135; BCL:0; PCL:0; RULEID:; SRVR:TU4PR8401MB1135; x-forefront-prvs: 0648FCFFA8 x-microsoft-antispam-message-info: BOTvngix3yB63rJhJMyq9txH5+jIx3m3T0tLNlEkwJqrJw7ujMegUjB5dcSKBV51UY0T6FcButtXqcD6GYw4ABSDmdyT+tchCU3ds0hRz7Ozv9ZmzTfzHb8R4qR2nUGLSBIHxnc1QEyXkbZ3bF/e/d13t2tidtoJ0vKc4F26of0nEgjxXHuBnlpDwVhmtryL spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: ae8ae4ca-62c5-420a-22b6-08d5a6d7c78a X-MS-Exchange-CrossTenant-Network-Message-Id: ae8ae4ca-62c5-420a-22b6-08d5a6d7c78a X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2018 16:00:03.7597 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1135 X-OriginatorOrg: hpe.com Subject: Re: [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLib: Update RouteConfig function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2018 16:00:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I have no opinion / please the 5th. I defer to the experts. Regards, Thomas Palmer "I have only made this letter longer because I have not had the time to mak= e it shorter" - Blaise Pascal -----Original Message----- From: Bi, Dandan [mailto:dandan.bi@intel.com]=20 Sent: Friday, April 20, 2018 2:34 AM To: Palmer, Thomas ; edk2-devel@lists.01.org Cc: Wang, Nickle (HPS SW) ; Gao, Liming ; Dong, Eric ; Zeng, Star ; Zhang, Chao B Subject: RE: [edk2] [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLi= b: Update RouteConfig function Thanks for the updating. These changes make sense. Reviewed-by: Dandan Bi for this patch series. But the Spec seems not to be clear enough. When looking into details about the "progress" parameter in EFI HII Configu= ration Routing Protocol and EFI_HII_CONFIG_ACCESS_PROTOCOL. Description of "progress" parameter in ExtractConfig() in UEFI 2.7 Spec: Progress On return, points to a character in the Request string. Points to the strin= g's null terminator if request was successful. Points to the most recent '&= ' before the first failing name / value pair (or the beginning of the strin= g if the failure is in the first name / value pair) if the request was not = successful =09 EFI_NOT_FOUND A configuration element matching the routing data is not found. Progress se= t to the first character in the routing header. Description of "progress" parameter in RouteConfig () in UEFI 2.7 Spec: Progress a pointer to a string filled in with the offset of the most recent '&' befo= re the first failing name / value pair (or the beginning of the string if t= he failure is in the first name / value pair) or the terminating NULL if al= l was successful. EFI_NOT_FOUND Target for the specified routing data was not found. Compared with ExtractConfig(), the description of "Progress" parameter in R= outeConfig() is not very clear.=20 We think an ECR is nice to have to clarify them. What do you think? Thanks, Dandan -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Thom= as Palmer Sent: Thursday, April 19, 2018 4:32 AM To: edk2-devel@lists.01.org Cc: nickle.wang@hpe.com; Gao, Liming Subject: [edk2] [PATCH 1/8] IntelFrameworkModulePkg/LegacyBootMaintUiLib: U= pdate RouteConfig function According to UEFI spec, the RouteConfig protocol function should populate t= he Progress pointer with an address inside Configuration. This patch ensur= es that these functions are compliant when EFI_NOT_FOUND is returned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Palmer --- .../Library/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 3= +++ 1 file changed, 3 insertions(+) diff --git a/IntelFrameworkModulePkg/Library/LegacyBootMaintUiLib/LegacyBoo= tMaintUi.c b/IntelFrameworkModulePkg/Library/LegacyBootMaintUiLib/LegacyBoo= tMaintUi.c index a4828b7130c7..3092184ab760 100644 --- a/IntelFrameworkModulePkg/Library/LegacyBootMaintUiLib/LegacyBootMaintU= i.c +++ b/IntelFrameworkModulePkg/Library/LegacyBootMaintUiLib/LegacyBootMai +++ ntUi.c @@ -2,6 +2,7 @@ Legacy Boot Maintainence UI implementation. =20 Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.
+(C) Copyright 2018 Hewlett Packard Enterprise Development LP
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at @@ -563,6 +56= 4,8 @@ LegacyBootOptionRouteConfig ( return EFI_INVALID_PARAMETER; } =20 + *Progress =3D Configuration; + // // Check routing data in . // Note: there is no name for Name/Value storage, only GUID will be chec= ked -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel