public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Lin, Derek (HPS UEFI Dev)" <derek.lin2@hpe.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Zhang, Chao B" <chao.b.zhang@intel.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: TPM 2.0 Manufacutre ID wrong byte order
Date: Thu, 22 Feb 2018 11:25:28 +0000	[thread overview]
Message-ID: <TU4PR8401MB119986764DEC09338FF6BAF5C2CD0@TU4PR8401MB1199.NAMPRD84.PROD.OUTLOOK.COM> (raw)

Hi TPM expert,

The line in https://github.com/tianocore/edk2/commit/73126ac2bd9804632255b2fddd4d7633537c9620#diff-76abe1c1ebf05982ed72eaf56f489029R192 change the byte order of Manufacture ID in Tpm2GetCapabilityManufactureID ().

I see it return "reversed" ManufactureId for two TPM vendor's module.
Also, all other Capability data in Tpm2Capability.c use SwapBytes32 since TPM is big-endian, which seems correct.

Can you check this and confirm?

Thanks,
Derek



             reply	other threads:[~2018-02-22 11:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 11:25 Lin, Derek (HPS UEFI Dev) [this message]
2018-02-23  3:03 ` TPM 2.0 Manufacutre ID wrong byte order Zhang, Chao B
2018-02-23  8:07   ` Lin, Derek (HPS UEFI Dev)
2018-02-24  6:25     ` Zhang, Chao B
2018-02-26  2:32       ` Lin, Derek (HPS UEFI Dev)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TU4PR8401MB119986764DEC09338FF6BAF5C2CD0@TU4PR8401MB1199.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox