From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=15.233.44.27; helo=g2t2354.austin.hpe.com; envelope-from=derek.lin2@hpe.com; receiver=edk2-devel@lists.01.org Received: from g2t2354.austin.hpe.com (g2t2354.austin.hpe.com [15.233.44.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E742421FD73D5 for ; Thu, 22 Feb 2018 03:19:31 -0800 (PST) Received: from G4W9120.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.210.21.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2354.austin.hpe.com (Postfix) with ESMTPS id 7FF64C5 for ; Thu, 22 Feb 2018 11:25:31 +0000 (UTC) Received: from G2W6309.americas.hpqcorp.net (2002:10c5:4033::10c5:4033) by G4W9120.americas.hpqcorp.net (2002:10d2:150f::10d2:150f) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Thu, 22 Feb 2018 11:25:31 +0000 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (15.241.52.11) by G2W6309.americas.hpqcorp.net (16.197.64.51) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Thu, 22 Feb 2018 11:25:31 +0000 Received: from TU4PR8401MB1199.NAMPRD84.PROD.OUTLOOK.COM (10.169.48.149) by TU4PR8401MB1135.NAMPRD84.PROD.OUTLOOK.COM (10.169.48.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.506.18; Thu, 22 Feb 2018 11:25:28 +0000 Received: from TU4PR8401MB1199.NAMPRD84.PROD.OUTLOOK.COM ([fe80::9937:9c33:86e1:2704]) by TU4PR8401MB1199.NAMPRD84.PROD.OUTLOOK.COM ([fe80::9937:9c33:86e1:2704%14]) with mapi id 15.20.0506.023; Thu, 22 Feb 2018 11:25:28 +0000 From: "Lin, Derek (HPS UEFI Dev)" To: "edk2-devel@lists.01.org" , "Zhang, Chao B" CC: "Yao, Jiewen" , "Zeng, Star" Thread-Topic: TPM 2.0 Manufacutre ID wrong byte order Thread-Index: AdOrz7VEcbbsZcIoT4ukA4PvAGJIIQ== Date: Thu, 22 Feb 2018 11:25:28 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=derek.lin2@hpe.com; x-originating-ip: [16.242.247.133] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; TU4PR8401MB1135; 7:1AF6fStC/E2wBfHdCqDWjTjeWMk1YKUwjQSYk56QcK/8lxY7CWc622+3zAd4m18xR51CHQHTSmCjOzAQZirHrHvpRtFR5HoCqt1aTeyYo4JNtM1KAvCP0BNtMpa5bn+Q6j6J9Yirf8bsrLYTGZzW4NxDvnhzpZbA3vOPsfNiYgZdzMcxw/yERm/BfnpEHOEkUwZJiPwdPkzobI28F+14Qo3z3TuXRtidKvSNTpSFDQGixUI8fa2OHWgKUwguyYqA x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ecddab23-f251-4264-1fc1-08d579e6fa32 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989060)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(8990040)(2017052603307)(7153060)(7193020); SRVR:TU4PR8401MB1135; x-ms-traffictypediagnostic: TU4PR8401MB1135: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(166708455590820)(21748063052155); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001078)(6040501)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231101)(944501161)(6055026)(6041288)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:TU4PR8401MB1135; BCL:0; PCL:0; RULEID:; SRVR:TU4PR8401MB1135; x-forefront-prvs: 059185FE08 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39380400002)(366004)(376002)(346002)(39860400002)(396003)(199004)(189003)(6116002)(790700001)(3846002)(478600001)(81166006)(105586002)(7696005)(8676002)(8936002)(81156014)(7736002)(66066001)(102836004)(33656002)(86362001)(68736007)(26005)(14454004)(186003)(2501003)(236005)(53936002)(6306002)(4326008)(74316002)(5250100002)(99286004)(110136005)(25786009)(9686003)(6436002)(6506007)(606006)(966005)(97736004)(2900100001)(59450400001)(5660300001)(316002)(54896002)(2906002)(3660700001)(3280700002)(54906003)(55016002)(106356001); DIR:OUT; SFP:1102; SCL:1; SRVR:TU4PR8401MB1135; H:TU4PR8401MB1199.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: G+65ivEbgzYjHo7Kp+a+PqIG86whdymcRK4vuMX/OjLFEEqX/7+8pxQ5WFmq18osHjPk6wzi6cEHU/tRnTIxaVS+rTiTXuZvvGYyGJWYwiGWChVHoy9tbLsOL6ll24E3jrHUwTtPdrGkN+6Q18WfuuUYwHza4JhZNAwk7//j/hk= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ecddab23-f251-4264-1fc1-08d579e6fa32 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2018 11:25:28.8883 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1135 X-OriginatorOrg: hpe.com X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: TPM 2.0 Manufacutre ID wrong byte order X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 11:19:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi TPM expert, The line in https://github.com/tianocore/edk2/commit/73126ac2bd9804632255b2= fddd4d7633537c9620#diff-76abe1c1ebf05982ed72eaf56f489029R192 change the byt= e order of Manufacture ID in Tpm2GetCapabilityManufactureID (). I see it return "reversed" ManufactureId for two TPM vendor's module. Also, all other Capability data in Tpm2Capability.c use SwapBytes32 since T= PM is big-endian, which seems correct. Can you check this and confirm? Thanks, Derek