From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=016662a963=derek.lin2@hpe.com) Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by groups.io with SMTP; Thu, 19 Sep 2019 23:54:37 -0700 Received: from pps.filterd (m0134420.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8K6pt2o008566 for ; Fri, 20 Sep 2019 06:54:36 GMT Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2v4g8jhpvy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 20 Sep 2019 06:54:36 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id 3312580 for ; Fri, 20 Sep 2019 06:54:35 +0000 (UTC) Received: from G9W8674.americas.hpqcorp.net (16.220.49.0) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 20 Sep 2019 06:54:25 +0000 Received: from G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) by G9W8674.americas.hpqcorp.net (2002:10dc:3100::10dc:3100) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 20 Sep 2019 06:54:25 +0000 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (15.241.52.11) by G4W10204.americas.hpqcorp.net (16.207.82.16) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 20 Sep 2019 06:54:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GKlg0HYjDl8rVy2j8xiI1y/hdmjLQoA1U49cPVR5Ejp/d2Qoy8CcHu2CfIExWoCyMllU2orD/2lSBl0w7H/l7ZBSLidPYsJSLWEMn0Acax8N5ZzmADQD00KQP8eRmbU3DayScprGhDu1ovnfppg8cJj7UMUsB220qWxkyqObjWFocizsAGUw8TRRfTTQe+iE6HSxtpakoaF9igvvNsLEDVt6Fl8XZkL7E1+wipq7PLUxQD6qEKqA7/Gv/ZJFwYcqTKbykd17Lc2cD9V61YELa6m/waH1GMOL2VH9to/WQwwhAXyV87qvtdyzB2ikUF2pbKu1uhCk7nXobvOG6osmnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kIv8fDDCgXQKCt40JikMc8/ps/1cxApiVNAqFl+TalM=; b=BC5Fq3cyoKW6rSbfEfmrZF+Vx0WnV5h9aDTjMO25g8Uw3YrkM+jYVsbPaWIIKVIhWdqtUVNJc1GpbwHAi2P0A/bvxU4/x7g5hnR5haZ+2vhhsk3KEH9/WJLDQK7h20zfUR+WWfQyq7Z7LkyhgpsJsFGUg0xeUS/U/WIBOTNk7tFIGAyIOyrLwbLNr7yXU3v3QxZshngV/U51eB5grdATZT80DyJ+EzSaEUOB2lck0xeN3yUH3Q/r1FsDGJSGb/qedu5hyGoKtR/yINa3bwZEQZKNpsv4ACGNDhqQtf9Hh7h/QhP3q2h+tv+3G6KzcsHQEPjvJVVidmqO5NqiuVuOXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB1245.NAMPRD84.PROD.OUTLOOK.COM (10.169.51.17) by TU4PR8401MB0544.NAMPRD84.PROD.OUTLOOK.COM (10.169.43.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.23; Fri, 20 Sep 2019 06:54:22 +0000 Received: from TU4PR8401MB1245.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d0d1:6515:de3b:4b11]) by TU4PR8401MB1245.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d0d1:6515:de3b:4b11%11]) with mapi id 15.20.2284.023; Fri, 20 Sep 2019 06:54:22 +0000 From: "Lin, Derek (HPS SW)" To: "devel@edk2.groups.io" CC: "Feng, Bob C" , "steven.shi@intel.com" Subject: BaseTools --hash malfunction after migrate from stable201905 to stable201908 Thread-Topic: BaseTools --hash malfunction after migrate from stable201905 to stable201908 Thread-Index: AdVveLlk2vAsuUUVQqOo7w9XnpiX4Q== Date: Fri, 20 Sep 2019 06:54:22 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.134] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1d3fd182-5597-4e4a-4be5-08d73d975e4e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:TU4PR8401MB0544; x-ms-traffictypediagnostic: TU4PR8401MB0544: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 0166B75B74 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(346002)(136003)(396003)(39860400002)(366004)(54534003)(189003)(199004)(25786009)(256004)(606006)(81166006)(2906002)(66476007)(64756008)(66556008)(14444005)(2351001)(52536014)(2501003)(54896002)(6306002)(55016002)(7696005)(236005)(86362001)(9686003)(790700001)(6116002)(3846002)(66066001)(486006)(5640700003)(76116006)(66946007)(476003)(6916009)(4326008)(54906003)(74316002)(99286004)(966005)(71200400001)(7736002)(71190400001)(66446008)(186003)(478600001)(33656002)(14454004)(316002)(81156014)(8936002)(1730700003)(5660300002)(6436002)(26005)(102836004)(6506007)(8676002);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR8401MB0544;H:TU4PR8401MB1245.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: K2CQtSEzOUI1DDIycSGKWmOv+XzWduWamF0xU5A5yHT0zrT/JnbcGWn5yex+PwxIHIvpf+W5s1vn//maZPHbBzOjFY1brw1WnUhSVgpdyqrr1scRA9UDE5BGJUX8I4/M97FikHeMgC92HOUc3fsV9jD9UN8yJYeTbG5zod4QykItwnzNz8az6GUSaGyl3+GKKHFZXInUfezJeWln7Un5dc5YeQh3MMipEf6ONr4v2cQkZGfo//dpTATpPD/N0ClSuMIoyRadQaI5dKqcQ1BDn9MXHqxOT2we0ZhDeesikyslzKebOWzAWfZqF7IlfripFZ/4SoLZciTUkpbEM/5HaBLzrrvEIAFrcV9PFA+0Opj2GI4dzDLbECZd6B/BI6hw96EWiY05edDcChxbqIDhoCblwWB1Ph+31Or7/s4OwoY= x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-Network-Message-Id: 1d3fd182-5597-4e4a-4be5-08d73d975e4e X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2019 06:54:22.6750 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9W1GNJqlFMDlPwI07dPiZizICktRjiQT2HaCUq2HRgW/ANwwVHNFi0P4TK3WVb9hFhveV6zgIAxH6KcXPcg6pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB0544 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-20_01:2019-09-19,2019-09-20 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=625 adultscore=0 suspectscore=0 mlxscore=0 priorityscore=1501 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 clxscore=1015 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1909200073 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_TU4PR8401MB12453B59C967AF0DDAE16DD8C2880TU4PR8401MB1245_" --_000_TU4PR8401MB12453B59C967AF0DDAE16DD8C2880TU4PR8401MB1245_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi BaseTools experts, We saw the clean build performance improvement after updating from edk2-sta= ble201905 to edk2-stable201908, which is promising. But we found the incremental build time increase 25%~35%, which is not good. We're building server platform. And we use --hash to speed up incremental b= uild as described in https://github.com/BobCF/edk2/wiki/Incremental-Build After upgrading to edk2-stable201908, none of AutoGen is skipped when I did= an incremental build without any code change. Dig into the issue, it is caused by commit https://github.com/tianocore/edk= 2/commit/0e7e7a264cd80ab71ea0f9e9da2d0617d4b539c4 >>From the code change logic, it seems like it require both --hash and --bina= ry-source to perform cache based incremental build. However, when we only h= ave --hash in build flag, it is not functional. Here's a build time log retrieved from -y report.log. 201905 incremental | 201908 increm= ental | 201905 clean | 201908 clean Build Duration: 00:03:44 00:04:40 = 00:07:12 00:06:19 AutoGen Duration: 00:02:40 00:03:15 = 00:04:28 00:03:09 Make Duration: 00:00:36 00:00:39 = 00:01:21 00:01:34 GenFds Duration: 00:00:27 00:00:28 = 00:01:22 00:01:18 We could see the AutoGen Duration has almost no change between clean and in= cremental build in 201908. Could we fix this? Thanks, Derek --_000_TU4PR8401MB12453B59C967AF0DDAE16DD8C2880TU4PR8401MB1245_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi BaseTools experts,

 

We saw the clean build performance improvement after= updating from edk2-stable201905 to edk2-stable201908, which is promising.<= o:p>

But we found the incremental build time increase 25%= ~35%, which is not good.

 

We’re building server platform. And we use --h= ash to speed up incremental build as described in https://gi= thub.com/BobCF/edk2/wiki/Incremental-Build

After upgrading to edk2-stable201908, none of AutoGe= n is skipped when I did an incremental build without any code change.<= /o:p>

 

Dig into the issue, it is caused by commit https://github.com/tianocore/edk2/commit/0e7e7a264cd80ab71ea0f9e9da2d0617d4= b539c4

From the code change logic, it seems like it require= both --hash and --binary-source to perform cache based incremen= tal build. However, when we only = have --hash in build flag, it is not functional.

 

 

Here’s a build time log retrieved from -y repo= rt.log.

 

        &nbs= p;            &= nbsp;            &nb= sp;     201905 incremental |  201908 incremen= tal |      201905 clean |     = 201908 clean 

Build Duration:       =          00:03:44   =             &nb= sp;        00:04:40  &nbs= p;            &= nbsp;            00:= 07:12           &nbs= p;     00:06:19

AutoGen Duration:      &nbs= p;   00:02:40        &nbs= p;            &= nbsp;  00:03:15         &= nbsp;           &nbs= p;      00:04:28     &nbs= p;           00:03:0= 9

Make Duration:       &= nbsp;        00:00:36   &= nbsp;           &nbs= p;        00:00:39   = ;            &n= bsp;            00:0= 1:21            &nbs= p;    00:01:34

GenFds Duration:       = ;      00:00:27      = ;            &n= bsp;     00:00:28      &n= bsp;            = ;         00:01:22   = ;            &n= bsp; 00:01:18  

 

We could see the AutoGen Duration has almost no chan= ge between clean and incremental build in 201908.

 

Could we fix this?

 

Thanks,

Derek

 

--_000_TU4PR8401MB12453B59C967AF0DDAE16DD8C2880TU4PR8401MB1245_--