From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web11.3394.1582251939490002500 for ; Thu, 20 Feb 2020 18:25:39 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=032018ff42=nickle.wang@hpe.com) Received: from pps.filterd (m0134424.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01L2MBWR013705 for ; Fri, 21 Feb 2020 02:25:38 GMT Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2y9d8fk4qf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 21 Feb 2020 02:25:38 +0000 Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id 0828F55 for ; Fri, 21 Feb 2020 02:25:38 +0000 (UTC) Received: from G4W9327.americas.hpqcorp.net (16.208.32.97) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 21 Feb 2020 02:25:37 +0000 Received: from G9W9209.americas.hpqcorp.net (2002:10dc:429c::10dc:429c) by G4W9327.americas.hpqcorp.net (2002:10d0:2061::10d0:2061) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 21 Feb 2020 02:25:37 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (15.241.52.11) by G9W9209.americas.hpqcorp.net (16.220.66.156) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 21 Feb 2020 02:25:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K6XIfqJ4frGTpMm/GnZZBAfsJZmlaVKCxrdiLsgMO2+5cnvUcwUdyq7rnGmVEG5MvUOpc9rbr8r/nf+ME/OlsQnKLe9mDgm1hrsqHc+r5ba6i2GTCdjLFb5IHC6eU1CDNbzbGRc4zUFLLMEYoSfbCqhFsxTk0sI0k3mn1bEhwWOZ2rTjoSdjtBSV1CYPRT2GaBtE2oGenthuoWAAFB20Pz3tKYiH6whU7t9uK7jg00lo0rKP0m0FDcNfp7sad0RzfUB2A1YNRxyr5/yJnXS5fTL0FM38h/idP1susSVbqiO/tSEj2LlIRS0FlMH3xuFqE00Th53ZrZtGMya5EOE+eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VxXtjJXpAfN4yeKJvweyZ4vtTCb0kC1sBlhXRoY8fZQ=; b=QMa8vWZe533XsmzkimbxTufWV/fLH5hjJ0tl/CgJz6aZlJdc9hTWDIu847HlEaUiy84eCtjDKaNi8gwkaoHx6LghGUMQhVitXg5chOyGufysIG2CGwGZE6hvVwgI80fKhpphxUgDcMRk+1qfKalsWQfzIO1/mGtq4YULKKD8gtGT8/fKUbQT21TUYGnz7qNQXSho+gpP37aKV0HaGUYTPSLv4EbbvDlSUwx+TvoiHjtlhS7PoUd7HH3V2ns7HqWwcKFJQ/K5yG4AvyVYDQlzgtRDnE1eNVU7czUeh5kPYcHtPCC1FVA2VtO3qmVtHSPY4u4u27/yBiPAOOqIPWA+3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB1247.NAMPRD84.PROD.OUTLOOK.COM (10.169.48.15) by TU4PR8401MB0685.NAMPRD84.PROD.OUTLOOK.COM (10.169.44.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Fri, 21 Feb 2020 02:25:34 +0000 Received: from TU4PR8401MB1247.NAMPRD84.PROD.OUTLOOK.COM ([fe80::3994:f1d9:f846:318a]) by TU4PR8401MB1247.NAMPRD84.PROD.OUTLOOK.COM ([fe80::3994:f1d9:f846:318a%11]) with mapi id 15.20.2729.033; Fri, 21 Feb 2020 02:25:34 +0000 From: "Nickle Wang" To: "Gao, Liming" , "devel@edk2.groups.io" , "Bi, Dandan" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT. Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT. Thread-Index: AQHV5zAbbOAdXJeE50yogjyq2Tr1B6gjv9gAgABjeYCAAMiSkIAAAXGAgAAAP7A= Date: Fri, 21 Feb 2020 02:25:34 +0000 Message-ID: References: <20200219142240.10448-1-nickle.wang@hpe.com> <3C0D5C461C9E904E8F62152F6274C0BB40D4473F@SHSMSX104.ccr.corp.intel.com> <9d20d94f6d8e4c12b5a3f1fd89c4b45b@intel.com> <83c28f9888a6461e9ff73adbdd91b4ee@intel.com> In-Reply-To: <83c28f9888a6461e9ff73adbdd91b4ee@intel.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.136] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 11a2fa27-685f-4eb9-11f4-08d7b67554fb x-ms-traffictypediagnostic: TU4PR8401MB0685: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:265; x-forefront-prvs: 0320B28BE1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(376002)(39860400002)(396003)(346002)(366004)(136003)(199004)(189003)(52536014)(55016002)(33656002)(9686003)(71200400001)(110136005)(5660300002)(6506007)(86362001)(186003)(2906002)(26005)(966005)(64756008)(7696005)(66476007)(53546011)(316002)(478600001)(66574012)(66446008)(8676002)(81156014)(66556008)(81166006)(76116006)(19627235002)(66946007)(8936002);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR8401MB0685;H:TU4PR8401MB1247.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7XFFD4chjlGID0qZ+RlT0L/mO25dcyyWRynhCJmg3tJewW6n/yhy4E1xek/8Mh7KbQe/JDgthLHrdEmAvVliEx2eh8YJCQZZ7K9Tj5JMnfFuY+5KNRtuNGS0DTHXOiPVMK6F6lD5HwWZ840NvTWFDvAgwB+sOfIqR/Kp4JpNzuxFqkVyULcj7JmJ1wQRLG0WD3JSkPnh37vdvGuhjxhm4+d61W4nfoih5/163N+4vE9eqvfwqWqPSZi/G8EZWjngZJ2D+8QYahoI9CWMFi367abX0pnPhaJ5QJBE6pUC0XMwse+0geYdzpFq/sUD6ZVkYA1lJZM1QTuUkDFMsz/qL9dPKSkiSFX7XwLxNViHgyyBFmTt5fWLbZezwSv3kXHj0v1v1B83r14M+zfVVPB6E8BlCGmXUPcQPVVjkphSlOAoQ8RQjuzHLhFltZ5Xv90x+myIbjjt8i1hdfKgCa06N3dzTBqQ7w43Y/5dYhoylJrr0X4t8cADBEclGkSjkVHIE0sEV+9y7zekMEgx4Z0fgQ== x-ms-exchange-antispam-messagedata: PlaWUegTGlenOGjBXmcUX7MR4Q7yGVFRtyBKUi7hMIPduAY+mpTkC+7C8sGGN1H2iBwGKRSGp8L+uCTZ2E+mYtz2qzDlze/NmU6gBEdbMPiMNbVZ6w192LLXjtugTfQvsH6vbRWOQc/c2ZR5DSyTBg== x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-Network-Message-Id: 11a2fa27-685f-4eb9-11f4-08d7b67554fb X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2020 02:25:34.7584 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l5/RZdQVRL+F7CmS5UqaBJvSIofZpxOcpJTxpm9AjNx1FOOdWkmljzHelH2i43tdFS+aMMqHHXa9Yv0no2VZbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB0685 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-20_19:2020-02-19,2020-02-20 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 phishscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 suspectscore=0 impostorscore=0 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002210012 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable No, I can have a dummy variable to work around this issue. Nickle -----Original Message----- From: Gao, Liming [mailto:liming.gao@intel.com]=20 Sent: Friday, February 21, 2020 10:23 AM To: Wang, Nickle (HPS SW) ; devel@edk2.groups.io; Bi,= Dandan Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZero= Guid() ASSERT. Do you request to catch this fix into this edk2 stable tag 202002? > -----Original Message----- > From: Wang, Nickle (HPS SW) > Sent: Friday, February 21, 2020 10:21 AM > To: Gao, Liming ; devel@edk2.groups.io; Bi,=20 > Dandan > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZe= roGuid() ASSERT. >=20 > Hi Liming, >=20 > Yes, I made a function and call GetIfrBinaryData() with NULL value to se= cond parameter. Then I see system assert. >=20 > Thanks, > Nickle >=20 > -----Original Message----- > From: Gao, Liming [mailto:liming.gao@intel.com] > Sent: Thursday, February 20, 2020 10:20 PM > To: devel@edk2.groups.io; Bi, Dandan ; Wang,=20 > Nickle (HPS SW) > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZe= roGuid() ASSERT. >=20 > Nickle: > Is this a real issue found in production? >=20 > Thanks > Liming > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of=20 > > Dandan Bi > > Sent: Thursday, February 20, 2020 4:24 PM > > To: devel@edk2.groups.io; nickle.wang@hpe.com > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix Is= ZeroGuid() ASSERT. > > > > Thanks Nickle for the fix. > > One minor comment is that please pay attention to the format of commit= message. > > Refer to > > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message > > -Format, Line length of commit message should be less than > 76 characters when possible. > > Please address it when submit the patch. > > Reviewed-by: Dandan Bi > > > > > > Thanks, > > Dandan > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf= =20 > > > Of Nickle Wang > > > Sent: Wednesday, February 19, 2020 10:23 PM > > > To: devel@edk2.groups.io; nickle.wang@hpe.com > > > Cc: Bi, Dandan > > > Subject: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix > > > IsZeroGuid() ASSERT. > > > > > > From the function description of GetIfrBinaryData(), FormSetGuid=20 > > > can be NULL. However, FormSetGuid is passed to IsZeroGuid(). This=20 > > > causes exception when FormSetGuid is NULL. > > > > > > Signed-off-by: Nickle Wang > > > --- > > > MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > > b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > > index 288f1c3197..82067b541c 100644 > > > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > > @@ -2,6 +2,7 @@ > > > Entry and initialization module for the browser. > > > > > > Copyright (c) 2007 - 2018, Intel Corporation. All rights=20 > > > reserved.
> > > +(C) Copyright 2020 Hewlett Packard Enterprise Development LP
> > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > **/ > > > @@ -5844,7 +5845,7 @@ GetIfrBinaryData ( > > > // > > > // Try to compare against formset GUID > > > // > > > - if (IsZeroGuid (FormSetGuid) || > > > + if (IsZeroGuid (ComparingGuid) || > > > CompareGuid (ComparingGuid, (EFI_GUID *)(OpCodeData= =20 > > > + sizeof > > > (EFI_IFR_OP_HEADER)))) { > > > break; > > > } > > > -- > > > 2.20.1.windows.1 > > > > > > > > > > > > > > >=20 >=20