From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web09.3257.1582251430696393315 for ; Thu, 20 Feb 2020 18:17:10 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=032018ff42=nickle.wang@hpe.com) Received: from pps.filterd (m0148664.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01L2GTnU019319 for ; Fri, 21 Feb 2020 02:17:10 GMT Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2y9rn0eetp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 21 Feb 2020 02:17:09 +0000 Received: from G1W8107.americas.hpqcorp.net (g1w8107.austin.hp.com [16.193.72.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 637205C for ; Fri, 21 Feb 2020 02:17:09 +0000 (UTC) Received: from G4W9121.americas.hpqcorp.net (2002:10d2:1510::10d2:1510) by G1W8107.americas.hpqcorp.net (2002:10c1:483b::10c1:483b) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 21 Feb 2020 02:17:09 +0000 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (15.241.52.11) by G4W9121.americas.hpqcorp.net (16.210.21.16) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 21 Feb 2020 02:17:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d7tjJABZTTgfEupOGsgGgMAnt47tZJOEU1iTcVmcB7DXDdiJPJh3PllHP39aYNwgCqAOyvtBMRKjnZXRVc/wxkRcGhaF7M/0sJfO6DmIH24NvT+OSDv3ivIw9Ozfj56Z+wh6sDb7/8DkBW50fzE/wn6WDwTEuxRMZdfFcrqCoxG1B5mw7DDNN47Ns0usGTek5qhPuhwS6Xr7+AiC/RMPnSnneHtW4qqSQ5wFeOmukcPfO4xbsngUwqMiAOsb7poxRP52dD1BcsNaPKXw/kqKdj4Lg8hztH6UkFOBT/zCckg/nSMrI97DL+zDCriosgwhfNKyHvPMq/fGm8sQVsMkrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FCV69fAOGlV+BrxkDCGdOuAQdwheQWOtwQTxfNeni1Y=; b=ZQWhmQqFtjfHnLeJTAsCjPO/l2n+jbpKxp91zJiI3IjRZ+NXlxX8LiSpoJPtOMjoHd6noCs++3UTT9UgBA4wuHh865JPP/oX6EDwksb/DOXA99U2/iE/WiYK9E9w45yFKfsB3k6pN6z2g1NmVlPrWwP3GrrvesrV9+M7MGKGWD1+6Oc2CHVSoNlTKbJqZswo+81GMIo/wRbsTtPgucvJk3G1G1NSyxltSLYQd3obDKb2bjUIG+ECwxOnq7G2Z7DzdQixGphcPk0dE5Mm2O5xn02BTl4jOvK631IYM9QU7nyNo/xulSEOAGvXsM4i81gGTMMA5qXUByB3uVKTLF5Jcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB1247.NAMPRD84.PROD.OUTLOOK.COM (10.169.48.15) by TU4PR8401MB1053.NAMPRD84.PROD.OUTLOOK.COM (10.169.46.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Fri, 21 Feb 2020 02:17:07 +0000 Received: from TU4PR8401MB1247.NAMPRD84.PROD.OUTLOOK.COM ([fe80::3994:f1d9:f846:318a]) by TU4PR8401MB1247.NAMPRD84.PROD.OUTLOOK.COM ([fe80::3994:f1d9:f846:318a%11]) with mapi id 15.20.2729.033; Fri, 21 Feb 2020 02:17:07 +0000 From: "Nickle Wang" To: "devel@edk2.groups.io" , "dandan.bi@intel.com" CC: "Wang, Nickle (HPS SW)" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT. Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT. Thread-Index: AQHV5zAbbOAdXJeE50yogjyq2Tr1B6gjv9gAgAEnfyA= Date: Fri, 21 Feb 2020 02:17:07 +0000 Message-ID: References: <20200219142240.10448-1-nickle.wang@hpe.com> <3C0D5C461C9E904E8F62152F6274C0BB40D4473F@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40D4473F@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.136] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2572c09c-2f63-4465-ebf2-08d7b674266a x-ms-traffictypediagnostic: TU4PR8401MB1053: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:983; x-forefront-prvs: 0320B28BE1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(366004)(346002)(396003)(39860400002)(136003)(376002)(199004)(189003)(66446008)(64756008)(4326008)(66556008)(71200400001)(66476007)(76116006)(66946007)(7696005)(86362001)(5660300002)(52536014)(8936002)(966005)(66574012)(8676002)(81156014)(81166006)(478600001)(2906002)(26005)(110136005)(186003)(9686003)(316002)(33656002)(53546011)(6506007)(55016002);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR8401MB1053;H:TU4PR8401MB1247.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XBD9R4emZ2x8Zqk8gCB2oT2U9BbL55LZiH99rWoqPGho9w1mrM5G/h4qPzrXAnNWGywhuZ+6zXvW/kY4niY9bclmPpt4lAdE4f/PqUiZp+Z1zAKYMAL+iqW2i+mMm0g0dLilF5n16ajyeKffbMFw6NgUCrX55oiFDWTttLgDKHF3K8CfS4ZzaA6FTtQRFNjDwK04yJPQ2QXGgLAHpBVfTJmIY0YFfWWdTLEbXllEAfjR2zSSR+sQD788lSyKZTOvFTUlbfdJ2G09XSwygjwM+r6+h8o5Fx3IobVx2iFxw9sh0v+27AzZea8EQnTV7+NttcvU3XjZ2G04DXalZYeUvEXF8yHFdH3D2WxlNbylmVmeLsQDVr/F2xlHx+qUZYpB84+tZWEJJZBZayiuBJxxfg8KWvj7eXvBkt5KGYM7jMdgnP8MmNHrOukjUORidkubN7A/GK6s7ZRYfbhL/mmz+wY70pLxNCff5iLeHY5/He1YjYnESkd3yyStdbYRyuEFIlCxaIk5YIqDzU6nklHyWA== x-ms-exchange-antispam-messagedata: MYUrhojqXxTT1i1Pt8EOZQNjlQ2yi96ezWWXtltpkr9nykcHuM5D7xglih/xzS6Bk+LMjAijqcI2NR0E1KmvWel7LmmU8fPZTzLF9V2Cim4DW8Za4FP7FBWCwIvBwS8EFsiiy30Kc/+Ft0xRkqIgOA== X-MS-Exchange-CrossTenant-Network-Message-Id: 2572c09c-2f63-4465-ebf2-08d7b674266a X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2020 02:17:07.1228 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W8rTMQ7v7dGQG/aY80AXMOTsUKOFau2mBte2xhyRPdUqkIyDHhvq1X8kUs0XNRSkItCG4WUs8gqjAOPOr6QTUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1053 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 3 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-20_19:2020-02-19,2020-02-20 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=854 lowpriorityscore=0 suspectscore=0 clxscore=1015 mlxscore=0 impostorscore=0 phishscore=0 spamscore=0 adultscore=0 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002210011 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Dandan, Thanks for your reminder. I update my patch and it passed BaseTools/Script= s/PatchCheck.py test. Nickle -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dand= an Bi Sent: Thursday, February 20, 2020 4:24 PM To: devel@edk2.groups.io; Wang, Nickle (HPS SW) Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZero= Guid() ASSERT. Thanks Nickle for the fix. One minor comment is that please pay attention to the format of commit mes= sage. Refer to https://github.com/tianocore/tianocore.github.io/wiki/Commit-Mes= sage-Format, Line length of commit message should be less than 76 character= s when possible. Please address it when submit the patch. Reviewed-by: Dandan Bi Thanks, Dandan > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of=20 > Nickle Wang > Sent: Wednesday, February 19, 2020 10:23 PM > To: devel@edk2.groups.io; nickle.wang@hpe.com > Cc: Bi, Dandan > Subject: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix > IsZeroGuid() ASSERT. >=20 > From the function description of GetIfrBinaryData(), FormSetGuid can=20 > be NULL. However, FormSetGuid is passed to IsZeroGuid(). This causes=20 > exception when FormSetGuid is NULL. >=20 > Signed-off-by: Nickle Wang > --- > MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > index 288f1c3197..82067b541c 100644 > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > @@ -2,6 +2,7 @@ > Entry and initialization module for the browser. >=20 > Copyright (c) 2007 - 2018, Intel Corporation. All rights=20 > reserved.
> +(C) Copyright 2020 Hewlett Packard Enterprise Development LP
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -5844,7 +5845,7 @@ GetIfrBinaryData ( > // > // Try to compare against formset GUID > // > - if (IsZeroGuid (FormSetGuid) || > + if (IsZeroGuid (ComparingGuid) || > CompareGuid (ComparingGuid, (EFI_GUID *)(OpCodeData +=20 > sizeof > (EFI_IFR_OP_HEADER)))) { > break; > } > -- > 2.20.1.windows.1 >=20 >=20 >=20