From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web12.3353.1582251682765872365 for ; Thu, 20 Feb 2020 18:21:23 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=032018ff42=nickle.wang@hpe.com) Received: from pps.filterd (m0134423.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01L2Jts0002830 for ; Fri, 21 Feb 2020 02:21:22 GMT Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2ya5a5rbxj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 21 Feb 2020 02:21:21 +0000 Received: from G2W6310.americas.hpqcorp.net (g2w6310.austin.hp.com [16.197.64.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id 5A04F55 for ; Fri, 21 Feb 2020 02:21:21 +0000 (UTC) Received: from G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) by G2W6310.americas.hpqcorp.net (2002:10c5:4034::10c5:4034) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 21 Feb 2020 02:21:21 +0000 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (15.241.52.12) by G9W8455.americas.hpqcorp.net (16.216.161.94) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 21 Feb 2020 02:21:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UOAmFZ9/8ELn9V8Tg+nbWG5Mt2MXmmYvA1rZQhzWigejtF8yZUY6qKFSVyXYPjF09FQosMxKJamf6RMjA6kMRnHv+hQrh/f+Xvqir801lrQxKBXOPYvd/1qAcu+aBYHszT7DAuuhAyd8iNJ7B7+HBhvirlibZ/Sy4iSy/E9+kQbO6FQ2vZg3P3br4VMoVnYc+nXHhuNxxap1KOavMFy2wI1SKOpRYgYkJB2LOzxIbKpDi0Ga6iPaGlifweMLm2kYAuDw3VR2ql0ANuT0BffaIIyGHJA+yuV1I9ULW0dNUOWxn4hsYGjfcS4K21yEMkA0dFS5LjKaCWy9skhbATAcnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U+7A/DqlKc8MWLwozDmDHJ7csxmyXgVSsIwL+M+Qlcw=; b=ZHVPROxOx54s5wbx+R3lw5pYp/DGT6qnA26Eh7TTQ3mgYiPKMtUAsA4WLGsD2PWc8VCyteaCZ1rRIaBI7I15KH5A/5cefm9kRlcPuU7SPg+v8mN9CMkNvktALex0n1t4/iPqVLUu6DyP38TpOzdsfq//Gpam6h545xNnz/VRhSz9UzlC1wempdPfrTYPG8ztP34d7EejiwKl/89TB5q+iQjjk3+8ukZFrlyQC3rB6NYNcjQ+NA7AHxYgLya17Jm6Eb0ePorfPUapSrSjb/1AUHPcCVuMDNbw+2n1h8Yhg9p3hvGX1/n/hR1DQZViuiIcxklgzndiIQZXBRziZSO6fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB1247.NAMPRD84.PROD.OUTLOOK.COM (10.169.48.15) by TU4PR8401MB1053.NAMPRD84.PROD.OUTLOOK.COM (10.169.46.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Fri, 21 Feb 2020 02:21:19 +0000 Received: from TU4PR8401MB1247.NAMPRD84.PROD.OUTLOOK.COM ([fe80::3994:f1d9:f846:318a]) by TU4PR8401MB1247.NAMPRD84.PROD.OUTLOOK.COM ([fe80::3994:f1d9:f846:318a%11]) with mapi id 15.20.2729.033; Fri, 21 Feb 2020 02:21:19 +0000 From: "Nickle Wang" To: "Gao, Liming" , "devel@edk2.groups.io" , "Bi, Dandan" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT. Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT. Thread-Index: AQHV5zAbbOAdXJeE50yogjyq2Tr1B6gjv9gAgABjeYCAAMiSkA== Date: Fri, 21 Feb 2020 02:21:19 +0000 Message-ID: References: <20200219142240.10448-1-nickle.wang@hpe.com> <3C0D5C461C9E904E8F62152F6274C0BB40D4473F@SHSMSX104.ccr.corp.intel.com> <9d20d94f6d8e4c12b5a3f1fd89c4b45b@intel.com> In-Reply-To: <9d20d94f6d8e4c12b5a3f1fd89c4b45b@intel.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.136] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 086a30f1-870f-4754-62e0-08d7b674bccc x-ms-traffictypediagnostic: TU4PR8401MB1053: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:635; x-forefront-prvs: 0320B28BE1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(366004)(346002)(396003)(39860400002)(136003)(376002)(199004)(189003)(66446008)(64756008)(66556008)(71200400001)(66476007)(76116006)(66946007)(7696005)(86362001)(5660300002)(52536014)(19627235002)(8936002)(966005)(66574012)(8676002)(81156014)(81166006)(478600001)(2906002)(26005)(110136005)(186003)(9686003)(316002)(33656002)(53546011)(6506007)(55016002);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR8401MB1053;H:TU4PR8401MB1247.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r54Z69IWUGc4ZNYxhuEsvTHtTa8Kt6ijpx9FoPEyz0Chict+h61UltSfYs0gPA7S1cg4QgW+q5jvaVuiWWN1Nx++WAGumpUx1X2PyvgHI3DVtATOqg/LhqIDo1fFOrkqbRuzKFnQ9r8oN6kNu6I5bBV8a0dILf+3mXuEUXn1vesOGIomOQu1o6DBU3W/jlyNtXtJ5kD/SWhD4/XdEV/ggRmQrIw6TEMzCGa0ZAOagqm87XBOJkPFM3S6rfGdZLSswAqz1bfUum8khXBwcwMlMXBFosKTsRFoQW50GU/VbKjoPagnJ2C6Z179s3kHy3M0DqnK751MoHJ6Pp4YVTW6TQWK34sSZX8c1u5Rdebes7vBDfMm20q+MoA8huaPPqkpWXBTCYJMIF8z4ftiZEtXn7WXkNOOm9acr9KZaLO+TaO7Glc01O57VIRvYeLdpx3EDE2CIWbLJj0VxoNg4RZBrIo0FbbXBkSkI7S9dPGkrSW5lyHqGRX2UZuT/na9V1ERn4GNnY8QhFeugiAgYco0+Q== x-ms-exchange-antispam-messagedata: M9vWi+ul8RfXFNF6jJ/KpuTISCGCPjm+WRFH0Ax0GG8Zsbwdk41iL/8l5oClDMZeDFXb/GmBY/WQaowGZFJRP98w00UJ5xex3jJoVPKajhiKKt73H/DQkeC8rCLlMgtMACO90HzPZbGU+bDyQfMr8w== x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-Network-Message-Id: 086a30f1-870f-4754-62e0-08d7b674bccc X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2020 02:21:19.4658 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wupwiFL06ovTElW2D/IjotwtsFJkXr3Y60wy5DivJer39ywMs8qYMLFR8CVQ54r1FmuknD/7NWLfAvpOroW2hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1053 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 1 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-20_19:2020-02-19,2020-02-20 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 mlxlogscore=787 impostorscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 mlxscore=0 malwarescore=0 adultscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002210012 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, Yes, I made a function and call GetIfrBinaryData() with NULL value to seco= nd parameter. Then I see system assert.=20 Thanks, Nickle -----Original Message----- From: Gao, Liming [mailto:liming.gao@intel.com]=20 Sent: Thursday, February 20, 2020 10:20 PM To: devel@edk2.groups.io; Bi, Dandan ; Wang, Nickle (= HPS SW) Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZero= Guid() ASSERT. Nickle: Is this a real issue found in production? Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Dandan=20 > Bi > Sent: Thursday, February 20, 2020 4:24 PM > To: devel@edk2.groups.io; nickle.wang@hpe.com > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZe= roGuid() ASSERT. >=20 > Thanks Nickle for the fix. > One minor comment is that please pay attention to the format of commit m= essage. > Refer to > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-For= mat, Line length of commit message should be less than 76 characters when p= ossible. > Please address it when submit the patch. > Reviewed-by: Dandan Bi >=20 >=20 > Thanks, > Dandan >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf=20 > > Of Nickle Wang > > Sent: Wednesday, February 19, 2020 10:23 PM > > To: devel@edk2.groups.io; nickle.wang@hpe.com > > Cc: Bi, Dandan > > Subject: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix > > IsZeroGuid() ASSERT. > > > > From the function description of GetIfrBinaryData(), FormSetGuid can= =20 > > be NULL. However, FormSetGuid is passed to IsZeroGuid(). This causes= =20 > > exception when FormSetGuid is NULL. > > > > Signed-off-by: Nickle Wang > > --- > > MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > index 288f1c3197..82067b541c 100644 > > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > @@ -2,6 +2,7 @@ > > Entry and initialization module for the browser. > > > > Copyright (c) 2007 - 2018, Intel Corporation. All rights=20 > > reserved.
> > +(C) Copyright 2020 Hewlett Packard Enterprise Development LP
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -5844,7 +5845,7 @@ GetIfrBinaryData ( > > // > > // Try to compare against formset GUID > > // > > - if (IsZeroGuid (FormSetGuid) || > > + if (IsZeroGuid (ComparingGuid) || > > CompareGuid (ComparingGuid, (EFI_GUID *)(OpCodeData += =20 > > sizeof > > (EFI_IFR_OP_HEADER)))) { > > break; > > } > > -- > > 2.20.1.windows.1 > > > > > > >=20 >=20 >=20