From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g2t2354.austin.hpe.com (g2t2354.austin.hpe.com [15.233.44.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BEC1921CF94FF for ; Tue, 1 Aug 2017 01:14:51 -0700 (PDT) Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2354.austin.hpe.com (Postfix) with ESMTPS id 0FDCB77 for ; Tue, 1 Aug 2017 08:17:00 +0000 (UTC) Received: from G4W8062.americas.hpqcorp.net (16.208.40.79) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Tue, 1 Aug 2017 08:16:25 +0000 Received: from G9W9209.americas.hpqcorp.net (2002:10dc:429c::10dc:429c) by G4W8062.americas.hpqcorp.net (2002:10d0:284f::10d0:284f) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Tue, 1 Aug 2017 08:16:25 +0000 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (15.241.52.12) by G9W9209.americas.hpqcorp.net (16.220.66.156) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Tue, 1 Aug 2017 08:16:24 +0000 Received: from TU4PR84MB0207.NAMPRD84.PROD.OUTLOOK.COM (10.162.187.21) by TU4PR84MB0254.NAMPRD84.PROD.OUTLOOK.COM (10.162.186.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1304.22; Tue, 1 Aug 2017 08:16:23 +0000 Received: from TU4PR84MB0207.NAMPRD84.PROD.OUTLOOK.COM ([10.162.187.21]) by TU4PR84MB0207.NAMPRD84.PROD.OUTLOOK.COM ([10.162.187.21]) with mapi id 15.01.1304.023; Tue, 1 Aug 2017 08:16:22 +0000 From: "Subramanian, Sriram" To: "Hegde, Nagaraj P" , "edk2-devel@lists.01.org" CC: "jaben.carsey@intel.com" , "ruiyu.ni@intel.com" , "jiaxin.wu@intel.com" Thread-Topic: [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line Thread-Index: AQHTConARU9VS5SQBk+Et66h3gyZcqJvJ6/A Date: Tue, 1 Aug 2017 08:16:21 +0000 Message-ID: References: <20170801054742.23300-1-nagaraj-p.hegde@hpe.com> In-Reply-To: <20170801054742.23300-1-nagaraj-p.hegde@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sriram-s@hpe.com; x-originating-ip: [16.242.235.130] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; TU4PR84MB0254; 7:nkGwNTyTt59itS1XE+Uc+kNytvFgXxSX1u5ms2iX3DNSk+KT/Hf68/slQ1AK3YK01Xef+AUFJqlup24zc+pw50N3WCquzqKX7dQinDd3LAm+35jaDkBPwq6uDizG1wWbBRsQ2rGltl4fbwEcNn6PzD19iMn2HiNmyRarVo/cvG1uNPrxPNCTwZCIj7VfUnqySLbcrbgZk1St8ti5WWp+GQfWWFBKJ4XZDPVkuqfm6pxeJACsXRu04B3Ybi+5G3ExeRqcEJIovxnQDgok/2EOFzoKlVPwP2ojGa/g/BOaEjaUcJmYBfSnHd0d8tRLEqnHWThHtpbVZMvW7iiFuw/fYy1+JEVg3TeCG1j3iKmFye2JdXLIPqHGvmZLtPRz5Hm6ndIJFkE2cM3gUXFFHtkIboi4f5mxavDSY88iGr6WEWSIMUgKtKpdI+CdCk9R+wzmz9DsfDCmha5FVm/nyOCUWvOGdAqscWYBgW9RJbsoTxoiww2BufrbE5S2Qp88/L3fpSko6R7jQ3jDJwz2gzNPtMO1MMqJMU07RTRc4uc9Vve3t5Ycynlmk63Oa/QYWgq4nLFxs0yrNBQ7UbMFuQD2KXECUarklIlQ675sQWrdekzv0dOIlYDjvpKgpoGklwqm8Fy2ddXlxCN7q/qvISqf58EbMzXZvpvVc4wX1SPsyZOWVHWoZZvNyEljtHlW2FB18S2izHrozkLaH3oOAdSIRpPmJRdxddD6WbDAIUk1Vjl4q7TFry8B7IWAycZVOdPUBTgMr74SGZYxs4E7RHrRj0s/ZkKcI7QX5DUXQT0sDI0= x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10019020)(6009001)(39450400003)(39400400002)(39850400002)(39410400002)(39840400002)(39860400002)(13464003)(199003)(377454003)(189002)(229853002)(33656002)(77096006)(6506006)(2950100002)(68736007)(8676002)(81156014)(81166006)(8936002)(101416001)(76176999)(54356999)(50986999)(6246003)(2906002)(53936002)(54906002)(9686003)(38730400002)(5660300001)(55016002)(3280700002)(4326008)(14454004)(6436002)(7736002)(305945005)(478600001)(7696004)(25786009)(74316002)(66066001)(6116002)(3846002)(102836003)(189998001)(15650500001)(97736004)(105586002)(575784001)(86362001)(53546010)(2501003)(106356001)(2900100001)(3660700001)(19627235001); DIR:OUT; SFP:1102; SCL:1; SRVR:TU4PR84MB0254; H:TU4PR84MB0207.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-ms-office365-filtering-correlation-id: 5dd5c853-6a97-41c7-d00c-08d4d8b5985f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:TU4PR84MB0254; x-ms-traffictypediagnostic: TU4PR84MB0254: x-exchange-antispam-report-test: UriScan:(227479698468861)(162533806227266)(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:TU4PR84MB0254; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:TU4PR84MB0254; x-forefront-prvs: 0386B406AA received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2017 08:16:21.5990 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR84MB0254 X-OriginatorOrg: hpe.com Subject: Re: [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2017 08:14:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sriram Subramanian -----Original Message----- From: Hegde, Nagaraj P=20 Sent: Tuesday, August 1, 2017 11:18 AM To: edk2-devel@lists.01.org Cc: jaben.carsey@intel.com; Subramanian, Sriram ; ruiyu.n= i@intel.com; jiaxin.wu@intel.com Subject: [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a = new line If DAD failed, we print "It failed to set", print the IPv6 address and exit. We need a better error string and also, after printing the IPv6 address, we need a new line else the Shell> prompt will overwrite the IPv6 address. Fixed these issues in this patch. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hegde Nagaraj P --- ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c = | 2 ++ ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib= .uni | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c b/Sh= ellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c index 6d8df8031b..a25d4e5d00 100644 --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c @@ -2,6 +2,7 @@ The implementation for Shell command IfConfig6. =20 Copyright (c) 2016, Intel Corporation. All rights reserved.
+ (C) Copyright 2017 Hewlett Packard Enterprise Development LP
=20 This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License @@ -1490,6 +1491,7 @@ IfConfig6SetInterfaceInfo ( &CfgManAddr[Index].Address, &CfgManAddr[Index].PrefixLength ); + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_INFO_= NEWLINE), gShellNetwork2HiiHandle); } } =20 diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork= 2CommandsLib.uni b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellN= etwork2CommandsLib.uni index 5c0fef0ff7..ee2f28717f 100644 --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comman= dsLib.uni +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comman= dsLib.uni @@ -2,6 +2,7 @@ =20 String definitions for UEFI Shell network 2 commands Copyright (c) 2016, Intel Corporation. All rights reserved.
+ (C) Copyright 2017 Hewlett Packard Enterprise Development LP
=20 This program and the accompanying materials are licensed and made available under the terms and conditions @@ -92,7 +93,7 @@ "Hint: P= lease type 'IfConfig6 -?' for help info.\r\n" #string STR_IFCONFIG6_ERR_UNKNOWN_COMMAND #language en-US "Unknown= commands. Bad command %H%s%N is skipped.\r\n" "Hint: P= lease type 'IfConfig6 -?' for help info.\r\n" -#string STR_IFCONFIG6_ERR_ADDRESS_FAILED #language en-US "It fail= ed to set .\r\n" +#string STR_IFCONFIG6_ERR_ADDRESS_FAILED #language en-US "Failed = to configure IPv6 address: " =20 =20 #string STR_GET_HELP_PING6 #language en-US "" --=20 2.13.0.windows.1