From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 13C9121E1452F for ; Mon, 14 Aug 2017 23:23:53 -0700 (PDT) Received: from G9W8455.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.216.161.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id DC62E4E for ; Tue, 15 Aug 2017 06:26:16 +0000 (UTC) Received: from G9W8454.americas.hpqcorp.net (2002:10d8:a104::10d8:a104) by G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Tue, 15 Aug 2017 06:26:16 +0000 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (15.241.52.13) by G9W8454.americas.hpqcorp.net (16.216.161.4) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Tue, 15 Aug 2017 06:26:16 +0000 Received: from TU4PR84MB0304.NAMPRD84.PROD.OUTLOOK.COM (10.162.186.26) by TU4PR84MB0304.NAMPRD84.PROD.OUTLOOK.COM (10.162.186.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1320.16; Tue, 15 Aug 2017 06:26:14 +0000 Received: from TU4PR84MB0304.NAMPRD84.PROD.OUTLOOK.COM ([10.162.186.26]) by TU4PR84MB0304.NAMPRD84.PROD.OUTLOOK.COM ([10.162.186.26]) with mapi id 15.01.1320.022; Tue, 15 Aug 2017 06:26:14 +0000 From: "Wang, Sunny (HPS SW)" To: Michael D Kinney , "edk2-devel@lists.01.org" CC: Ruiyu Ni , Hao Wu , "Wang, Sunny (HPS SW)" Thread-Topic: [edk2] [Patch] Nt32/PlatformBootManagerLib: Enable STD_ERROR on all consoles Thread-Index: AQHTFUzcCMRXair9nkuVRRHPSw+c6aKE85lw Date: Tue, 15 Aug 2017 06:26:14 +0000 Message-ID: References: <20170814222944.9608-1-michael.d.kinney@intel.com> In-Reply-To: <20170814222944.9608-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sunnywang@hpe.com; x-originating-ip: [16.242.247.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; TU4PR84MB0304; 6:tyKKS33FvBs/G0iVE41L0d0BSuhM3nOeV5DpzLydeU8vvUcUmGEZpi8sKQr/RWDXIXFKa/+fiEkLtVWmezztUvQwGtR8njDMEpXLX6Pqg4+Mi3x6aVxgrH1Dnyjg3wYEtfVfndCbDMrbKDJYLkk12Ca5AE2e+2cl66pT/JCcFgg+XrbzHVNxchZqNuWdVH7BkM9UsmAR1YodkYmZ4JtYpQWG/6uUPJtB2kVpd+TTQq/BsIcBQ8+OLGFrBIbn/swX78yK2l8hth8zMKQy25adH8ez4rA/FVd0tX4FY2sQ2Srt+DjdUnnHgz0rpBKUg778+JuV6ZDx7S4SvfHEPIAtjQ==; 5:IRTtl4ZsrPlNN6fcnrwlp+PTde6gIPVcvWaeR5gRZkerhqDKm4i48hAmblM0ZIFAtZMZLHLVckjpEw6c59vEyVrhia8GJCUnPuEn505ULZMoOokLdsWsMc25XuPjJMgZX4pPn1zP7AFO/aAYiaVbmQ==; 24:TdlLlCwFAXzLgNW8XpcDNttfegG2sabemxkbTpwUWAIELzZmh9d8bxwjZ2teYxYIZElMZan7tcsuGyxfklcjOjZUVm1CQl7fZ5yGrfjDAxY=; 7:BEbC4tISSfR2CF0A49QVyrt26krT5A5ECQUV0n4EL5bVeMmgx4PwnTNh04l2TEGxqvf3irwMyHjVtQq+xrKKbr/M7XJ3h1nAwOLoJ8NNDGFbDxRFCl6URFEpJEF1IdWjdLeNcQECPk2BlvFdd4BKshSt13JopPLcRamvfEvHUjGwcjotAMryjHjYCnwiwaSFl7EWJl8QzmXSeRCIBAS5u9T2K7gMFBh2TSSt60AJyP4= x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10019020)(6009001)(39860400002)(13464003)(377454003)(199003)(189002)(8676002)(3660700001)(189998001)(81166006)(6506006)(53546010)(8936002)(2501003)(25786009)(102836003)(97736004)(3280700002)(4326008)(3846002)(101416001)(305945005)(2900100001)(74316002)(6116002)(6306002)(106356001)(86362001)(7736002)(54356999)(68736007)(50986999)(9686003)(76176999)(33656002)(478600001)(54906002)(55016002)(81156014)(105586002)(6436002)(77096006)(6246003)(2906002)(2950100002)(5660300001)(14454004)(229853002)(966005)(7696004)(66066001)(53936002)(19627235001); DIR:OUT; SFP:1102; SCL:1; SRVR:TU4PR84MB0304; H:TU4PR84MB0304.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-ms-office365-filtering-correlation-id: dfb83930-cddd-4f8d-f4be-08d4e3a68788 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:TU4PR84MB0304; x-ms-traffictypediagnostic: TU4PR84MB0304: x-exchange-antispam-report-test: UriScan:(227479698468861)(278428928389397)(162533806227266)(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:TU4PR84MB0304; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:TU4PR84MB0304; x-forefront-prvs: 04004D94E2 received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2017 06:26:14.3589 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR84MB0304 X-OriginatorOrg: hpe.com Subject: Re: [Patch] Nt32/PlatformBootManagerLib: Enable STD_ERROR on all consoles X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Aug 2017 06:23:53 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed and tested it. Looks good to me. Thanks for addressing my offline = comment, Michael. :) Reviewed-by: Sunny Wang Regards, Sunny Wang -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Mich= ael D Kinney Sent: Tuesday, August 15, 2017 6:30 AM To: edk2-devel@lists.01.org Cc: Ruiyu Ni ; Hao Wu ; Michael Kin= ney Subject: [edk2] [Patch] Nt32/PlatformBootManagerLib: Enable STD_ERROR on al= l consoles Add STD_ERROR flag to all output consoles that the Nt32 platform supports s= o all messages sent to the standard error console device(s) are visible by = default. The Boot Maintenance Manager can be used to manually disable standard error= output to specific console devices. UEFI Applications and UEFI Drivers are recommended to be built with DEBUG()= and ASSERT() messages sent to the standard error device using MdePkg/Libra= ry/UefiDebugLibStdErr. Prior to this change, a user would have to use the B= oot Maintenance Manager to configure a standard error console device to mak= e these messages visible. Cc: Ruiyu Ni Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c b/Nt32Pk= g/Library/PlatformBootManagerLib/PlatformData.c index e92f377bd1..e4b400b4a3 100644 --- a/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c +++ b/Nt32Pkg/Library/PlatformBootManagerLib/PlatformData.c @@ -2,7 +2,7 @@ Defined the platform specific device path which will be filled to ConIn/ConOut variables. =20 -Copyright (c) 2015, Intel Corporation. All rights reserved.
+Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials =20 are licensed and made available under the terms and conditions of the BSD = License =20 which accompanies this distribution. The full text of the license may be = found at =20 @@ -137,19 +137,19 @@ NT_ISA_SERIAL_DEVICE_PATH gNtSerialDevicePath1 =3D = { PLATFORM_CONSOLE_CONNECT_ENTRY gPlatformConsole[] =3D { { (EFI_DEVICE_PATH_PROTOCOL *) &gNtSerialDevicePath0, - (CONSOLE_OUT | CONSOLE_IN) + (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) }, { (EFI_DEVICE_PATH_PROTOCOL *) &gNtSerialDevicePath1, - (CONSOLE_OUT | CONSOLE_IN) + (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) }, { (EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath0, - (CONSOLE_OUT | CONSOLE_IN) + (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) }, { (EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath1, - (CONSOLE_OUT | CONSOLE_IN) + (CONSOLE_OUT | CONSOLE_IN | STD_ERROR) }, { NULL, -- 2.13.1.windows.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel