* [PATCH v2] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenu
@ 2016-09-01 6:04 Liming Gao
2016-09-01 7:23 ` Wang, Sunny (HPS SW)
0 siblings, 1 reply; 2+ messages in thread
From: Liming Gao @ 2016-09-01 6:04 UTC (permalink / raw)
To: edk2-devel
Rename local function name BootMenuApp to BootManagerMenu to align to
other public function name.
In V2, use "BootManagerMenu" instead of "BootMenuApp".
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
---
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index ecd0ae3..fe09a04 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -1530,15 +1530,15 @@ EfiBootManagerGetLoadOptionBuffer (
}
/**
- Check if it's a Device Path pointing to BootMenuApp.
+ Check if it's a Device Path pointing to BootManagerMenu.
@param DevicePath Input device path.
- @retval TRUE The device path is BootMenuApp File Device Path.
- @retval FALSE The device path is NOT BootMenuApp File Device Path.
+ @retval TRUE The device path is BootManagerMenu File Device Path.
+ @retval FALSE The device path is NOT BootManagerMenu File Device Path.
**/
BOOLEAN
-BmIsBootMenuAppFilePath (
+BmIsBootManagerMenuFilePath (
EFI_DEVICE_PATH_PROTOCOL *DevicePath
)
{
@@ -1645,7 +1645,7 @@ EfiBootManagerBoot (
// 3. Signal the EVT_SIGNAL_READY_TO_BOOT event when we are about to load and execute
// the boot option.
//
- if (BmIsBootMenuAppFilePath (BootOption->FilePath)) {
+ if (BmIsBootManagerMenuFilePath (BootOption->FilePath)) {
DEBUG ((EFI_D_INFO, "[Bds] Booting Boot Manager Menu.\n"));
BmStopHotkeyService (NULL, NULL);
} else {
@@ -2080,10 +2080,10 @@ BmEnumerateBootOptions (
ASSERT (BootOptions != NULL);
//
- // If LoadFile includes BootMenuApp, its boot attribue will be set to APP and HIDDEN.
+ // If LoadFile includes BootManagerMenu, its boot attribue will be set to APP and HIDDEN.
//
BootAttributes = LOAD_OPTION_ACTIVE;
- if (BmIsBootMenuAppFilePath (DevicePathFromHandle (Handles[Index]))) {
+ if (BmIsBootManagerMenuFilePath (DevicePathFromHandle (Handles[Index]))) {
BootAttributes = LOAD_OPTION_CATEGORY_APP | LOAD_OPTION_ACTIVE | LOAD_OPTION_HIDDEN;
}
@@ -2215,7 +2215,7 @@ BmRegisterBootManagerMenu (
DevicePath = NULL;
Description = NULL;
//
- // Try to find BootMenuApp from LoadFile protocol
+ // Try to find BootManagerMenu from LoadFile protocol
//
gBS->LocateHandleBuffer (
ByProtocol,
@@ -2225,7 +2225,7 @@ BmRegisterBootManagerMenu (
&Handles
);
for (Index = 0; Index < HandleCount; Index++) {
- if (BmIsBootMenuAppFilePath (DevicePathFromHandle (Handles[Index]))) {
+ if (BmIsBootManagerMenuFilePath (DevicePathFromHandle (Handles[Index]))) {
DevicePath = DuplicateDevicePath (DevicePathFromHandle (Handles[Index]));
Description = BmGetBootDescription (Handles[Index]);
break;
@@ -2334,7 +2334,7 @@ EfiBootManagerGetBootManagerMenu (
BootOptions = EfiBootManagerGetLoadOptions (&BootOptionCount, LoadOptionTypeBoot);
for (Index = 0; Index < BootOptionCount; Index++) {
- if (BmIsBootMenuAppFilePath (BootOptions[Index].FilePath)) {
+ if (BmIsBootManagerMenuFilePath (BootOptions[Index].FilePath)) {
Status = EfiBootManagerInitializeLoadOption (
BootOption,
BootOptions[Index].OptionNumber,
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenu
2016-09-01 6:04 [PATCH v2] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenu Liming Gao
@ 2016-09-01 7:23 ` Wang, Sunny (HPS SW)
0 siblings, 0 replies; 2+ messages in thread
From: Wang, Sunny (HPS SW) @ 2016-09-01 7:23 UTC (permalink / raw)
To: Liming Gao, edk2-devel@lists.01.org
Looks good to me.
Reviewed-by: Sunny Wang <sunnywang@hpe.com>
Regards,
Sunny Wang
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
Sent: Thursday, September 01, 2016 2:05 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v2] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenu
Rename local function name BootMenuApp to BootManagerMenu to align to other public function name.
In V2, use "BootManagerMenu" instead of "BootMenuApp".
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
---
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index ecd0ae3..fe09a04 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -1530,15 +1530,15 @@ EfiBootManagerGetLoadOptionBuffer ( }
/**
- Check if it's a Device Path pointing to BootMenuApp.
+ Check if it's a Device Path pointing to BootManagerMenu.
@param DevicePath Input device path.
- @retval TRUE The device path is BootMenuApp File Device Path.
- @retval FALSE The device path is NOT BootMenuApp File Device Path.
+ @retval TRUE The device path is BootManagerMenu File Device Path.
+ @retval FALSE The device path is NOT BootManagerMenu File Device Path.
**/
BOOLEAN
-BmIsBootMenuAppFilePath (
+BmIsBootManagerMenuFilePath (
EFI_DEVICE_PATH_PROTOCOL *DevicePath
)
{
@@ -1645,7 +1645,7 @@ EfiBootManagerBoot (
// 3. Signal the EVT_SIGNAL_READY_TO_BOOT event when we are about to load and execute
// the boot option.
//
- if (BmIsBootMenuAppFilePath (BootOption->FilePath)) {
+ if (BmIsBootManagerMenuFilePath (BootOption->FilePath)) {
DEBUG ((EFI_D_INFO, "[Bds] Booting Boot Manager Menu.\n"));
BmStopHotkeyService (NULL, NULL);
} else {
@@ -2080,10 +2080,10 @@ BmEnumerateBootOptions (
ASSERT (BootOptions != NULL);
//
- // If LoadFile includes BootMenuApp, its boot attribue will be set to APP and HIDDEN.
+ // If LoadFile includes BootManagerMenu, its boot attribue will be set to APP and HIDDEN.
//
BootAttributes = LOAD_OPTION_ACTIVE;
- if (BmIsBootMenuAppFilePath (DevicePathFromHandle (Handles[Index]))) {
+ if (BmIsBootManagerMenuFilePath (DevicePathFromHandle
+ (Handles[Index]))) {
BootAttributes = LOAD_OPTION_CATEGORY_APP | LOAD_OPTION_ACTIVE | LOAD_OPTION_HIDDEN;
}
@@ -2215,7 +2215,7 @@ BmRegisterBootManagerMenu (
DevicePath = NULL;
Description = NULL;
//
- // Try to find BootMenuApp from LoadFile protocol
+ // Try to find BootManagerMenu from LoadFile protocol
//
gBS->LocateHandleBuffer (
ByProtocol,
@@ -2225,7 +2225,7 @@ BmRegisterBootManagerMenu (
&Handles
);
for (Index = 0; Index < HandleCount; Index++) {
- if (BmIsBootMenuAppFilePath (DevicePathFromHandle (Handles[Index]))) {
+ if (BmIsBootManagerMenuFilePath (DevicePathFromHandle
+ (Handles[Index]))) {
DevicePath = DuplicateDevicePath (DevicePathFromHandle (Handles[Index]));
Description = BmGetBootDescription (Handles[Index]);
break;
@@ -2334,7 +2334,7 @@ EfiBootManagerGetBootManagerMenu (
BootOptions = EfiBootManagerGetLoadOptions (&BootOptionCount, LoadOptionTypeBoot);
for (Index = 0; Index < BootOptionCount; Index++) {
- if (BmIsBootMenuAppFilePath (BootOptions[Index].FilePath)) {
+ if (BmIsBootManagerMenuFilePath (BootOptions[Index].FilePath)) {
Status = EfiBootManagerInitializeLoadOption (
BootOption,
BootOptions[Index].OptionNumber,
--
2.8.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-01 7:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-01 6:04 [PATCH v2] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenu Liming Gao
2016-09-01 7:23 ` Wang, Sunny (HPS SW)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox