From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0708.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe4a::708]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3961F1A1E6E for ; Thu, 1 Sep 2016 00:23:05 -0700 (PDT) Received: from TU4PR84MB0304.NAMPRD84.PROD.OUTLOOK.COM (10.162.186.26) by TU4PR84MB0303.NAMPRD84.PROD.OUTLOOK.COM (10.162.186.25) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9; Thu, 1 Sep 2016 07:23:04 +0000 Received: from TU4PR84MB0304.NAMPRD84.PROD.OUTLOOK.COM ([10.162.186.26]) by TU4PR84MB0304.NAMPRD84.PROD.OUTLOOK.COM ([10.162.186.26]) with mapi id 15.01.0599.010; Thu, 1 Sep 2016 07:23:04 +0000 From: "Wang, Sunny (HPS SW)" To: Liming Gao , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v2] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenu Thread-Index: AQHSBBbMFzMMzmD8BECg2honaSxWVKBkOm/w Date: Thu, 1 Sep 2016 07:23:04 +0000 Message-ID: References: <1472709886-58924-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1472709886-58924-1-git-send-email-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sunnywang@hpe.com; x-originating-ip: [15.211.131.5] x-ms-office365-filtering-correlation-id: a2a6e4f4-7112-4aa4-183a-08d3d238d02c x-microsoft-exchange-diagnostics: 1; TU4PR84MB0303; 6:WJCjRiDc6QmpMdvaP2si0qZHV3V3qCgKtD8VoTOncDKVrkG24q9cyDMJ0/jHwrh2Fn1TeFd13TKlv8yCiqgc0zYAqHbqgZwGNzNMjti4EhYGdpXZjQeCAbVl6eJzn9s+sO1MhF9NEVuoWRCy95Q77DqqfbVfgVE/hs/Lfu/IfsWHK2YYbuSe85npBTf+woDy76LZ/dPujRkv1TGGlKX7ZzVbQbXGWYhowe8CDm9ygk/kL3c/xiWHhXUcChTC6sjck8mHERL2/SqVw7b0uoo8A8UBcimvzoPdeV2l4NRPUbr49QPRiFDoWBrtPHMKr0cJDO3xiN7OLvOks4AzOmjaYw==; 5:GwjpTwz/FRIHs5a7oQZZpwbMk0qyVyZABdcMwIvFNHWbJ41HptKLN2m+8b7mrtqdoVhxR6lbacZsCe/heNNWRbwPDi6op+/+iKha/kL4s08mBNBLlB3jRV0G07BFaNYOlMZvd3R/I40A4r6lC+yPCg==; 24:u94IDLruf9+l/YMHKToJ47MeC5QVYTVbK11jtmOvOsNs6DvtFVirlWHRPswE/I21r7UDZh7wgX0rTp64onP0KIm6G3YNIU5DX/lpchMvid4=; 7:DJZSD/fjcb7g5LFPfMjntRTIsqQ5CJJCiMr4VDo8zLk4zv0lbo/xe4ZFo399nPfLsBAE+QBEXdmbhlQj9M+xZ3KbpOpPGi9gjaFwumiUVb0Pgk5djqVO/rrJuUwd/3Zgp5YAdX2b6aUnWzt29WIS1FOYjgkTF8+2rik8fysi5O4LmMMjpcDWIcw+AiVvLE+pENsl+COTSVLyVtUbFMW6QyJiuQhX9kP4sZtQLGH7DcnDVwiwu0beJsN8pfJAYaep x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:TU4PR84MB0303; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:TU4PR84MB0303; BCL:0; PCL:0; RULEID:; SRVR:TU4PR84MB0303; x-forefront-prvs: 0052308DC6 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(199003)(189002)(377454003)(13464003)(107886002)(81156014)(10400500002)(122556002)(2950100001)(2900100001)(5660300001)(74316002)(81166006)(3660700001)(77096005)(102836003)(33656002)(15975445007)(2501003)(66066001)(5002640100001)(19580405001)(19580395003)(7736002)(189998001)(101416001)(7846002)(11100500001)(106356001)(54356999)(92566002)(6116002)(97736004)(8936002)(105586002)(305945005)(5001770100001)(575784001)(3846002)(586003)(8676002)(76176999)(9686002)(68736007)(87936001)(7696003)(106116001)(3280700002)(50986999)(99286002)(2906002)(86362001); DIR:OUT; SFP:1102; SCL:1; SRVR:TU4PR84MB0303; H:TU4PR84MB0304.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2016 07:23:04.0873 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR84MB0303 Subject: Re: [PATCH v2] MdeModulePkg UefiBootManagerLib: Rename BootMenuApp to BootManagerMenu X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2016 07:23:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good to me. Reviewed-by: Sunny Wang Regards, Sunny Wang -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Limi= ng Gao Sent: Thursday, September 01, 2016 2:05 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2] MdeModulePkg UefiBootManagerLib: Rename BootMenu= App to BootManagerMenu Rename local function name BootMenuApp to BootManagerMenu to align to other= public function name. In V2, use "BootManagerMenu" instead of "BootMenuApp". Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Reviewed-by: Ruiyu Ni --- MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePk= g/Library/UefiBootManagerLib/BmBoot.c index ecd0ae3..fe09a04 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c @@ -1530,15 +1530,15 @@ EfiBootManagerGetLoadOptionBuffer ( } =20 /** - Check if it's a Device Path pointing to BootMenuApp. + Check if it's a Device Path pointing to BootManagerMenu. =20 @param DevicePath Input device path. =20 - @retval TRUE The device path is BootMenuApp File Device Path. - @retval FALSE The device path is NOT BootMenuApp File Device Path. + @retval TRUE The device path is BootManagerMenu File Device Path. + @retval FALSE The device path is NOT BootManagerMenu File Device Path. **/ BOOLEAN -BmIsBootMenuAppFilePath ( +BmIsBootManagerMenuFilePath ( EFI_DEVICE_PATH_PROTOCOL *DevicePath ) { @@ -1645,7 +1645,7 @@ EfiBootManagerBoot ( // 3. Signal the EVT_SIGNAL_READY_TO_BOOT event when we are about to loa= d and execute // the boot option. // - if (BmIsBootMenuAppFilePath (BootOption->FilePath)) { + if (BmIsBootManagerMenuFilePath (BootOption->FilePath)) { DEBUG ((EFI_D_INFO, "[Bds] Booting Boot Manager Menu.\n")); BmStopHotkeyService (NULL, NULL); } else { @@ -2080,10 +2080,10 @@ BmEnumerateBootOptions ( ASSERT (BootOptions !=3D NULL); =20 // - // If LoadFile includes BootMenuApp, its boot attribue will be set to = APP and HIDDEN. + // If LoadFile includes BootManagerMenu, its boot attribue will be set= to APP and HIDDEN. // BootAttributes =3D LOAD_OPTION_ACTIVE; - if (BmIsBootMenuAppFilePath (DevicePathFromHandle (Handles[Index]))) { + if (BmIsBootManagerMenuFilePath (DevicePathFromHandle=20 + (Handles[Index]))) { BootAttributes =3D LOAD_OPTION_CATEGORY_APP | LOAD_OPTION_ACTIVE | L= OAD_OPTION_HIDDEN; } =20 @@ -2215,7 +2215,7 @@ BmRegisterBootManagerMenu ( DevicePath =3D NULL; Description =3D NULL; // - // Try to find BootMenuApp from LoadFile protocol + // Try to find BootManagerMenu from LoadFile protocol // gBS->LocateHandleBuffer ( ByProtocol, @@ -2225,7 +2225,7 @@ BmRegisterBootManagerMenu ( &Handles ); for (Index =3D 0; Index < HandleCount; Index++) { - if (BmIsBootMenuAppFilePath (DevicePathFromHandle (Handles[Index]))) { + if (BmIsBootManagerMenuFilePath (DevicePathFromHandle=20 + (Handles[Index]))) { DevicePath =3D DuplicateDevicePath (DevicePathFromHandle (Handles[I= ndex])); Description =3D BmGetBootDescription (Handles[Index]); break; @@ -2334,7 +2334,7 @@ EfiBootManagerGetBootManagerMenu ( BootOptions =3D EfiBootManagerGetLoadOptions (&BootOptionCount, LoadOpti= onTypeBoot); =20 for (Index =3D 0; Index < BootOptionCount; Index++) { - if (BmIsBootMenuAppFilePath (BootOptions[Index].FilePath)) { + if (BmIsBootManagerMenuFilePath (BootOptions[Index].FilePath)) { Status =3D EfiBootManagerInitializeLoadOption ( BootOption, BootOptions[Index].OptionNumber, -- 2.8.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel