public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wasim Khan" <wasim.khan@nxp.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "michael.d.kinney@intel.com" <michael.d.kinney@intel.com>,
	"liming.gao@intel.com" <liming.gao@intel.com>,
	Varun Sethi <V.Sethi@nxp.com>
Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
Date: Mon, 1 Jun 2020 11:16:09 +0000	[thread overview]
Message-ID: <VE1PR04MB67023EAB071103E8D59AD874908A0@VE1PR04MB6702.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <3b312fb3-7d9f-f951-870e-59811f2b14ba@redhat.com>



> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> Sent: Monday, June 1, 2020 2:17 PM
> To: devel@edk2.groups.io; Wasim Khan <wasim.khan@nxp.com>
> Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Varun Sethi
> <V.Sethi@nxp.com>
> Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
> 
> On 4/20/20 9:48 AM, Wasim Khan wrote:
> > ACPI memory mapped configuration space access (MCFG) table requires
> > defination of EFI_ACPI_DESCRIPTION_HEADER.
> 
> What about:
> 
> - DynamicTablesPkg/Include/Library/TableHelperLib.h
> - DynamicTablesPkg/Include/StandardNameSpaceObjects.h
> - EmbeddedPkg/Include/Library/AcpiLib.h

EmbeddedPkg/Include/Library/AcpiLib.h  => Acpi10.h is included in this file.
For other two, Acpi.h /Acpi10.h has been included in the files where above header file are used. 


> 
> >
> > Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
> > ---
> > Changes in v2: Corrected typo in subject
> >
> >  .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h        |
> 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git
> >
> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess
> > Table.h
> >
> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess
> > Table.h
> > index 3356ec9..8a4933d 100644
> > ---
> >
> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess
> > Table.h
> > +++
> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAc
> > +++ cessTable.h
> > @@ -10,6 +10,8 @@
> >  #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
> >  #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
> >
> > +#include <IndustryStandard/Acpi.h>
> > +
> >  //
> >  // Ensure proper structure formats
> >  //
> >


  reply	other threads:[~2020-06-01 11:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20  7:48 [PATCH v2] MdePkg: Include Acpi header file Wasim Khan
2020-05-31 12:29 ` [edk2-devel] " Zhiguang Liu
2020-06-01  8:46 ` Philippe Mathieu-Daudé
2020-06-01 11:16   ` Wasim Khan [this message]
2020-06-01 11:17     ` Philippe Mathieu-Daudé
2020-06-19  9:11       ` Liming Gao
     [not found]       ` <1619E6FD13E309C3.13400@groups.io>
2020-06-19 14:09         ` Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VE1PR04MB67023EAB071103E8D59AD874908A0@VE1PR04MB6702.eurprd04.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox