From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.60]) by mx.groups.io with SMTP id smtpd.web11.4614.1592476388270055466 for ; Thu, 18 Jun 2020 03:33:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=HGdURWBu; spf=pass (domain: oss.nxp.com, ip: 40.107.6.60, mailfrom: wasim.khan@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VcOStouRiVyvMdFZ3k6WE8JdnGDMmI+ZmmEm4E8FkgkpQ8TVB7UNBvVsYs1etwy1PmA3LR8gdDkqlY4/XQFYxuA0tozcLXUCm/CW4DiNKdTh8tj9aijjU4l8CD5Tg5Tx2GxT/jN9UASc/lk/w6Rfkwm+YPp92YMQ3xefd5kfV90RLbuwZz+Ct66Wb1f197QPMzJ3E8xkOkGvnRwtjCVqO/XAFmvN31gY2sqrjtEgEHZGizmHh9Oai5a49kiDK3sba0VDAncV5t1DV7YYOIMbCUo+HIdahubVMvV4vswvCFRLL0tNmauncIUFDH6TXpowj2UZjIFb4H3kETqcdRhx9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CetkTN3t1dpSA/+FLxyg+FQB+81WMmtLaSFiyIO/pU8=; b=jHqfyx3Ixx3nXdT6GvgK2BE0RhswxWWgDHdg6XM2zl6YmnlptK1LTG5vtyt8XJ+bkHEty1DTmWOPmXSMO7Io+pSeQJWR00Ohu9JNAH7kR3kcQF3iRIp/Ybk4lRv7K4UcPfElH8sUmWyyZjxgkjNzto25B7+xSluksm2IbasrUc4hoS5N8cVEJ8tFUF/OBGkg7kNLEX2QdO2GktD71GkbIHAPV20ZvGRUU9OUD6IIJKZUofMrJA8EfKJRnP9OaXkATH10JEpjSS5g2ypcrQHDQ4H81JInJO9MI9kUr+lLdJ2NPrzys/HlN/25mgK4GOu2EO44BzXQGIYTy/CStdH5Sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CetkTN3t1dpSA/+FLxyg+FQB+81WMmtLaSFiyIO/pU8=; b=HGdURWBuYaDW4x2Fi/WYi/Y0cmjtgWR8QgxaJA1RhePieprHMqm1bJhwRvWFd7aPR11FX9xWYoOvad6BuJji4NVSx60ec1d1z8T3DUtZwatVsx9vihMS4YBUQgFxDGafvP7ajpPBr9Lc/j1RGV17YJVH6+m+vt9rOG8A6Rn2h5o= Received: from VE1PR04MB6702.eurprd04.prod.outlook.com (2603:10a6:803:123::13) by VE1PR04MB6591.eurprd04.prod.outlook.com (2603:10a6:803:123::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Thu, 18 Jun 2020 10:33:05 +0000 Received: from VE1PR04MB6702.eurprd04.prod.outlook.com ([fe80::81c4:97a6:7592:f225]) by VE1PR04MB6702.eurprd04.prod.outlook.com ([fe80::81c4:97a6:7592:f225%7]) with mapi id 15.20.3088.029; Thu, 18 Jun 2020 10:33:05 +0000 From: "Wasim Khan (OSS)" To: Leif Lindholm , "Wasim Khan (OSS)" CC: "devel@edk2.groups.io" , Meenakshi Aggarwal , Varun Sethi , "ard.biesheuvel@arm.com" Subject: Re: [PATCH edk2-platforms 2/7] Silicon/NXP: LX2160A: Define PCIe related PCDs Thread-Topic: [PATCH edk2-platforms 2/7] Silicon/NXP: LX2160A: Define PCIe related PCDs Thread-Index: AQHWPqvQ0WC5SPQAxEOU39PUYY6sIKjeM0EAgAAHFaA= Date: Thu, 18 Jun 2020 10:33:05 +0000 Message-ID: References: <1591741050-11645-1-git-send-email-wasim.khan@oss.nxp.com> <1591741050-11645-3-git-send-email-wasim.khan@oss.nxp.com> <20200618100740.GV6739@vanye> In-Reply-To: <20200618100740.GV6739@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [157.37.123.1] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 508a7f02-7f7d-4901-41aa-08d81372fc4b x-ms-traffictypediagnostic: VE1PR04MB6591: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0438F90F17 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8asc7Z3fKoUqRILoAOQXg5t/mXFXksPOoZ0DVMrfFH3Dnn6Be5N+O9bpGNKa4BhAXPMYUGBvgjha3wjdA5i6nttQ7IL6Cqn/lzcXe51CDzkv/Sq5Sb4w6FeS5jigRsWC/+1bTx+j3ActtAUrFoVk2zCbG2Tr3aoDrmGL1R7BXJg3Aj/QJASchJ34k8upEErYO1xK6UuBM1/ktEZNC2NqYMbMUuR6N/kDr0YW0iY6NUY52UHE0XY2YkyBU/7u0yz47OJ9Z8yNe79jqV5eq1ZMGK9HT9Pa6kkGGqntP1kXAa62YYbT31NVjORhVh8+AGdJ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6702.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(71200400001)(33656002)(86362001)(478600001)(110136005)(2906002)(54906003)(186003)(26005)(53546011)(6506007)(52536014)(316002)(4326008)(7696005)(83380400001)(8676002)(66946007)(66476007)(66556008)(66446008)(8936002)(19627235002)(55016002)(9686003)(76116006)(5660300002)(64756008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: PRScUCr4BASh5M043AEdAwKou7aYTfgTbIvcFytuvE0vGCfVzqEmmmlLv8lUWE3c1nz7l6R33IKGsjHjubaPe+YqeSazAJk2Gg3Tqb+n840zsNIw4NMDciGYMJnCUyrm1fS3GvpTC1EdmjSe1Jyh1tnygfqAsEqa8O0Mba4gebLvyQupUZmPRtxlkFjPC9sgQn0F2+7N+nQYEMRZiwVKOTPK1rtZfLxc/z4lPvRm1c6Mt9TXXrvWcxGDN4dW0VzMMQLKJHTuqWhQTsmeVOkhZIUCkbCnE2ZYtfErnquyrbAUCJjRUWHUb72kUsiwEdfI5ij+gl9Nt6qE/nHnI+E/0ft1F1u9DMZj41I4QGReXZnruH2PHbTA21OHa0u2NOZUhtF+vAyHwtxMplNDRf7s9rGD2MGmaYCu4xxWCHw8B6qCv3cOJHqcZmEQ8baLQF8berwKxTgwLMclZ037VVNUWcqqwFrAWnOViBrrwUG11eo= MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 508a7f02-7f7d-4901-41aa-08d81372fc4b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2020 10:33:05.1555 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vI/C95gIoNCPOfyFSmmz6lFv5OJX/f0QmjXJ+726Cc+EFKVBNORHBnIqjNindIIerk9VI9KFAQ5ZF41yxrQaeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6591 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm > Sent: Thursday, June 18, 2020 3:38 PM > To: Wasim Khan (OSS) > Cc: devel@edk2.groups.io; Meenakshi Aggarwal > ; Varun Sethi ; > ard.biesheuvel@arm.com; Wasim Khan > Subject: Re: [PATCH edk2-platforms 2/7] Silicon/NXP: LX2160A: Define PCIe > related PCDs >=20 > On Wed, Jun 10, 2020 at 03:47:25 +0530, Wasim Khan wrote: > > From: Wasim Khan > > > > Define PCIe related PCDs for LX2160A. > > > > Signed-off-by: Wasim Khan > > --- > > Silicon/NXP/LX2160A/LX2160A.dsc.inc | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Silicon/NXP/LX2160A/LX2160A.dsc.inc > > b/Silicon/NXP/LX2160A/LX2160A.dsc.inc > > index fe8ed402fc4e..43e361464c8e 100644 > > --- a/Silicon/NXP/LX2160A/LX2160A.dsc.inc > > +++ b/Silicon/NXP/LX2160A/LX2160A.dsc.inc > > @@ -38,6 +38,11 @@ [PcdsFixedAtBuild.common] > > gEfiMdePkgTokenSpaceGuid.PcdUartDefaultReceiveFifoDepth|0 > > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x21C0000 > > > > + gNxpQoriqLsTokenSpaceGuid.PcdPciExp1BaseAddr|0x8000000000 >=20 > This is already provided by LX2160A_PCI1_PHYS_ADDRESS in > Silicon/NXP/LX2160A/Include/Soc.h, and PCI_SEG0_MMIO_MEMBASE would be > better described as an alias of that. Unless the NXP > PciHostBridgeLib/PciSegmentLib is intended to be shared with SoCs where t= hese > base addresses can be different in different platforms. Yes, PciHostBridgeLib/PciSegmentLib are shared with different SoC with diff= erent base address and number of PCIe controllers. >=20 > If so, the PHYS_ADDRESSES would be better defined as derivatives of > PcdPciExp1BaseAddr. OK, I will use PcdPciExp1BaseAddr and PcdNumPciController for PHYS_ADDRESSE= S >=20 > > + gNxpQoriqLsTokenSpaceGuid.PcdNumPciController|6 >=20 > Is this number possible to be different for different platforms based on = the same > SoC? This is the total number of PCIe controller on a SoC (for LS1043 its 3, for= LX2160 its 6) A platform may use few of them based on the RCW (For Ex: LX2160aRdbPkg has = only PEX3 and PEX5 . LX2160aQdsPkg may have all 6 controller enabled). >=20 > / > Leif >=20 > > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutBase|0x80000 > > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutDbg|0x407FC > > + > > [PcdsFeatureFlag] > > gNxpQoriqLsTokenSpaceGuid.PcdI2cErratumA009203|TRUE > > > > -- > > 2.7.4 > >