From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (EUR02-AM5-obe.outbound.protection.outlook.com [40.107.0.87]) by mx.groups.io with SMTP id smtpd.web11.29.1587653612589182686 for ; Thu, 23 Apr 2020 07:53:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp.com header.s=selector2 header.b=RblReLGa; spf=pass (domain: nxp.com, ip: 40.107.0.87, mailfrom: wasim.khan@nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q5pCDejfNwlHYSAjwuOcLLGnUlyldiNZgOzadLDAtIHtL1kH1HbdLp8CUR79xUwh9ZNQl0S06D4rmvFpsAEHaqAVaPVznGOBKdzZvgkL7xQn+AFX375CFt8gHIXp4MI4hlpEbQL+8+T63nur+maqWo+bWf2atrZlxE1TWVBv9i3FJ/MzKapNshBM4CsrI+8/ZSIAxOuGKbLIzvSQRHQprvaGBJfJGQD61fcqg6O8KjwmEeHnK5vKaXyfO6+eoxdo6BmIvaWeEceFHZ9xveg+LGhxqLC1cD4YGrnXS5Nxs3gEJymA1r6dJLuaXEp/S06+tQDCL6HvoH2E0JgVbm1rGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IgtE9+RQGtDplNaeaGgerl4DaAitUD/uQUQoXbPJ/WM=; b=N0SqXq97QFx0sAvh87DRkqQYjGSGp0x7lV22ZBxM+fCyj8ZfVyL53h3Ol4bSOBXBLpCDvA/u+IFLOmtja9IwlCxGAjr+ep3Ro2tD/rvIYNcG6peDY7yRTd5l+eD6LUj+8bE96J0DI8hjssTN4rpEblaSIYvZaNZHZlp29lua40v1ugLDLMRpePPnCQozc12RzrHZZ+aQcgTsjZBlPWMLhZXY90u5ODdneUyw7B8iBXIi63rqEOtbt2KoNIJYXy/6qfy0Bnsjv3YYL3J72h5TsgcSInazYY9T9jTRUT4ijXoPm8c1I91oB9yJDvG+8W74Er5hTW07NO5dShTMa4+Teg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IgtE9+RQGtDplNaeaGgerl4DaAitUD/uQUQoXbPJ/WM=; b=RblReLGa0AIb/aqCtL7om7TqI+pdtz342V9gqSC182wocvuVT9ukj6/yYu4To0E/NLiPSqTOlSJHB8Zp11DPn1QtPtIPr1aNjD/ihzbeeox+R4Cv8ij2T+cjj7yAiLW2MJi1ppIz4y2Stig3Dv5e8DSAIhJ4luJjMw3eVcWgbLc= Received: from VE1PR04MB6702.eurprd04.prod.outlook.com (2603:10a6:803:123::13) by VE1PR04MB6494.eurprd04.prod.outlook.com (2603:10a6:803:127::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Thu, 23 Apr 2020 14:53:30 +0000 Received: from VE1PR04MB6702.eurprd04.prod.outlook.com ([fe80::c092:8f65:8b04:dd28]) by VE1PR04MB6702.eurprd04.prod.outlook.com ([fe80::c092:8f65:8b04:dd28%5]) with mapi id 15.20.2937.012; Thu, 23 Apr 2020 14:53:30 +0000 From: "Wasim Khan" To: "devel@edk2.groups.io" , "ray.ni@intel.com" CC: "ard.biesheuvel@linaro.org" , Varun Sethi , "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks Thread-Index: AQHWGVwVTvFEzXmpYUaOtumZsnOqHqiGlDUAgAAjx6CAAAwcAIAABY1w Date: Thu, 23 Apr 2020 14:53:30 +0000 Message-ID: References: <1587638612-13056-1-git-send-email-wasim.khan@nxp.com> <734D49CCEBEEF84792F5B80ED585239D5C50A98E@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C50AEFD@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C50AEFD@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=wasim.khan@nxp.com; x-originating-ip: [157.37.24.42] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 429ec381-d338-4ed3-4768-08d7e796168c x-ms-traffictypediagnostic: VE1PR04MB6494:|VE1PR04MB6494: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 03827AF76E x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6702.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(366004)(396003)(346002)(136003)(39860400002)(376002)(478600001)(76116006)(83080400001)(66446008)(66556008)(7696005)(966005)(66476007)(186003)(6506007)(26005)(45080400002)(15650500001)(53546011)(66946007)(2906002)(64756008)(8676002)(86362001)(81156014)(9686003)(44832011)(33656002)(316002)(54906003)(71200400001)(110136005)(52536014)(4326008)(8936002)(5660300002)(55016002);DIR:OUT;SFP:1101; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h5ZKkigMmUHCyE6RuCTvUtyq5yp86pGMeIT0vHZGJfHdboLC3Qv28fSnCsqI9e5TBrp0FU6h7aIFquHX1kQTq1kLM+h69PgoP9LpSaK3HQAwGGabO0nZK8eveLXsn3vlzXBLOmOxL/X2iPVMgjj3eH7E0EK6Q4cQtfq0aTTtsFs7VWcZ+zGU7oYOAb3KZ9ABzYaUXVcTWigFIeU3I+Zg69+PjFYiAZjcKypQBOmiXhUC0y3tAx+YrTXeH+uPt4P8XJgxt6zlIJ0D+ikIdMMdUT/HA2r8QNeuwP3Hm6gJvd4ymj59iNwvVLKZU5UChL0b9HXr8WIrVLdS4EUYUVKHB82lGNtdG7eGQjDPsphs98njgA7VxJ06ppH5B28pA8MdWkp/NJ88lFgzHQ4ugmzxELkmTxdnuZXNpZl70yU3/Xe/cciTGZdxYzRom+0IqwGtqNUy+z85R88nIDf2jIo9fvUgRv7uRzzmoca2iDLm4UBnSSd/1qth7dubbJG40xVZADyzFiI3wFdX1VOPKFMMJQ== x-ms-exchange-antispam-messagedata: BltAlBVDTxa8TTx6uv98PDDTWYXNKrVVddSj+bfcaK0RanctBpPwMyyNUUug68ZepWjgiajUp+tVMY6JjoT9zWTbKvg3Onf74DtrUdUq0dYkr5hvxDTCV577qHjukjvft/25hAHumldoZDM0cEop4w== MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 429ec381-d338-4ed3-4768-08d7e796168c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2020 14:53:30.5067 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QNDReTF/fTiyQh8jERFJjuvzGIVQrbLcUpUvvN1OrU95i4EG5yycQtwH21+Dyf7ranKbMiBS7EsQZJwnFFK/gA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6494 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ni, Ray v= ia > groups.io > Sent: Thursday, April 23, 2020 7:58 PM > To: devel@edk2.groups.io; Wasim Khan > Cc: ard.biesheuvel@linaro.org; Varun Sethi ; Wu, Hao A > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem > and PMem Limit Checks >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Wasim > > Khan > > Sent: Thursday, April 23, 2020 9:52 PM > > To: Ni, Ray ; devel@edk2.groups.io > > Cc: ard.biesheuvel@linaro.org; Varun Sethi ; Wu, Hao > > A > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update > > Mem and PMem Limit Checks > > > > > > > > > -----Original Message----- > > > From: Ni, Ray > > > Sent: Thursday, April 23, 2020 5:07 PM > > > To: Wasim Khan ; devel@edk2.groups.io > > > Cc: ard.biesheuvel@linaro.org; Varun Sethi ; Wu, > > > Hao A > > > Subject: RE: [PATCH] MdeModulePkg/PciHostBridge: Update Mem and > PMem > > > Limit Checks > > > > > > Thanks for fixing the check. > > > > > > PCI_ROOT_BRIDGE_APERTURE.Base/Limit are device address while the > > > memory space in GCD belongs to host domain. > > > So, host address for Mem/Pmem should be below 4GB while device > > > address can across 4GB. > > > > > > > > > Hi Ray, > > Thank you for the review. > > There are cases when we don't have PCIe host address below 4GB, and > > the PCIe HOST Address space is only available above 4GB. > > For Example, Mem: 40000000 - FFFFFFFF Translation=3DFFFFFF6000000000 > > will result in HOST Address =3D 0xA0FFFFFFFF . This is a valid use cas= e, but below > check will report ASSERT for this HOST ADDRESS. >=20 > OK. Now I remember that "Mem" reports the 32bit memory space (device > address) and "MemAbove4GB" reports the 64bit memory space (device addres= s). >=20 > Then if "Mem" reports memory range that across 4GB, it means the range a= bove > 4GB should be reported through "MemAbove4GB". >=20 Yes this is true, but some devices needs MMIO 32bit space only as per thei= r BAR property, including E1000 EP. >=20 >=20