From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Ju0ZqTzg; spf=pass (domain: arm.com, ip: 40.107.2.62, mailfrom: krzysztof.koch@arm.com) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.62]) by groups.io with SMTP; Fri, 26 Jul 2019 09:33:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XwAoEpthYFkeHQLe1MgcR0rcMjZW/GpXS+afSYdD+IfGgcDn4aNPZEbPMPRLEKPEipUweoCb9WkogOfVIChfIIlialkFbYzmF3J25RUOn1XufteuEOkowt8Y4TuYgE+auVv+DDouWDCHiCuUIsxaVCp/10QSGG/H8JXKuzThnwItDwhukBl9Z6o2Qi1/QIrPUSEN8eVu3R0dRJdbptcR9Fs0HQd5BhgWD+CGPc8A5tKwVbsnvILcksSTelxbrBJAxcGYSZqTVZ0szxf6GKV9ZldoHB7uShcSBusxkHMblcVA5o6SnZuCEhgbuKIndKdPMcPYxKqT3l671hnghWQGoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TEV41wyvHMPZ668m4Y0RgVJLypQZBOifX20hfA20bIg=; b=khJKgkvWCdFuuiNVyvEltZQej3oc+VjN5e6Br1Cwz025OLPzx+PNVLpi6hL61MkatVBMItxkkS8frTL2xVTd9b7ydQS3qFN73vqKrzVMG4OKiUgqtI1EVf7OmMhDNO/fhe5Q2fdZIdnm3n3TKVINDtxH1EpdT3m2VxK6r2DHPzbvLL1hmIVE7Y/yiDoUKhSdTuMh8m7Azu8h1WAaQM9bBc25JLmiVSqihR3qKQrGaBj1NttNicImIbRIa0DEXVZEfzKI22sdFrAeJli4C0kDwNWkT9WRR6S7yvlCASl/RcsmCSnHQ8sAQEDGuAzee6VekAJIlmSz+QWXWf2OsnIveA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TEV41wyvHMPZ668m4Y0RgVJLypQZBOifX20hfA20bIg=; b=Ju0ZqTzgWT6+aPG64fLjkgI/3CeDllcADoSKViB0+258uWePc2Q99Ozj/JFslOkTHXgUJKm5Nfql5JnDmaIw4EH23IqzpvXLttErI8q7kuskcTiJOPxQ7UHjcczq7qqi4VPeaVbQHj5TkU/b9aVne4jE2F18LsIos8rZewSs554= Received: from VE1PR08MB4783.eurprd08.prod.outlook.com (10.255.114.16) by VE1PR08MB4941.eurprd08.prod.outlook.com (10.255.158.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Fri, 26 Jul 2019 16:33:01 +0000 Received: from VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::f4e3:f22c:4d38:a698]) by VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::f4e3:f22c:4d38:a698%7]) with mapi id 15.20.2115.005; Fri, 26 Jul 2019 16:33:01 +0000 From: "Krzysztof Koch" To: "devel@edk2.groups.io" CC: "jaben.carsey@intel.com" , "ray.ni@intel.com" , "zhichao.gao@intel.com" , nd Subject: Re: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style enhancements and refactoring Thread-Topic: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style enhancements and refactoring Thread-Index: AQHVQGIvzXs3u+EzxkOyi2f9ZoJx6abWTBGAgAGsESCABSTPAA== Date: Fri, 26 Jul 2019 16:33:00 +0000 Message-ID: References: <15B3AB4E8413227A.7925@groups.io> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 43e98785-3ad4-4c97-91fe-362fd1b82d9e.1 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Krzysztof.Koch@arm.com; x-originating-ip: [217.140.106.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d81eecbc-5e8f-4755-bca7-08d711e6ece6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VE1PR08MB4941; x-ms-traffictypediagnostic: VE1PR08MB4941: x-ms-exchange-purlcount: 4 x-microsoft-antispam-prvs: nodisclaimer: True x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 01106E96F6 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(189003)(53754006)(199004)(13464003)(7696005)(102836004)(2906002)(55016002)(14454004)(5640700003)(99286004)(71200400001)(76116006)(6246003)(71190400001)(86362001)(8936002)(26005)(966005)(66066001)(2351001)(478600001)(66476007)(52536014)(6916009)(76176011)(6436002)(64756008)(66446008)(66946007)(68736007)(66556008)(6506007)(81166006)(7736002)(81156014)(8676002)(305945005)(2501003)(54906003)(9686003)(1730700003)(186003)(229853002)(316002)(6306002)(53546011)(486006)(25786009)(11346002)(5660300002)(446003)(74316002)(4326008)(3846002)(14444005)(256004)(33656002)(476003)(53936002)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB4941;H:VE1PR08MB4783.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: z69s+z1PxrRerFjaRKrs3PpSzNhdlaG+PqshuivH3gp//SbS4rs75m/YUA5VxCWa/fYzAOWitqfQUpy/zJ8iPZkIzyoZ9FQV6pIvEy2ZPMhqr+k+H3QPzUIQXaGK4np+Sq3u0dyiOGMBUYfM2lMGRp6AXC0EVQUNEeXjmL99bD6TFb5QD4bKNrq1afy751Zrnf0giA4AMsNg1dssg+Pqwk0j/mRT2Jx0L+kR7s+JcCHdi5BoyqJ3L0bNiLSiq0yEQsnyN7yww5ivntpydNDupTiPsQSbGX3J2nDD+XrbkaB8yQqzXdh9I4queQ63MaHNemhF0SAaZBhp0Kgpl+yhUBwvl9deP8bgDfNV4M1YGv2WUGjCROtB0KqwQCswmdToe9z0ZLZHiSRVjp9sXj68qoQY4c9ZF6UU3KHSOtwEK5I= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: d81eecbc-5e8f-4755-bca7-08d711e6ece6 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2019 16:33:00.9150 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Krzysztof.Koch@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4941 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Is there any way I can help get this patch merged? I have a couple of smal= l patch sets ready to submit but they are pending on this series.=20 These small sets of patches are a result of me breaking down the "[PATCH v= 1 00/11] Add security checks in the Acpiview table parsers" series into sma= ller functional units as requested in the review comments. Kind regards, Krzysztof -----Original Message----- From: Sami Mujawar =20 Sent: Tuesday, July 23, 2019 10:57 To: Krzysztof Koch ; devel@edk2.groups.io Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; nd Subject: RE: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style= enhancements and refactoring Reviewed-by: Sami Mujawar -----Original Message----- From: Krzysztof Koch =20 Sent: 22 July 2019 09:25 AM To: devel@edk2.groups.io; Krzysztof Koch Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Sami = Mujawar ; nd Subject: RE: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style= enhancements and refactoring Hi Everyone, Just to let you know, only "ShellPkg: acpiview: Allow passing buffer lengt= h to DumpGasStruct()" is changed compared to v1. I had a wrong understandin= g of how to post revised patches to the upstream community. Kind regards, Krzysztof -----Original Message----- From: devel@edk2.groups.io On Behalf Of Krzysztof K= och via Groups.Io Sent: Monday, July 22, 2019 8:50 To: devel@edk2.groups.io Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Sami = Mujawar ; Matteo Carlini ; nd= Subject: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style enh= ancements and refactoring This set of patches consists of a number of changes which make the code st= ructure consistent across the existing ACPI table parsers. These are all re= factoring changes which do not modify the existing functionality of the acp= iview UEFI shell tool. Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/612_ac= piview_code_style_enhance_v2 Krzysztof Koch (6): ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct() ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call ShellPkg: acpiview: RSDP: Make code consistent with other parsers ShellPkg: acpiview: SRAT: Minor code style enhancements ShellPkg: acpiview: MADT: Split structure length validation ShellPkg: acpiview: IORT: Refactor PMCG node mapping count validation ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | = 26 +++++++++------- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | = 8 +++-- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c | = 2 +- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser= .c | 32 ++++++++++++++------ ShellPkg/Library/UefiShellAcpiViewCommandLib/= Parsers/Madt/MadtParser.c | 30 +++++++++++++----- ShellPkg/Library/UefiShe= llAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c | 11 +++++-- ShellPkg/Libra= ry/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | 3 +- ShellPkg/= Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c | 18 +++-----= --- 8 files changed, 82 insertions(+), 48 deletions(-) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'