From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=RLnXrpmq; spf=pass (domain: arm.com, ip: 40.107.2.79, mailfrom: krzysztof.koch@arm.com) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.79]) by groups.io with SMTP; Mon, 22 Jul 2019 01:24:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jqct66SVhvKingCXOU43Hzj20Pe8F45PRwwuwK2wccPS5t/ICfxQWE1uZfW0K4fCASMpJqoB2hIwhkeuK6yVUOroTSLHkxOUL/RgL3FiWacTkvmaTZNixgXQVNUMFhGVUuKuSDa0wHZC1ZpX/LtguKvK5nUdXcLm8trSaMukoXxE5zFJAjMTZwTKpGWQ1ng8bJAVh8EBZf4SrT8j6XBvIsrsA70F4PYZRwhEjogvDc+b1BbieTAzNapE+Iz3tTklYUpQsGSUb3qyWwnrBjav50onu6iTxkcS/Dxo5MfBtyu1/V/fm9l55u54l1OnGAUuQBK9NWzLk5FZLhCNNjMj/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JoryLwRZDgYr/dp1Cg9OPfATdQaOCfOtfbitYt7Ao6c=; b=CyXpNPgO8zCdwFdjBGEWV/lrcGMgXpqfNUsmd7u9oQLupYk6Sbl7DWzBbSiw2rTLfg1CSf36W+n2odfUsC5UQS74nrCbvBJJ5vaWDtx7BNM74TBTpuvQerLT97RbbHb9LRbFjfRToULpaYiCjTeRNJJZYLn+EUNMLyXLiPRwlOKWP2GJwlmG1RbW/yZXIEaaFq42o2nXcSiPsiWt8XN/EL+TYipWs5Aok0BMvlSvRiy+fnFoOhVMYev8gxCdv1cl9Yj9k+fwJjjMJ2sPR3z0U+Md4g9OsmpFrKL6FnS2FggnpTMSQgIEYKyxt3r+tY1LlVspytak9lPpBjj9QYIHWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JoryLwRZDgYr/dp1Cg9OPfATdQaOCfOtfbitYt7Ao6c=; b=RLnXrpmqvSO+P2+aaX58N/i7ZbpDIojXb8EJX8Rj+N7XKUK5kisJ+ECCbpJrV+layG34qpRTgfCJDseMZUIrfpodrEALMmyDTYgT/+jbPUpxbjUHVGtxI/37Q0sG1c1uLekp0o6sztmDd4i5IvbBYj/9gdEeCU3ltlY7SKhU758= Received: from VE1PR08MB4783.eurprd08.prod.outlook.com (10.255.114.16) by VE1PR08MB4653.eurprd08.prod.outlook.com (10.255.27.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.17; Mon, 22 Jul 2019 08:24:32 +0000 Received: from VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::b0b9:419a:91bb:2418]) by VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::b0b9:419a:91bb:2418%4]) with mapi id 15.20.2094.013; Mon, 22 Jul 2019 08:24:32 +0000 From: "Krzysztof Koch" To: "devel@edk2.groups.io" , Krzysztof Koch CC: "jaben.carsey@intel.com" , "ray.ni@intel.com" , "zhichao.gao@intel.com" , Sami Mujawar , nd Subject: Re: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style enhancements and refactoring Thread-Topic: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style enhancements and refactoring Thread-Index: AQHVQGIvzXs3u+EzxkOyi2f9ZoJx6abWTBGA Date: Mon, 22 Jul 2019 08:24:32 +0000 Message-ID: References: <15B3AB4E8413227A.7925@groups.io> In-Reply-To: <15B3AB4E8413227A.7925@groups.io> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8782aa6f-15cc-46a8-bfe3-b1bba00c53d4.0 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Krzysztof.Koch@arm.com; x-originating-ip: [217.140.106.50] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ad03bb2f-6bcf-453d-c1c6-08d70e7e061e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VE1PR08MB4653; x-ms-traffictypediagnostic: VE1PR08MB4653: x-ms-exchange-purlcount: 4 x-microsoft-antispam-prvs: nodisclaimer: True x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 01068D0A20 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(376002)(346002)(39860400002)(396003)(366004)(53754006)(189003)(199004)(13464003)(256004)(68736007)(86362001)(316002)(8936002)(8676002)(76176011)(81156014)(81166006)(6246003)(6306002)(2906002)(55016002)(71200400001)(33656002)(9686003)(478600001)(74316002)(6436002)(53936002)(71190400001)(305945005)(7736002)(7696005)(229853002)(66066001)(966005)(486006)(5660300002)(186003)(6506007)(476003)(6116002)(3846002)(66946007)(66446008)(66476007)(66556008)(64756008)(25786009)(11346002)(53546011)(446003)(4326008)(76116006)(52536014)(99286004)(110136005)(102836004)(14454004)(2501003)(26005)(54906003);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB4653;H:VE1PR08MB4783.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kCKj1gg83lQZehafmagJ5xeHZqM+Bnap71sCN28D/dimUPUH7dNbAmAzh8NeMi7W2Wvnl8c1aefwRlM0k5aHClzDQ2jz4UQvhHU7qYXK+4hQyd9nvaX0PAxq4f/W7eHPzaTIJBZHP+w5z8YMZdFvIDK75ZWhkO8ZxQLpO01hf00XwNfpI0PZzRI1ppeAgMdvjzplgd/9+FGSlA7I3qTMLEvad0SuoB6heIOCP4W6WNsKo7uPAkZDxaEte8HZp8ytQ6b/1XlxixTchRwjg9qZ729tNd7QpASBBnWpyYW3AJR7w/pTVkmmRr0VAUbtO1DXMB3L4pNYN3b6UhElrhAtw4Cz9nYLJem6zHiTc+FDFcbT8Q3SJR4XX0+KrrsJSITwk/OOv0naWPpCdrzhCvjEZ3Cs5Aw/Vcu2CAfRIToGZIk= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad03bb2f-6bcf-453d-c1c6-08d70e7e061e X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2019 08:24:32.6472 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Krzysztof.Koch@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4653 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Everyone, Just to let you know, only "ShellPkg: acpiview: Allow passing buffer lengt= h to DumpGasStruct()" is changed compared to v1. I had a wrong understandin= g of how to post revised patches to the upstream community. Kind regards, Krzysztof -----Original Message----- From: devel@edk2.groups.io On Behalf Of Krzysztof K= och via Groups.Io Sent: Monday, July 22, 2019 8:50 To: devel@edk2.groups.io Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Sami = Mujawar ; Matteo Carlini ; nd= Subject: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style enh= ancements and refactoring This set of patches consists of a number of changes which make the code st= ructure consistent across the existing ACPI table parsers. These are all re= factoring changes which do not modify the existing functionality of the acp= iview UEFI shell tool. Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/612_ac= piview_code_style_enhance_v2 Krzysztof Koch (6): ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct() ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call ShellPkg: acpiview: RSDP: Make code consistent with other parsers ShellPkg: acpiview: SRAT: Minor code style enhancements ShellPkg: acpiview: MADT: Split structure length validation ShellPkg: acpiview: IORT: Refactor PMCG node mapping count validation ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | = 26 +++++++++------- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | = 8 +++-- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c | = 2 +- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser= .c | 32 ++++++++++++++------ ShellPkg/Library/UefiShellAcpiViewCommandLib/= Parsers/Madt/MadtParser.c | 30 +++++++++++++----- ShellPkg/Library/UefiShe= llAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c | 11 +++++-- ShellPkg/Libra= ry/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | 3 +- ShellPkg/= Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c | 18 +++-----= --- 8 files changed, 82 insertions(+), 48 deletions(-) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'