From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=DKJLD1zr; spf=pass (domain: arm.com, ip: 40.107.0.63, mailfrom: krzysztof.koch@arm.com) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (EUR02-AM5-obe.outbound.protection.outlook.com [40.107.0.63]) by groups.io with SMTP; Wed, 15 May 2019 01:23:41 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1hQyqBqcIPlzWI7g7XakXkJNtqeyZPxaPt3P1MfmfUk=; b=DKJLD1zrO1lrIvrvi1HWxK3U1dtFq7jT9dADKErOHPhQaL7uhRf2qENShbiYDT2YujuscL3+gntdXpM+4i1tyFEY0ulNF8ieAHzcQDeCOwHL2qyX8OPMGSz66/86ZTsBcEfhF84ri9qCkSD659EteR9qx4maqLdrmrXF2/6G5lo= Received: from VE1PR08MB4783.eurprd08.prod.outlook.com (10.255.114.16) by VE1PR08MB5038.eurprd08.prod.outlook.com (10.255.159.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.16; Wed, 15 May 2019 08:23:38 +0000 Received: from VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::eda0:d207:467d:4f00]) by VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::eda0:d207:467d:4f00%3]) with mapi id 15.20.1900.010; Wed, 15 May 2019 08:23:38 +0000 From: "Krzysztof Koch" To: "devel@edk2.groups.io" , "jaben.carsey@intel.com" , "ray.ni@intel.com" CC: Sami Mujawar , nd Subject: Re: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation Thread-Topic: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation Thread-Index: AQHVBmxEnSmhlWHYMEOs6+7K2coNIqZr4aWA Date: Wed, 15 May 2019 08:23:38 +0000 Message-ID: References: <20190131133008.14620-1-krzysztof.koch@arm.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Krzysztof.Koch@arm.com; x-originating-ip: [217.140.106.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7db12306-e6a8-4612-dce2-08d6d90ea1f1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:VE1PR08MB5038; x-ms-traffictypediagnostic: VE1PR08MB5038: x-ms-exchange-purlcount: 1 nodisclaimer: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-forefront-prvs: 0038DE95A2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(136003)(366004)(396003)(376002)(39860400002)(199004)(189003)(13464003)(68736007)(186003)(486006)(316002)(64756008)(66556008)(2501003)(74316002)(66476007)(6116002)(3846002)(53936002)(66446008)(71200400001)(71190400001)(76116006)(26005)(66946007)(73956011)(86362001)(2201001)(54906003)(110136005)(2906002)(478600001)(33656002)(5660300002)(25786009)(99286004)(9686003)(55016002)(256004)(6306002)(6246003)(229853002)(14454004)(4326008)(8936002)(966005)(446003)(81156014)(11346002)(81166006)(53546011)(6506007)(66066001)(476003)(102836004)(6436002)(76176011)(52536014)(72206003)(305945005)(7696005)(8676002)(7736002)(213903007);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB5038;H:VE1PR08MB4783.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: MB/tKSa5InMIl6luYc8eW/uZWOGXP4kERU7JiwRusoM3zRN/rv9v0LO5zl/M+J7mI370mHe63ic3rCkKTnEb5Ktubp+t/zyH/aCedinhqagKK38KpsPFFfGIRQdcxtusGXGz5qygvqGZg17wkEAOpc1oTKE2ZtfZhLpOdRJ/itHTqLisXJ0F3Q4T80RzNXfvHQ+JcqbaUd/4o+6f0wdGtpCjQ85+LEu7XIrHMRXwfnEmmTc1ETpBd62FUhGqo3w1s0/XK/69Vju4CpHNhvSxcCFpjtzmGpPnDSOYvgbr8T/ImDnHaE/p4YuXqafPJICQxbudVZvg29LtSV1nZAeO+/lQrC81a2FDwXz63CVlsbuk59r6E4B0BGdeas5SCL4zuytDKoeeJGs4l3gsKKTcT/Ba99vtCTsSS6sC3VC0Q7c= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7db12306-e6a8-4612-dce2-08d6d90ea1f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2019 08:23:38.8025 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5038 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jaben and Ray, It's been a while since I posted this patch. Can I help you in any way to g= et this merged? Kind regards, Krzysztof Koch -----Original Message----- From: Sami Mujawar =20 Sent: Thursday, May 9, 2019 14:37 To: devel@edk2.groups.io Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini ; Stephanie Hughes-Fitt ; nd ; Krzysztof Koch Subject: RE: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT = cache attributes validation Reviewed-by: Sami Mujawar Regards, Sami Mujawar -----Original Message----- From: Krzysztof Koch =20 Sent: 31 January 2019 01:30 PM To: edk2-devel@lists.01.org Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini ; Stephanie Hughes-Fitt ; Sami Muj= awar ; nd Subject: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cach= e attributes validation Removed conditional pre-compiling for ARM CPUs because function ValidateCacheAttributes(..) is based on ACPI PPTT specification. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Krzysztof Koch Reported-by: Zhichao Gao --- The code can be found at:=20 https://github.com/KrzysztofKoch1/edk2/tree/woa_422_cache_valid_fix_v1 Notes: v1: - removed conditional precompilation [Krzysztof] ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 3= --- 1 file changed, 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/Pptt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttPa= rser.c index bc56fe9ea1dd9c1e98a6a568d3f9191263bedc90..b6b420890a3494869020ed8bcc7= b791fcf7d70f3 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.= c @@ -86,11 +86,9 @@ ValidateCacheAttributes ( IN VOID* Context ) { -#if defined(MDE_CPU_ARM) || defined (MDE_CPU_AARCH64) // Reference: Advanced Configuration and Power Interface (ACPI) Specific= ation // Version 6.2 Errata A, September 2017 // Table 5-153: Cache Type Structure - UINT8 Attributes; Attributes =3D *(UINT8*)Ptr; =20 @@ -102,7 +100,6 @@ ValidateCacheAttributes ( ); return; } -#endif } =20 /** --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'