* [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation
@ 2019-01-31 13:30 Krzysztof Koch
2019-05-09 13:36 ` Sami Mujawar
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Koch @ 2019-01-31 13:30 UTC (permalink / raw)
To: edk2-devel
Cc: jaben.carsey, ray.ni, Matteo.Carlini, Stephanie.Hughes-Fitt,
Sami.Mujawar, nd
Removed conditional pre-compiling for ARM CPUs because function
ValidateCacheAttributes(..) is based on ACPI PPTT specification.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
Reported-by: Zhichao Gao <zhichao.gao@intel.com>
---
The code can be found at:
https://github.com/KrzysztofKoch1/edk2/tree/woa_422_cache_valid_fix_v1
Notes:
v1:
- removed conditional precompilation [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
index bc56fe9ea1dd9c1e98a6a568d3f9191263bedc90..b6b420890a3494869020ed8bcc7b791fcf7d70f3 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
@@ -86,11 +86,9 @@ ValidateCacheAttributes (
IN VOID* Context
)
{
-#if defined(MDE_CPU_ARM) || defined (MDE_CPU_AARCH64)
// Reference: Advanced Configuration and Power Interface (ACPI) Specification
// Version 6.2 Errata A, September 2017
// Table 5-153: Cache Type Structure
-
UINT8 Attributes;
Attributes = *(UINT8*)Ptr;
@@ -102,7 +100,6 @@ ValidateCacheAttributes (
);
return;
}
-#endif
}
/**
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation
2019-01-31 13:30 [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation Krzysztof Koch
@ 2019-05-09 13:36 ` Sami Mujawar
2019-05-15 8:23 ` Krzysztof Koch
2019-05-17 2:26 ` Gao, Zhichao
0 siblings, 2 replies; 5+ messages in thread
From: Sami Mujawar @ 2019-05-09 13:36 UTC (permalink / raw)
To: devel@edk2.groups.io
Cc: jaben.carsey@intel.com, ray.ni@intel.com, Matteo Carlini,
Stephanie Hughes-Fitt, nd, Krzysztof Koch
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com>
Sent: 31 January 2019 01:30 PM
To: edk2-devel@lists.01.org
Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation
Removed conditional pre-compiling for ARM CPUs because function
ValidateCacheAttributes(..) is based on ACPI PPTT specification.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
Reported-by: Zhichao Gao <zhichao.gao@intel.com>
---
The code can be found at:
https://github.com/KrzysztofKoch1/edk2/tree/woa_422_cache_valid_fix_v1
Notes:
v1:
- removed conditional precompilation [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
index bc56fe9ea1dd9c1e98a6a568d3f9191263bedc90..b6b420890a3494869020ed8bcc7b791fcf7d70f3 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
@@ -86,11 +86,9 @@ ValidateCacheAttributes (
IN VOID* Context
)
{
-#if defined(MDE_CPU_ARM) || defined (MDE_CPU_AARCH64)
// Reference: Advanced Configuration and Power Interface (ACPI) Specification
// Version 6.2 Errata A, September 2017
// Table 5-153: Cache Type Structure
-
UINT8 Attributes;
Attributes = *(UINT8*)Ptr;
@@ -102,7 +100,6 @@ ValidateCacheAttributes (
);
return;
}
-#endif
}
/**
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation
2019-05-09 13:36 ` Sami Mujawar
@ 2019-05-15 8:23 ` Krzysztof Koch
2019-05-15 15:30 ` [edk2-devel] " Dandan Bi
2019-05-17 2:26 ` Gao, Zhichao
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Koch @ 2019-05-15 8:23 UTC (permalink / raw)
To: devel@edk2.groups.io, jaben.carsey@intel.com, ray.ni@intel.com
Cc: Sami Mujawar, nd
Hi Jaben and Ray,
It's been a while since I posted this patch. Can I help you in any way to get this merged?
Kind regards,
Krzysztof Koch
-----Original Message-----
From: Sami Mujawar <Sami.Mujawar@arm.com>
Sent: Thursday, May 9, 2019 14:37
To: devel@edk2.groups.io
Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>; Krzysztof Koch <Krzysztof.Koch@arm.com>
Subject: RE: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com>
Sent: 31 January 2019 01:30 PM
To: edk2-devel@lists.01.org
Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation
Removed conditional pre-compiling for ARM CPUs because function
ValidateCacheAttributes(..) is based on ACPI PPTT specification.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
Reported-by: Zhichao Gao <zhichao.gao@intel.com>
---
The code can be found at:
https://github.com/KrzysztofKoch1/edk2/tree/woa_422_cache_valid_fix_v1
Notes:
v1:
- removed conditional precompilation [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
index bc56fe9ea1dd9c1e98a6a568d3f9191263bedc90..b6b420890a3494869020ed8bcc7b791fcf7d70f3 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
@@ -86,11 +86,9 @@ ValidateCacheAttributes (
IN VOID* Context
)
{
-#if defined(MDE_CPU_ARM) || defined (MDE_CPU_AARCH64)
// Reference: Advanced Configuration and Power Interface (ACPI) Specification
// Version 6.2 Errata A, September 2017
// Table 5-153: Cache Type Structure
-
UINT8 Attributes;
Attributes = *(UINT8*)Ptr;
@@ -102,7 +100,6 @@ ValidateCacheAttributes (
);
return;
}
-#endif
}
/**
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation
2019-05-15 8:23 ` Krzysztof Koch
@ 2019-05-15 15:30 ` Dandan Bi
0 siblings, 0 replies; 5+ messages in thread
From: Dandan Bi @ 2019-05-15 15:30 UTC (permalink / raw)
To: devel@edk2.groups.io, krzysztof.koch@arm.com, Carsey, Jaben,
Ni, Ray
Cc: Sami Mujawar, nd
Hi Krzysztof Koch,
You patch is good to me.
Reviewed-by: Bi Dandan <dandan.bi@intel.com>
I think maintainers will help push soon if they don't have additional comments.
I have just one comments for future patches since this one is small and clear.
Could you help file a Bugzilla (if not have one)to track the issue and add the Bugzilla link into the patch if you submit patch to edk2? Thanks in advance for cooperation and contribution.
Thanks,
Dandan
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Krzysztof Koch
> Sent: Wednesday, May 15, 2019 4:24 PM
> To: devel@edk2.groups.io; Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray
> <ray.ni@intel.com>
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>; nd <nd@arm.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1]
> ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation
>
> Hi Jaben and Ray,
>
> It's been a while since I posted this patch. Can I help you in any way to get
> this merged?
>
> Kind regards,
>
> Krzysztof Koch
>
> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com>
> Sent: Thursday, May 9, 2019 14:37
> To: devel@edk2.groups.io
> Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini
> <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-
> Fitt@arm.com>; nd <nd@arm.com>; Krzysztof Koch
> <Krzysztof.Koch@arm.com>
> Subject: RE: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix
> PPTT cache attributes validation
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
> -----Original Message-----
> From: Krzysztof Koch <krzysztof.koch@arm.com>
> Sent: 31 January 2019 01:30 PM
> To: edk2-devel@lists.01.org
> Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini
> <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-
> Fitt@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd
> <nd@arm.com>
> Subject: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT
> cache attributes validation
>
> Removed conditional pre-compiling for ARM CPUs because function
> ValidateCacheAttributes(..) is based on ACPI PPTT specification.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
> Reported-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>
> The code can be found at:
> https://github.com/KrzysztofKoch1/edk2/tree/woa_422_cache_valid_fix_v1
>
> Notes:
> v1:
> - removed conditional precompilation [Krzysztof]
>
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
> | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> index
> bc56fe9ea1dd9c1e98a6a568d3f9191263bedc90..b6b420890a3494869020ed8bc
> c7b791fcf7d70f3 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> @@ -86,11 +86,9 @@ ValidateCacheAttributes (
> IN VOID* Context
> )
> {
> -#if defined(MDE_CPU_ARM) || defined (MDE_CPU_AARCH64)
> // Reference: Advanced Configuration and Power Interface (ACPI)
> Specification
> // Version 6.2 Errata A, September 2017
> // Table 5-153: Cache Type Structure
> -
> UINT8 Attributes;
> Attributes = *(UINT8*)Ptr;
>
> @@ -102,7 +100,6 @@ ValidateCacheAttributes (
> );
> return;
> }
> -#endif
> }
>
> /**
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation
2019-05-09 13:36 ` Sami Mujawar
2019-05-15 8:23 ` Krzysztof Koch
@ 2019-05-17 2:26 ` Gao, Zhichao
1 sibling, 0 replies; 5+ messages in thread
From: Gao, Zhichao @ 2019-05-17 2:26 UTC (permalink / raw)
To: devel@edk2.groups.io, sami.mujawar@arm.com
Cc: Carsey, Jaben, Ni, Ray, Matteo Carlini, Stephanie Hughes-Fitt, nd,
Krzysztof Koch
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Sami Mujawar
> Sent: Thursday, May 9, 2019 9:37 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt
> <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>; Krzysztof Koch
> <Krzysztof.Koch@arm.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1]
> ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
> -----Original Message-----
> From: Krzysztof Koch <krzysztof.koch@arm.com>
> Sent: 31 January 2019 01:30 PM
> To: edk2-devel@lists.01.org
> Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini
> <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-
> Fitt@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd
> <nd@arm.com>
> Subject: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT
> cache attributes validation
>
> Removed conditional pre-compiling for ARM CPUs because function
> ValidateCacheAttributes(..) is based on ACPI PPTT specification.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
> Reported-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>
> The code can be found at:
> https://github.com/KrzysztofKoch1/edk2/tree/woa_422_cache_valid_fix_v1
>
> Notes:
> v1:
> - removed conditional precompilation [Krzysztof]
>
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
> | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> index
> bc56fe9ea1dd9c1e98a6a568d3f9191263bedc90..b6b420890a3494869020ed8bc
> c7b791fcf7d70f3 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.
> c
> @@ -86,11 +86,9 @@ ValidateCacheAttributes (
> IN VOID* Context
> )
> {
> -#if defined(MDE_CPU_ARM) || defined (MDE_CPU_AARCH64)
> // Reference: Advanced Configuration and Power Interface (ACPI)
> Specification
> // Version 6.2 Errata A, September 2017
> // Table 5-153: Cache Type Structure
> -
> UINT8 Attributes;
> Attributes = *(UINT8*)Ptr;
>
> @@ -102,7 +100,6 @@ ValidateCacheAttributes (
> );
> return;
> }
> -#endif
> }
>
> /**
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-17 2:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-31 13:30 [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation Krzysztof Koch
2019-05-09 13:36 ` Sami Mujawar
2019-05-15 8:23 ` Krzysztof Koch
2019-05-15 15:30 ` [edk2-devel] " Dandan Bi
2019-05-17 2:26 ` Gao, Zhichao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox