Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

["Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>]

Thanks Ard and Laszlo.

Leif, Dandan, Liming, Hao, any objection in merging this patch to edk2?



> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: Wednesday, March 25, 2020 5:16 AM
> To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> Cc: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io;
> samer@elhajmahmoud.com; Dandan Bi <dandan.bi@intel.com>; Liming Gao
> <liming.gao@intel.com>; Hao A Wu <hao.a.wu@intel.com>; Leif Lindholm
> <leif@nuviainc.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg:
> PcdAcpiExposedTableVersions default for Arm64 platforms
>
> On Wed, 25 Mar 2020 at 03:04, Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com> wrote:
> >
> > Thanks Laszlo,
> >
> > I will wait for the maintainers to accept the patch, then submit an amended
> version for ArmVirtQemu.
> >
>
> For this patch
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> For any patch that removes this PCD override from AArch64 platforms in
> edk2 or edk2-platforms:
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
>
> > -----Original Message-----
> > From: Laszlo Ersek <lersek@redhat.com>
> > Sent: Tuesday, March 24, 2020 7:03 PM
> > To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>;
> > devel@edk2.groups.io; samer@elhajmahmoud.com
> > Cc: Dandan Bi <dandan.bi@intel.com>; Liming Gao
> > <liming.gao@intel.com>; Hao A Wu <hao.a.wu@intel.com>; Leif Lindholm
> > <leif@nuviainc.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg:
> > PcdAcpiExposedTableVersions default for Arm64 platforms
> >
> > On 03/23/20 13:53, Samer El-Haj-Mahmoud wrote:
> > > Thanks Laszlo
> > >
> > > I agree. But shouldn't we remove the PCD settings from all Arm64
> platforms that have this override value of 0x20?
> > >
> > > Namely:
> > >
> > > edk2/ArmVirtPkg/ArmVirtQemu.dsc
> > > edk2-platforms/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > > edk2-platforms/Platform/ARM/JunoPkg/ArmJuno.dsc
> > > edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
> > > edk2-platforms/Platform/Comcast/RDKQemu/RDKQemu.dsc
> > > edk2-platforms/Platform/Hisilicon/D06/D06.dsc
> > > edk2-platforms/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> > > edk2-platforms/Platform/SoftIron/Overdrive1000Board/Overdrive1000Boa
> > > rd .dsc edk2-platforms/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> > > edk2-platforms/Silicon/Socionext/SynQuacer/Acpi.dsc.inc
> >
> > If you can order the edk2-platforms changes safely after the edk2 DEC file
> change, then yes.
> >
> > Otherwise, I can't say.
> >
> > AFAICT, edk2-platforms does not consume edk2 via a git submodule, so the
> ordering looks risky. But I generally don't follow edk2-platforms (which is also
> why I didn't grep its DSC files for the PCD in question), so I really don't know
> how such ordering questions have been dealt with in the past.
> >
> > Thanks
> > Laszlo
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.