Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

["Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>]

Thanks Laszlo

I agree. But shouldn't we remove the PCD settings from all Arm64 platforms that have this override value of 0x20?

Namely:

edk2/ArmVirtPkg/ArmVirtQemu.dsc
edk2-platforms/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
edk2-platforms/Platform/ARM/JunoPkg/ArmJuno.dsc
edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
edk2-platforms/Platform/Comcast/RDKQemu/RDKQemu.dsc
edk2-platforms/Platform/Hisilicon/D06/D06.dsc
edk2-platforms/Platform/LeMaker/CelloBoard/CelloBoard.dsc
edk2-platforms/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
edk2-platforms/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
edk2-platforms/Silicon/Socionext/SynQuacer/Acpi.dsc.inc







-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek via Groups.Io
Sent: Monday, March 23, 2020 8:31 AM
To: devel@edk2.groups.io; samer@elhajmahmoud.com
Cc: Dandan Bi <dandan.bi@intel.com>; Liming Gao <liming.gao@intel.com>; Hao A Wu <hao.a.wu@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

On 03/22/20 17:08, Samer El-Haj-Mahmoud wrote:
> Set the default value of PcdAcpiExposedTableVersions for Aarch64
> platforms to 0x20. Previously, the default was set to 0x3E for all
> platforms. The new value removes ACPI 1.0b compatability, which forces
> the use of XSDT 64-bit pointer, as required by Arm SBBR specification.
> This also resolves an error reported by acpiview command, as seen on
> the RPi (see https://github.com/pftf/RPi4/issues/25).
>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec index 91a3c608231c..027f444903ef
> 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1549,6 +1549,9 @@ [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
>    # @Prompt Console Output Row of Text Setup
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x4000000e
>
> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
> +
> +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UINT3
> +2|0x0001004c
> +
>  [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
>    ## UART clock frequency is for the baud rate configuration.
>    # @Prompt Serial Port Clock Rate.
>

Please consider appending another patch to this series: once the new DEC default is in place, the same PCD setting is no longer necessary in, and should arguably be removed from, "ArmVirtPkg/ArmVirtQemu.dsc":

  # ACPI predates the AARCH64 architecture by 5 versions, so
  # we only target OSes that support ACPI v5.0 or later
  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20

Basically: "git revert e0692789058e".

Thanks!
Laszlo




IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.