From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.74]) by mx.groups.io with SMTP id smtpd.web12.51603.1584968005463676761 for ; Mon, 23 Mar 2020 05:53:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Iiic5cPx; spf=pass (domain: arm.com, ip: 40.107.21.74, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4C/SJgZAMStLxskSh/qE6Ylrwctdl/lOPdfsSwMS3ns=; b=Iiic5cPxn+bNBA2DQp4aZpOEffZoGGPOt0n8jReitvUEvAPhX1miZLdffdOUUxtTxgvYzRH14JxNQoS94cn1r2nCq9PRe9bjBSHF/0LytcAXjalrKrPHhF988WvL0Bu6gBwpcJUbVBANSfLtsqxeVd/c1omMp3Be5iijLBrgsn0= Received: from AM5PR0701CA0049.eurprd07.prod.outlook.com (2603:10a6:203:2::11) by AM6PR08MB5157.eurprd08.prod.outlook.com (2603:10a6:20b:e8::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.22; Mon, 23 Mar 2020 12:53:22 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::22) by AM5PR0701CA0049.outlook.office365.com (2603:10a6:203:2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.12 via Frontend Transport; Mon, 23 Mar 2020 12:53:22 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.13 via Frontend Transport; Mon, 23 Mar 2020 12:53:22 +0000 Received: ("Tessian outbound 47356f393f3c:v48"); Mon, 23 Mar 2020 12:53:22 +0000 X-CR-MTA-TID: 64aa7808 Received: from 8ad2cd12d8d3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4774F786-3275-4547-ACC9-06FC65242CA2.1; Mon, 23 Mar 2020 12:53:17 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8ad2cd12d8d3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 Mar 2020 12:53:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gTGXsH92UwPZc8Xe7x0xk+muq0nWBql12sISqVyvDDSGYXVq0V7wolT8iLaYvUNz9+5rb0oDDqlhLyyijc+wvhE+b9XTTAFs+kW25gt2XRcqw0XDtPPSQYnrYZSZc54lf6HB+v9TVEelvkSZTjRvHLooHZIXlZB4dFqC5rO7rrbV5sCfVP+HrDKc1E2jPGyLKGJp/n2Nn2J/EC8wTKz2evfxKKiE0g6p6gM72YtCyM1jVXcvfD3HegwX/d+tGY75TuRJCDv0VchVT1bT5YyiCDpKxfYjoYpt3/LfGehFl+RpWzqQ8Z/JIW6YZhs/sorITYwuey3OgpPocAQnXh/Jyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4C/SJgZAMStLxskSh/qE6Ylrwctdl/lOPdfsSwMS3ns=; b=dTCQh0SO+1D274Htj+Sr01p5j+mEH+5cRmfn0jo5bm2Ke8LNN/ggtujTXOYa1FgoFvwFiKduAQVrtFKbhXkT7Ha5Y7+C132b0/D5M1paE8og7y7T1MGQfeXWSRJN+wvsAi/sBZJy/uXFidfyxJyi9q7RVF6OjbhMsMBnuRB/toYwElg93AhWEKjjuz+ReQpZgLxiizFT3FRWf2u5Z07B/0YJcz43o8IGHkdotCJRLn6yK/BqZQ5aursaWJu7Cwem7fXhJq/9Pp8hE2tmVqh7yBdM8ce/dThJ/k7j3isuKam5jZuNvAuMmnIexzG+jqzBjIAGqnkEXJUqUujbVgG3Gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4C/SJgZAMStLxskSh/qE6Ylrwctdl/lOPdfsSwMS3ns=; b=Iiic5cPxn+bNBA2DQp4aZpOEffZoGGPOt0n8jReitvUEvAPhX1miZLdffdOUUxtTxgvYzRH14JxNQoS94cn1r2nCq9PRe9bjBSHF/0LytcAXjalrKrPHhF988WvL0Bu6gBwpcJUbVBANSfLtsqxeVd/c1omMp3Be5iijLBrgsn0= Received: from VE1PR08MB4830.eurprd08.prod.outlook.com (10.255.113.19) by VE1PR08MB5053.eurprd08.prod.outlook.com (20.179.31.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20; Mon, 23 Mar 2020 12:53:14 +0000 Received: from VE1PR08MB4830.eurprd08.prod.outlook.com ([fe80::f01b:f10f:d03f:e9c7]) by VE1PR08MB4830.eurprd08.prod.outlook.com ([fe80::f01b:f10f:d03f:e9c7%6]) with mapi id 15.20.2835.021; Mon, 23 Mar 2020 12:53:14 +0000 From: "Samer El-Haj-Mahmoud" To: "devel@edk2.groups.io" , "lersek@redhat.com" , "samer@elhajmahmoud.com" CC: Dandan Bi , Liming Gao , Hao A Wu , Leif Lindholm , Ard Biesheuvel , Samer El-Haj-Mahmoud Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms Thread-Topic: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms Thread-Index: AQHWAIX2x/Cf1PhBOkaxgGFsiktNcahWHOYAgAAEmzA= Date: Mon, 23 Mar 2020 12:53:14 +0000 Message-ID: References: <20200322160816.18426-1-samer@elhajmahmoud.com> <7f587b1f-c02d-eafc-581f-d3de10a6ee7f@redhat.com> In-Reply-To: <7f587b1f-c02d-eafc-581f-d3de10a6ee7f@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1cf35c8a-b54d-4a49-adb2-b1a4b5e909b6.1 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Samer.El-Haj-Mahmoud@arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 16e51e8b-f833-40c6-882e-08d7cf292b56 x-ms-traffictypediagnostic: VE1PR08MB5053:|VE1PR08MB5053:|AM6PR08MB5157: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7219;OLM:9508; x-forefront-prvs: 0351D213B3 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(346002)(366004)(39860400002)(376002)(136003)(396003)(199004)(64756008)(66556008)(66476007)(66946007)(66446008)(26005)(2906002)(76116006)(33656002)(86362001)(19627235002)(966005)(478600001)(71200400001)(7696005)(4326008)(8936002)(52536014)(5660300002)(8676002)(54906003)(186003)(81166006)(55016002)(110136005)(316002)(9686003)(53546011)(6506007)(81156014)(213903007);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB5053;H:VE1PR08MB4830.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Su2K64Vm39oy0jPMZbVBsW2KY5LRgRPCg5YlxQyIBNQvWwHCiewtq4Dkp4tdhfZE2ujI4EahiC+Uv/Kpf3GCDJTLG2ovbd1f/fnIBvwXZ4/qdNhY13zstRMH/BkEKokhol4LDQuUkhKTKB52dY5gNjwy1srRTVI0hhBB/FNuiAMx+GrWYB/sStB+zm0o4JDPdmFL+Hh5KP3rI7Y7wetSMzhDpMqjO8dRTB9XZZFwBfeD5xM5MB+tBWR2AZifrL66kAUpfo4O52E829cJhxidw/+QFahovVFAcaBUUsrJ7yamcvdRoGgjwtu6AOSGRU5lfw9fBplsGFpBEALqm5Vx4TL3y7b2tHvWW7k/a0kmPT6gtT3M7jNWsSzh8CuYFZxCMLq7h/fxtRVLJU5sG3QlIy2xb+3POLR+bCT1CT+5FidMx3JAHMxT7WPg2uUC/zsmII3BaJeW/6ftzONGpCoqLoH7KbyOCfeGFii82rZj3ca1l7s34JJNsv4V+aGnJrXMKquxxhIHT5zJnDJBSxM9a7T4WXdSd7k0PnVOh54KNGQlkuNbfrbQ4E1QV9J2hlg6 x-ms-exchange-antispam-messagedata: s3VF1lyToomM66w0RLDyrT6gEO+ZJwt7IEd9kAGXlcKvjzqg/byVA8ptsiAbsHbnBIpJba3eenOB58fSErJDt/Tev4CiLMS2o1Jd2gh9ZrJRoV5hDmY2MNnSoBajR8p4l9+W779BW3OhBCAKRA+ykA== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5053 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Samer.El-Haj-Mahmoud@arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(376002)(136003)(346002)(39860400002)(396003)(199004)(46966005)(316002)(53546011)(47076004)(6506007)(356004)(26005)(33656002)(186003)(70586007)(110136005)(54906003)(70206006)(86362001)(55016002)(5660300002)(8676002)(478600001)(9686003)(19627235002)(336012)(8936002)(966005)(7696005)(26826003)(52536014)(4326008)(81156014)(81166006)(2906002)(36906005)(213903007);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR08MB5157;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Pass;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 8bcdb129-7d23-40f2-caa5-08d7cf2926be X-Forefront-PRVS: 0351D213B3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nFHJnMjodLvwWpr6XCLfY1NC2FxByTs2ZCW6mDg+OcxoXZuWv1QbRY4sW0ILauFIuHDT8mjrgGqx0jD9MYOe9gXj4MVhJlMapi6uKV1OyghL7AUL1Ia+Fq2baX8tHxim8G9j+wi4kR+ETHEtPGROIdeluW5K5+rEzjBZ9mDs9RPypE2+8lu/nfv3hBdRNqk55CHJBC/Tx1wQ36IZeUUDKqUqJmf6+kZmKwI8ivI9SEf0K0y+ehl1Slc+OPYIBUrtf3QEydKOADAb8SSR7bFbyL1tGyUTR0XR8JaQZsylqAYduKcaA1ku0Zi+GTDnYDcuIij/f2jUg+W2QQ6J1BelcHgdT+UKLOAj+3Y0et2HZOP6PNkRHJgQn4tMacVd03g/lCDJBiHAHn6SCJWeyqOqQioEZWvJLt8loWvnMCuxfQV9fbF3/rU22XUOQ4EJkEkEx5dF7ilO7zmtbYdtvMHcUYITVQ6MdISUjBTLq0GsV81nozvVvltzNetPZz9VBItXetr44OoQl5z+XzOKVkLOTj9m08ogMUM7qQhULTc/UEErFnqeeoeonxlw18oyf6h2+NXyQfNETTpRYQ9iBny7JaybpLv2e6okccuji01GmQS7d07zAVlP4GuJRBLgYaE7 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2020 12:53:22.2833 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16e51e8b-f833-40c6-882e-08d7cf292b56 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5157 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Laszlo I agree. But shouldn't we remove the PCD settings from all Arm64 platforms= that have this override value of 0x20? Namely: edk2/ArmVirtPkg/ArmVirtQemu.dsc edk2-platforms/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc edk2-platforms/Platform/ARM/JunoPkg/ArmJuno.dsc edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc edk2-platforms/Platform/Comcast/RDKQemu/RDKQemu.dsc edk2-platforms/Platform/Hisilicon/D06/D06.dsc edk2-platforms/Platform/LeMaker/CelloBoard/CelloBoard.dsc edk2-platforms/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc edk2-platforms/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc edk2-platforms/Silicon/Socionext/SynQuacer/Acpi.dsc.inc -----Original Message----- From: devel@edk2.groups.io On Behalf Of Laszlo Erse= k via Groups.Io Sent: Monday, March 23, 2020 8:31 AM To: devel@edk2.groups.io; samer@elhajmahmoud.com Cc: Dandan Bi ; Liming Gao ; Ha= o A Wu ; Leif Lindholm ; Ard Biesheu= vel Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTable= Versions default for Arm64 platforms On 03/22/20 17:08, Samer El-Haj-Mahmoud wrote: > Set the default value of PcdAcpiExposedTableVersions for Aarch64 > platforms to 0x20. Previously, the default was set to 0x3E for all > platforms. The new value removes ACPI 1.0b compatability, which forces > the use of XSDT 64-bit pointer, as required by Arm SBBR specification. > This also resolves an error reported by acpiview command, as seen on > the RPi (see https://github.com/pftf/RPi4/issues/25). > > Cc: Dandan Bi > Cc: Liming Gao > Cc: Hao A Wu > Cc: Leif Lindholm > Cc: Ard Biesheuvel > > Signed-off-by: Samer El-Haj-Mahmoud > --- > MdeModulePkg/MdeModulePkg.dec | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 91a3c608231c..027f444903ef > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1549,6 +1549,9 @@ [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx= ] > # @Prompt Console Output Row of Text Setup > > gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x4000000e > > +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] > + > +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UINT3 > +2|0x0001004c > + > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > ## UART clock frequency is for the baud rate configuration. > # @Prompt Serial Port Clock Rate. > Please consider appending another patch to this series: once the new DEC d= efault is in place, the same PCD setting is no longer necessary in, and sho= uld arguably be removed from, "ArmVirtPkg/ArmVirtQemu.dsc": # ACPI predates the AARCH64 architecture by 5 versions, so # we only target OSes that support ACPI v5.0 or later gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20 Basically: "git revert e0692789058e". Thanks! Laszlo IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.