From: "Chris Jones" <christopher.jones@arm.com>
To: gaoliming <gaoliming@byosoft.com.cn>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "michael.d.kinney@intel.com" <michael.d.kinney@intel.com>,
"zhiguang.liu@intel.com" <zhiguang.liu@intel.com>,
"ray.ni@intel.com" <ray.ni@intel.com>,
"zhichao.gao@intel.com" <zhichao.gao@intel.com>,
Alexei Fedorov <Alexei.Fedorov@arm.com>,
Sami Mujawar <Sami.Mujawar@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH v1 2/7] MdePkg: Remove PPTT ID type structure
Date: Fri, 29 Oct 2021 09:18:56 +0000 [thread overview]
Message-ID: <VE1PR08MB5758DEDBE4291D9F9DBFAFA9EF879@VE1PR08MB5758.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <00a101d7cc65$0d547140$27fd53c0$@byosoft.com.cn>
[-- Attachment #1: Type: text/plain, Size: 2988 bytes --]
Hi Liming,
Yes ACPI 6.3A deprecated the ID type structure and ACPI 6.4 fully removed it from the specification.
Thanks,
Chris
________________________________
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Friday, October 29, 2021 2:34 AM
To: Christopher Jones <Christopher.Jones@arm.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: michael.d.kinney@intel.com <michael.d.kinney@intel.com>; zhiguang.liu@intel.com <zhiguang.liu@intel.com>; ray.ni@intel.com <ray.ni@intel.com>; zhichao.gao@intel.com <zhichao.gao@intel.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd <nd@arm.com>
Subject: 回复: [PATCH v1 2/7] MdePkg: Remove PPTT ID type structure
Chris:
Does ACPI 6.4 spec have removed them? If yes, I agree this change.
Thanks
Liming
> -----邮件原件-----
> 发件人: Chris Jones <christopher.jones@arm.com>
> 发送时间: 2021年10月18日 23:11
> 收件人: devel@edk2.groups.io
> 抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> zhiguang.liu@intel.com; ray.ni@intel.com; zhichao.gao@intel.com;
> Alexei.Fedorov@arm.com; Sami.Mujawar@arm.com; nd@arm.com
> 主题: [PATCH v1 2/7] MdePkg: Remove PPTT ID type structure
>
> Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
>
> The ACPI 6.3A specification deprecated the PPTT ID type structure (type
> 2) therefore remove it from Acpi64.h.
>
> Mantis ID: 2072 (https://mantis.uefi.org/mantis/view.php?id=2072)
>
> Signed-off-by: Chris Jones <christopher.jones@arm.com>
> ---
> MdePkg/Include/IndustryStandard/Acpi64.h | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> b/MdePkg/Include/IndustryStandard/Acpi64.h
> index
> 625504ba77b4000c0a0b540299d2e0e42c768400..bc1522722424156f0381e8
> 48c2617760f2d31aba 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -2613,7 +2613,6 @@ typedef struct {
> ///
> #define EFI_ACPI_6_4_PPTT_TYPE_PROCESSOR 0x00
> #define EFI_ACPI_6_4_PPTT_TYPE_CACHE 0x01
> -#define EFI_ACPI_6_4_PPTT_TYPE_ID 0x02
>
> ///
> /// PPTT Structure Header
> @@ -2737,21 +2736,6 @@ typedef struct {
> UINT32 CacheId;
> } EFI_ACPI_6_4_PPTT_STRUCTURE_CACHE;
>
> -///
> -/// ID structure
> -///
> -typedef struct {
> - UINT8 Type;
> - UINT8 Length;
> - UINT8 Reserved[2];
> - UINT32 VendorId;
> - UINT64 Level1Id;
> - UINT64 Level2Id;
> - UINT16 MajorRev;
> - UINT16 MinorRev;
> - UINT16 SpinRev;
> -} EFI_ACPI_6_4_PPTT_STRUCTURE_ID;
> -
> ///
> /// Platform Health Assessment Table (PHAT) Format
> ///
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
[-- Attachment #2: Type: text/html, Size: 6644 bytes --]
next prev parent reply other threads:[~2021-10-29 9:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 15:10 [PATCH v1 0/7] Support ACPI 6.4 PPTT changes Chris Jones
2021-10-18 15:10 ` [PATCH v1 1/7] MdePkg: Add missing Cache ID (in)valid define Chris Jones
2021-10-18 15:10 ` [PATCH v1 2/7] MdePkg: Remove PPTT ID type structure Chris Jones
2021-10-29 1:34 ` 回复: " gaoliming
2021-10-29 9:18 ` Chris Jones [this message]
2021-10-18 15:10 ` [PATCH v1 3/7] ShellPkg: Update Acpiview PPTT parser to ACPI 6.4 Chris Jones
2021-10-18 16:33 ` [edk2-devel] " Jeremy Linton
2021-11-03 17:47 ` Chris Jones
2021-10-18 15:10 ` [PATCH v1 4/7] ShellPkg: Add Cache ID to PPTT parser Chris Jones
2021-10-18 15:10 ` [PATCH v1 5/7] DynamicTablesPkg: Remove PPTT ID structure from ACPI 6.4 generator Chris Jones
2021-10-18 15:10 ` [PATCH v1 6/7] DynamicTablesPkg: Update PPTT generator to ACPI 6.4 Chris Jones
2021-10-18 15:10 ` [PATCH v1 7/7] DynamicTablesPkg: Add CacheId to PPTT generator Chris Jones
2021-11-02 1:23 ` 回复: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT changes gaoliming
2021-11-03 16:20 ` Chris Jones
2021-11-04 6:06 ` 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB5758DEDBE4291D9F9DBFAFA9EF879@VE1PR08MB5758.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox