Hi Liming, Yes ACPI 6.3A deprecated the ID type structure and ACPI 6.4 fully removed it from the specification. Thanks, Chris ________________________________ From: gaoliming Sent: Friday, October 29, 2021 2:34 AM To: Christopher Jones ; devel@edk2.groups.io Cc: michael.d.kinney@intel.com ; zhiguang.liu@intel.com ; ray.ni@intel.com ; zhichao.gao@intel.com ; Alexei Fedorov ; Sami Mujawar ; nd Subject: 回复: [PATCH v1 2/7] MdePkg: Remove PPTT ID type structure Chris: Does ACPI 6.4 spec have removed them? If yes, I agree this change. Thanks Liming > -----邮件原件----- > 发件人: Chris Jones > 发送时间: 2021年10月18日 23:11 > 收件人: devel@edk2.groups.io > 抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; > zhiguang.liu@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; > Alexei.Fedorov@arm.com; Sami.Mujawar@arm.com; nd@arm.com > 主题: [PATCH v1 2/7] MdePkg: Remove PPTT ID type structure > > Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) > > The ACPI 6.3A specification deprecated the PPTT ID type structure (type > 2) therefore remove it from Acpi64.h. > > Mantis ID: 2072 (https://mantis.uefi.org/mantis/view.php?id=2072) > > Signed-off-by: Chris Jones > --- > MdePkg/Include/IndustryStandard/Acpi64.h | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h > b/MdePkg/Include/IndustryStandard/Acpi64.h > index > 625504ba77b4000c0a0b540299d2e0e42c768400..bc1522722424156f0381e8 > 48c2617760f2d31aba 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > @@ -2613,7 +2613,6 @@ typedef struct { > /// > #define EFI_ACPI_6_4_PPTT_TYPE_PROCESSOR 0x00 > #define EFI_ACPI_6_4_PPTT_TYPE_CACHE 0x01 > -#define EFI_ACPI_6_4_PPTT_TYPE_ID 0x02 > > /// > /// PPTT Structure Header > @@ -2737,21 +2736,6 @@ typedef struct { > UINT32 CacheId; > } EFI_ACPI_6_4_PPTT_STRUCTURE_CACHE; > > -/// > -/// ID structure > -/// > -typedef struct { > - UINT8 Type; > - UINT8 Length; > - UINT8 Reserved[2]; > - UINT32 VendorId; > - UINT64 Level1Id; > - UINT64 Level2Id; > - UINT16 MajorRev; > - UINT16 MinorRev; > - UINT16 SpinRev; > -} EFI_ACPI_6_4_PPTT_STRUCTURE_ID; > - > /// > /// Platform Health Assessment Table (PHAT) Format > /// > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")