For this patch series: Reviewed-by: Chris Jones Regards, Chris ________________________________ From: devel@edk2.groups.io on behalf of PierreGondois via groups.io Sent: Thursday, September 23, 2021 9:58 AM To: devel@edk2.groups.io ; Bob Feng ; Liming Gao ; Sami Mujawar Subject: [edk2-devel] [PATCH v1 0/4] Set default Makefile name From: Pierre Gondois A Makefile name is not set in BaseTools when only building modules or libraries. This patch-set sets a default Makefile name for the "build" command. The patch-set also: - Removes unsused Makefile variables - Removes hard-coded references to "target.txt" and "tools_def.txt" The changes can be seen at: https://github.com/PierreARM/edk2/tree/1868_BaseTools_build_py_corrections_v1 Pierre Gondois (4): BaseTools/GenMake: Use ToolDefinition as fallback option BaseTools/build: Set MakefileName BaseTools: Remove Makefile/MakefileName fields BaseTools: Remove hard-coded strings for target and tools_def BaseTools/Source/Python/AutoGen/GenMake.py | 8 ++++---- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 1 - BaseTools/Source/Python/GenFds/GenFds.py | 4 ++-- .../Source/Python/GenFds/GenFdsGlobalVariable.py | 4 ++-- BaseTools/Source/Python/TargetTool/TargetTool.py | 3 ++- BaseTools/Source/Python/Workspace/BuildClassObject.py | 2 -- BaseTools/Source/Python/Workspace/DscBuildData.py | 9 ++++----- BaseTools/Source/Python/build/build.py | 11 ++++------- 8 files changed, 18 insertions(+), 24 deletions(-) -- 2.17.1 IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.