From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.6.48; helo=eur01-db5-obe.outbound.protection.outlook.com; envelope-from=meenakshi.aggarwal@nxp.com; receiver=edk2-devel@lists.01.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr60048.outbound.protection.outlook.com [40.107.6.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DA0D52222758A for ; Sun, 7 Jan 2018 22:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9mt6BMKvZtOYlh49L8MGhHdogrPXth/Pqku3PHfaRvk=; b=YrUHmHv5pWqHe6tLUkVe3Zbmsm1SL+GpIArp3Xg/lZljSbBoTZaUsB0M5A4mEwzomCMmJiJmR+87ZZZT87l59SgsL7OtpunfgsFxcgNEbw1YqzwHhTL9O8KTIKB25FBlblAyR/VUzQVV65EIhx682GIFySczbqigCwO0txyfeo0= Received: from VI1PR04MB1005.eurprd04.prod.outlook.com (10.161.108.153) by VI1PR04MB1008.eurprd04.prod.outlook.com (10.161.108.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Mon, 8 Jan 2018 06:07:14 +0000 Received: from VI1PR04MB1005.eurprd04.prod.outlook.com ([fe80::684f:7e7a:eb0a:36d9]) by VI1PR04MB1005.eurprd04.prod.outlook.com ([fe80::684f:7e7a:eb0a:36d9%13]) with mapi id 15.20.0386.006; Mon, 8 Jan 2018 06:07:14 +0000 From: Meenakshi Aggarwal To: "Ni, Ruiyu" , "ard.biesheuvel@linaro.org" , "Gao, Liming" , "Kinney, Michael D" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] PCI : define macro for AHCI base address. Thread-Index: AQHTiEIi5rgbTSnbSk2SBn0pd9zQ6aNpe8YAgAABMbA= Date: Mon, 8 Jan 2018 06:07:13 +0000 Message-ID: References: <1515410446-14750-1-git-send-email-meenakshi.aggarwal@nxp.com> <734D49CCEBEEF84792F5B80ED585239D5BB1E5C9@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BB1E5C9@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=meenakshi.aggarwal@nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR04MB1008; 7:Li8Avp5QRucS6B01up74nqhvz1w5cor8rUhmuVbshlXqpvI4K+MJ4gsW/GapTAlAO2C0wUDMmcg716lnesXAbgIBRlZCTQfleOk/z+6O+BvcLdscyAKzp7x3ZKl98Qxh0ARFoSbXUqWc0g0Fx2cBx36CGdiNSW6iKBXeP6zeGSRlxz9t6B+X/lRWLB+/vVPWHulxoGG/Fdp1sSG/3UynXV7sYlwg6Du7PFIt9w1CPcDbXrv3sD8tPM47BgxGNspR x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9e71206c-e98d-49a3-91aa-08d5565e1024 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR04MB1008; x-ms-traffictypediagnostic: VI1PR04MB1008: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(189930954265078)(185117386973197)(162533806227266)(45079756050767)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231023)(944501075)(6055026)(6041268)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR04MB1008; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR04MB1008; x-forefront-prvs: 054642504A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(366004)(39380400002)(376002)(346002)(13464003)(189003)(43544003)(199004)(68736007)(81156014)(81166006)(25786009)(8676002)(316002)(966005)(110136005)(3280700002)(3660700001)(2900100001)(105586002)(478600001)(97736004)(8936002)(45080400002)(2950100002)(14454004)(55016002)(2906002)(59450400001)(6246003)(9686003)(6436002)(33656002)(53936002)(6306002)(6506007)(7736002)(305945005)(66066001)(5250100002)(575784001)(76176011)(7696005)(3846002)(102836004)(5660300001)(106356001)(6116002)(86362001)(74316002)(229853002)(2501003)(53546011)(99286004)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB1008; H:VI1PR04MB1005.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:3; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: aORdh8KEc5mp7LMTO86pt58dC0nIAIfR3ZnARAPXeArwq4PuK5kASqI84elYTDfE6z0IQbzTHFssQlyS9cu8fQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e71206c-e98d-49a3-91aa-08d5565e1024 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2018 06:07:13.8821 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1008 Subject: Re: [PATCH] PCI : define macro for AHCI base address. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 06:02:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Thanks Ray for your comment. Yes, only AtaAtapiPassThru Driver will need this. Will take care of it. Thanks, Meenakshi > -----Original Message----- > From: Ni, Ruiyu [mailto:ruiyu.ni@intel.com] > Sent: Monday, January 08, 2018 11:32 AM > To: Meenakshi Aggarwal ; > ard.biesheuvel@linaro.org; Gao, Liming ; Kinney, > Michael D ; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH] PCI : define macro for AHCI base address. >=20 > Please do not put this AHCI specific macro in Pci22.h. > I think only AtaAtapiPassThru driver needs to access the AHCI BAR, > There seems no need to expose this definition to public. >=20 > Thanks/Ray >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Meenakshi Aggarwal > > Sent: Monday, January 8, 2018 7:21 PM > > To: ard.biesheuvel@linaro.org; Gao, Liming ; > Kinney, > > Michael D ; edk2-devel@lists.01.org > > Subject: [edk2] [PATCH] PCI : define macro for AHCI base address. > > > > Define PCI BAR 5 macro of AHCI Base address. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Meenakshi Aggarwal > > --- > > MdePkg/Include/IndustryStandard/Pci22.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MdePkg/Include/IndustryStandard/Pci22.h > > b/MdePkg/Include/IndustryStandard/Pci22.h > > index 96a7680..a63bb7c 100644 > > --- a/MdePkg/Include/IndustryStandard/Pci22.h > > +++ b/MdePkg/Include/IndustryStandard/Pci22.h > > @@ -533,6 +533,7 @@ typedef struct { > > #define PCI_HEADER_TYPE_OFFSET 0x0E > > #define PCI_BIST_OFFSET 0x0F > > #define PCI_BASE_ADDRESSREG_OFFSET 0x10 > > +#define PCI_AHCI_BASE_ADDRESS 0x24 > > #define PCI_CARDBUS_CIS_OFFSET 0x28 > > #define PCI_SVID_OFFSET 0x2C ///< SubSyste= m Vendor id > > #define PCI_SUBSYSTEM_VENDOR_ID_OFFSET 0x2C > > -- > > 1.9.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flist > s.01.org%2Fmailman%2Flistinfo%2Fedk2- > devel&data=3D02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C33c2199113d > 5420bad2808d5565d4ba6%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 > %7C636509881114358526&sdata=3D5GgVYhmdN%2BlORXpC7yM6Xmq5LMOAV > K2rPsGWgDdmUPA%3D&reserved=3D0