From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.0.74; helo=eur02-am5-obe.outbound.protection.outlook.com; envelope-from=meenakshi.aggarwal@nxp.com; receiver=edk2-devel@lists.01.org Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00074.outbound.protection.outlook.com [40.107.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DC62C21CB87BF for ; Sun, 7 Jan 2018 22:21:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Ege0WCCni7tRVehTYIFisOlbEbNe0QrO6N1pQFiCD3k=; b=sWQ2B0xmcH0SLTSUaJjGyEkvXhhBFchBlcFizPoLSCaMLpFMM2ZW/RaRM5gAPizC7JHIfKhcj/r9btsK/qHhGikC5jy38Q5JS1K+5MijTAfD4hhC8xEFtfkMMFPYEVOdtl8xl6+0NjRohs2yV8wQo2jDoTdP8zz87iu+CLflE3c= Received: from VI1PR04MB1005.eurprd04.prod.outlook.com (10.161.108.153) by VI1PR04MB1007.eurprd04.prod.outlook.com (10.161.108.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Mon, 8 Jan 2018 06:26:15 +0000 Received: from VI1PR04MB1005.eurprd04.prod.outlook.com ([fe80::684f:7e7a:eb0a:36d9]) by VI1PR04MB1005.eurprd04.prod.outlook.com ([fe80::684f:7e7a:eb0a:36d9%13]) with mapi id 15.20.0386.006; Mon, 8 Jan 2018 06:26:15 +0000 From: Meenakshi Aggarwal To: "Zeng, Star" , "ard.biesheuvel@linaro.org" , "leif.lindholm@linaro.org" , "edk2-devel@lists.01.org" , "Dong, Eric" CC: "Ni, Ruiyu" Thread-Topic: [edk2] [RFC] SATA : Implemented NXP errata A008402 Thread-Index: AQHTiEGW1LNus4t+bU21whIVuvRhB6NpeDeAgAAAQPCAAAg28A== Date: Mon, 8 Jan 2018 06:26:15 +0000 Message-ID: References: <1515410208-14559-1-git-send-email-meenakshi.aggarwal@nxp.com> <1515410208-14559-2-git-send-email-meenakshi.aggarwal@nxp.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B9F8EE6@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=meenakshi.aggarwal@nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR04MB1007; 7:BRmpq/GWDJ7zf+INO3GwVbBz4pSD/swozHfOg30vzQrFj1nC8jWhVqBRG0Y3/tLl2KRQwpS1EqdSrjZ67+G1OuMxLC5/HTp+W/DeeAPqQa5h6X9LGOtLCw21YvlGBuIeNfJ9hWjN6OoYq7ujhpkLk+7fAyvIAz/G9MU5txBCyLMoYxJO1hEf07PqviphYxuJDwUuVU7I17x//f9g5KV2XMdxEbxPLAPUsArdfBugxeYNJs+zddOFs1qrEU/WurZP x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 59d2f20c-4c7f-4b6e-926d-08d55660b874 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR04MB1007; x-ms-traffictypediagnostic: VI1PR04MB1007: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(189930954265078)(185117386973197)(788757137089)(162533806227266)(45079756050767)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231023)(944501075)(10201501046)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:VI1PR04MB1007; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR04MB1007; x-forefront-prvs: 054642504A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(346002)(376002)(39380400002)(366004)(189003)(199004)(50944005)(13464003)(4326008)(8676002)(229853002)(6116002)(68736007)(3846002)(102836004)(81166006)(81156014)(93886005)(33656002)(99286004)(6436002)(55016002)(9686003)(6306002)(25786009)(2940100002)(966005)(2501003)(14454004)(2906002)(6246003)(45080400002)(478600001)(7736002)(105586002)(106356001)(3660700001)(2950100002)(2900100001)(97736004)(305945005)(575784001)(86362001)(110136005)(8936002)(3280700002)(53936002)(5660300001)(66066001)(6506007)(59450400001)(7696005)(53546011)(2201001)(316002)(76176011)(74316002)(5250100002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB1007; H:VI1PR04MB1005.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 8UZdtjgy5T1DpYO1Zwjjtim3f1A+9qDMyoLGCsHvBPbOz/CdEUCDe96H78BsUDqucchmmI3UFupUtqdxq5vpsA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59d2f20c-4c7f-4b6e-926d-08d55660b874 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2018 06:26:15.2571 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1007 Subject: Re: [RFC] SATA : Implemented NXP errata A008402 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 06:21:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Hi Star, Apologies and some correction in my last reply. As per the errata, PRDT Maximum value needs to be set to 0 only when creat= ing a PRD entry for a maximum data transfer size. So there is no need to replace all occurrences of EFI_AHCI_MAX_DATA_PER_PRD= T in file. Just need to change it where we are setting the Data length. I define it to 0x3FFFFF, as this is the actual value we are setting and thi= s PCD need to be used only once. I know, its NXP specific patch only, and i try to made changes which will n= ot impact any other package. Thanks, Meenakshi > -----Original Message----- > From: Meenakshi Aggarwal > Sent: Monday, January 08, 2018 11:25 AM > To: 'Zeng, Star' ; ard.biesheuvel@linaro.org; > leif.lindholm@linaro.org; edk2-devel@lists.01.org; Dong, Eric > > Cc: Ni, Ruiyu > Subject: RE: [edk2] [RFC] SATA : Implemented NXP errata A008402 >=20 > Hi, >=20 > I didn't prepare the full patch but will send in next few minutes, >=20 > i made the very basic changes required to test Errata implementation. >=20 > I will redefine it to 0x400000. > PcdPrdtMaxDataLength was defined to 0x3FFFFF just for testing purpose. >=20 > Thanks, > Meenakshi >=20 > > -----Original Message----- > > From: Zeng, Star [mailto:star.zeng@intel.com] > > Sent: Monday, January 08, 2018 11:19 AM > > To: Meenakshi Aggarwal ; > > ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; edk2- > > devel@lists.01.org; Dong, Eric > > Cc: Ni, Ruiyu ; Zeng, Star > > Subject: RE: [edk2] [RFC] SATA : Implemented NXP errata A008402 > > > > Do you have a full patch already? > > Why the PcdPrdtMaxDataLength is defined to 0x3FFFFF, but not 0x400000? > > > > > > Thanks, > > Star > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Meenakshi Aggarwal > > Sent: Monday, January 8, 2018 7:17 PM > > To: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; edk2- > > devel@lists.01.org; Zeng, Star ; Dong, Eric > > > > Subject: [edk2] [RFC] SATA : Implemented NXP errata A008402 > > > > Description: > > Commands with 4 MB PRD length entries fail if PRD[DBC] is > > set to the value according to AHCI standard spec. > > Due to a logic error, 3F_FFFFh is misinterpreted by the > > device as zero length. > > > > Workaround: > > Set PRD length to 0 when creating a PRD entry for > > a maximum data transfer size of 4 MB to fix the erratum. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Meenakshi Aggarwal > > --- > > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 2 +- > > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf | 1 + > > MdeModulePkg/MdeModulePkg.dec | 3 +++ > > 3 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > > b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > > index e6de5d6..fb6dc0b 100644 > > --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > > +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > > @@ -591,7 +591,7 @@ AhciBuildCommand ( > > if (RemainedData < EFI_AHCI_MAX_DATA_PER_PRDT) { > > AhciRegisters->AhciCommandTable- > >PrdtTable[PrdtIndex].AhciPrdtDbc > > =3D (UINT32)RemainedData - 1; > > } else { > > - AhciRegisters->AhciCommandTable- > >PrdtTable[PrdtIndex].AhciPrdtDbc > > =3D EFI_AHCI_MAX_DATA_PER_PRDT - 1; > > + AhciRegisters->AhciCommandTable- > >PrdtTable[PrdtIndex].AhciPrdtDbc > > =3D PcdGet32 (PcdPrdtMaxDataLength); > > } > > > > Data64.Uint64 =3D (UINT64)MemAddr; > > diff --git > a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > > b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > > index 82d5f7a..8921dd5 100644 > > --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > > +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > > @@ -70,6 +70,7 @@ > > > > [Pcd] > > gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEnable ## > > SOMETIMES_CONSUMES > > + gEfiMdeModulePkgTokenSpaceGuid.PcdPrdtMaxDataLength > > > > # [Event] > > # EVENT_TYPE_PERIODIC_TIMER ## SOMETIMES_CONSUMES > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > b/MdeModulePkg/MdeModulePkg.dec > > index 8efad57..b2f9f2b 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -1434,6 +1434,9 @@ > > # @Prompt Console Output Row of Text Setup > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40 > > 00000e > > > > + ## This PCD specifies the Maximum data length for a PRD Entry > > + > > > gEfiMdeModulePkgTokenSpaceGuid.PcdPrdtMaxDataLength|0x3FFFFF|UIN > > T32|0x4000000f > > + > > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, > PcdsDynamicEx] > > ## UART clock frequency is for the baud rate configuration. > > # @Prompt Serial Port Clock Rate. > > -- > > 1.9.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flist > > s.01.org%2Fmailman%2Flistinfo%2Fedk2- > > > devel&data=3D02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C9b1e2bde5b > > > 4b47746d0e08d5565b8394%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C > > > 0%7C636509873433437533&sdata=3Dwg3Sg5SiU2MrbZSkZMlboldcXnMBKKg3jG > > yA45YZo1Q%3D&reserved=3D0