From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.89]) by mx.groups.io with SMTP id smtpd.web11.4746.1586418291406845051 for ; Thu, 09 Apr 2020 00:44:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp.com header.s=selector2 header.b=lqyeMqmp; spf=pass (domain: nxp.com, ip: 40.107.14.89, mailfrom: v.sethi@nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PM9bwBn+NlqPHps8wcPFbmEWsgDd6ZcJDuLvkZEaiTp4WBLNYrIvGrcsehsTFM4JMze//gx7CskA8h4fZM4zk7gW1TNk0s0qRNXF51bsWrn2qn6CW8jt3alrjMZwalFdHzvZzQQU7K9QyTCc5PQNagwkqHf9CYYF2foOQP/G1j1kT9gr+n6HrhphzgAO7dkn2W8RUF0uf23hMmcRiPuvLpol8BPBHRiHWoZTkPMmemf6Uh66WjlP/PLU1cB3l5vErtVbp9oqKmsCoyKm0gzyauFkZ8DC6c+TWF+M6cNUfni9D1lSa72HRmLQxH15xuB7XuL69xnUYps9JCqSyUas7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XTZ/VDKIEuEGJraTgNGR0agQiKLZXzTmTt0Hu7j0/7A=; b=SeRTRrgFFy3SlZFMv5pm1vmYOXu4ovl9UF1b9uFTkU0e7B4wUUSCQ9i1LEJ1jzXzyIOm4eTOt/Y0ovKXqBqp7FAenkbOpuYcp5FFXoAHVvJXKaLfGYR5oJeNQB/QqPWicMPXErgzGtpDojf2cpZcIJz/8Plv05Mx1X9Tgx90hT+g09iKsJK7Gou0acC36MyAQOBCPLB/Nd12FBt+DpQbg1M1Ol/xkNeN1Zzqfr9SBDxCivYRlYICZBsO4/aYyQ9hHAeII8Fn6m7AjDNsuBIDuedqFclNzZ1nyJSBcAzKeH0xCcBgH2pGC4OP4Sqwob+H+Zm0kqr/FFxwKhvSLohPXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XTZ/VDKIEuEGJraTgNGR0agQiKLZXzTmTt0Hu7j0/7A=; b=lqyeMqmpVP0/T7Ue9w/JEyGIjdsBMGfqfLxl52+CJaRJC63+txcg1tminSCG/piEPUTFJDzoIrbMm0JD9NIENiy1y4wcQ3wWnNN5QjPYMDa6jL55IiqRO03SmHM2ZH3Ss+lttngFh0VuxXmfoX+bWncgF6QC5u5pGOS0SkuErTU= Received: from VI1PR04MB4592.eurprd04.prod.outlook.com (2603:10a6:803:75::31) by VI1PR04MB6016.eurprd04.prod.outlook.com (2603:10a6:803:d3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Thu, 9 Apr 2020 07:44:49 +0000 Received: from VI1PR04MB4592.eurprd04.prod.outlook.com ([fe80::4ce4:6749:2a21:f14c]) by VI1PR04MB4592.eurprd04.prod.outlook.com ([fe80::4ce4:6749:2a21:f14c%7]) with mapi id 15.20.2878.022; Thu, 9 Apr 2020 07:44:49 +0000 From: Varun Sethi To: Leif Lindholm , "Pankaj Bansal (OSS)" CC: Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [EXT] Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib Thread-Topic: [EXT] Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib Thread-Index: AQHWC91PQ5i0zowd70Wqypuc7bAHL6hr9EGAgAR4KdA= Date: Thu, 9 Apr 2020 07:44:48 +0000 Message-ID: References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-8-pankaj.bansal@oss.nxp.com> <20200401095329.GO7468@vanye> <20200406112453.GC14075@vanye> In-Reply-To: <20200406112453.GC14075@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=V.Sethi@nxp.com; x-originating-ip: [122.160.41.82] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ae8a3302-9917-44b3-1428-08d7dc59e19b x-ms-traffictypediagnostic: VI1PR04MB6016:|VI1PR04MB6016: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0368E78B5B x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB4592.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(39860400002)(346002)(396003)(366004)(136003)(376002)(66446008)(5660300002)(64756008)(76116006)(8936002)(316002)(52536014)(66946007)(53546011)(81156014)(71200400001)(66556008)(66476007)(6506007)(7696005)(54906003)(19627235002)(110136005)(4326008)(478600001)(2906002)(33656002)(45080400002)(966005)(81166007)(186003)(8676002)(86362001)(26005)(55016002)(83080400001)(9686003);DIR:OUT;SFP:1101; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d8D5bfLkfiZeJP0c777dyOSsvY0GGvUd2DZYUoxF+J7AgndV6OWoPTg1tgDplKlZg1EVXhADnpEVWFJEom27JuFv+Qr9uLRyl9EEAT1VQ+V9YFanDBdheYiBrmPe0EnyR60U2kKECJwrHJOKOypafKFUy3Cfn2/ZLRD5XM3o0md9qL+BZdTS0ZNTjYyEx7XV5LPERt/tsuwnFtJrZpBTnyuE2ezDfhzDb08+FfyhhBZm0m/3Vm/AKn31coNITEhpJ3qj8MUcmE+YWQ+OInG4od/6M2ckXVMMROOihFm2XuODDFvGeW79FM4J7+n0is0cSMt6NPa2Bk0RvtH3/IT++ZSRHwFcUTi2kAJB6hYlHe/l6rOQPxpYxAPXIY78oExCZ0UWiNvZjSNBesfq6B+MsHVCFWEeXgLXwqwUz4e6SVyUAK0JTjSUQv/pQXtmxt3Ot3Plet7PYXzSzSWbHlzf9SdNvv9plRQIHcIyJn59A7QNHdLWLNk/FXxI6ozDIAoq x-ms-exchange-antispam-messagedata: Bwd+ZUxPvUA9vnOHx7E9ltIrxKglFpqS9sKeBFubZKd8ITYXPJ25FBIYHj9AH18qVO7ISs7ihgNV18XclS/BVHLMngLOyG/oteUswGTs5LhlEDVAtIryEvRJTWnBlKDZWhBaNmfH5WpURpfBZCmfhQ== MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae8a3302-9917-44b3-1428-08d7dc59e19b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2020 07:44:48.9642 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y36AR5FL46jsbK8V5IJDf8sjGbdXkgj41dPk/Htldn9p6OSnlkN6tFBmWjMKMAj+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6016 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, Please find my comments inline. Regards Varun -----Original Message----- From: Leif Lindholm =20 Sent: Monday, April 6, 2020 4:55 PM To: Pankaj Bansal (OSS) Cc: Meenakshi Aggarwal ; Michael D Kinney ; devel@edk2.groups.io; Varun Sethi ; Samer El-Haj-Mahmoud ; Jon Nettleton Subject: [EXT] Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockL= ib Caution: EXT Email On Mon, Apr 06, 2020 at 06:33:40 +0000, Pankaj Bansal (OSS) wrote: > > > > -----Original Message----- > > From: Leif Lindholm > > Sent: Wednesday, April 1, 2020 3:23 PM > > To: Pankaj Bansal (OSS) > > Cc: Meenakshi Aggarwal ; Michael D=20 > > Kinney ; devel@edk2.groups.io; Varun=20 > > Sethi ; Samer El-Haj-Mahmoud > Mahmoud@arm.com>; Jon Nettleton > > Subject: Re: [PATCH v2 07/28] Silicon/NXP: Implement=20 > > SerialUartClockLib > > > > On Fri, Mar 20, 2020 at 20:05:22 +0530, Pankaj Bansal wrote: > > > From: Pankaj Bansal > > > > > > Implement SerialUartClockLib for all NXP Layerscape Platforms. > > > > > > Signed-off-by: Pankaj Bansal > > > --- > > > .../SerialUartClockLib/SerialUartClockLib.c | 27 +++++++++++++++++= ++ > > > .../SerialUartClockLib/SerialUartClockLib.inf | 26=20 > > > ++++++++++++++++++ > > > > I requested after the initial submission that you "either follow the=20 > > manual git setup steps from > > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgi > > thub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FLaszlo%2527s-unk > > empt-&data=3D02%7C01%7CV.Sethi%40nxp.com%7C147ef25a5d6e4a0c899408d > > 7da1d2288%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6372176909755 > > 41422&sdata=3D6A%2Bg1jAmhpu9p%2FISIddejL0dhzQs%2FS%2BqbYCXtgPAUfk% > > 3D&reserved=3D0 git-guide-for-edk2-contributors-and-maintainers > > or execute edk2/BaseTools/Scripts/SetupGit.py in each of the=20 > > tianocore repositories" > > > > Now, neither appears to have happened, as .c still comes before .inf=20 > > and paths are still truncated. > > I had executed the SetupGit.py script, I will check again. > > > > > But in addition to that, we realised that git happily ignores=20 > > settings for --stat. So, please, execute aforementioned script, but=20 > > then generate v3 with --stat=3D1000 --stat-graph-width=3D20. > > > > Ok. I will follow these steps as well. > > > For this particular patch, the side discussion on the edk2 portion=20 > > may make it redundant, so I'm deferring review. > > Right now, I am yet to work on the review comments of other edk2 patch=20 > and since it touches other platforms as well, it requires thorough=20 > vetting from other platform maintainers. It seems like that would take=20 > more time. If I send this patch series without removing DuartLib (i.e.=20 > drop patches 7, 8, 9 from this series), can you please merge.=20 > Parallelly, I will work on edk2 patch and once that is accepted, I will s= end patches 7, 8, 9 after that in new series ? >See comment in my previous email on merging code only to remove it shortly= afterwards. We will certainly take of this going forward. >As you have seen on that thread, a couple of proposals have been made for = how to fix this without affecting other platforms (the HOB variant[1] and t= he separate .inf[2] variant). I will keep chasing on that >occasionally, bu= t please also contribute to that conversation yourself. Pankaj would be responding to this thread and make changes accordingly. Ple= ase allow us to pursue this patchset as a separate thread. We need the base= patches to be merged asap so that we can submit patches for LX2160A and LS= 1046A. We have urgent releases planned for these platforms.