From: Udit Kumar <udit.kumar@nxp.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Thomas Panakamattam Abraham <thomas.abraham@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"edk2-devel (edk2-devel@lists.01.org)" <edk2-devel@lists.01.org>,
Ming Huang <ming.huang@linaro.org>,
Heyi Guo <heyi.guo@linaro.org>,
Matteo Carlini <Matteo.Carlini@arm.com>,
Nariman Poushin <nariman.poushin@linaro.org>
Subject: Re: SP805 driver
Date: Tue, 18 Dec 2018 12:57:22 +0000 [thread overview]
Message-ID: <VI1PR04MB46404B6E414C23EB2B286C4B91BD0@VI1PR04MB4640.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20181218124958.iziphtwopl5nyrlx@bivouac.eciton.net>
> > > > Coming back to hardware, which does not have mask around wdt, how
> > > > to implement this feature.
> > >
> > > Simple - you can't.
> > >
> > > You can absolutely implement exactly the functionality you have
> > > today, with minimal changes to the protocol - it just should not be
> > > registered as an implementation of
> EFI_WATCHDOG_TIMER_ARCH_PROTOCOL.
> >
> > I believe, EFI_WATCHDOG_TIMER_ARCH_PROTOCOL is must Are you
> > suggesting to EFI_WATCHDOG_TIMER_ARCH_PROTOCOL from
> MdeModulePkg and
> > hook platform specific code with this.
> > Or simply register EFI_WATCHDOG_TIMER_ARCH_PROTOCOL with dummy
> functions.
>
> Are you referring to
> MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf?
Yes !!
> That is certainly what most of the platforms in edk2-platforms use.
>
> The EFI_WATCHDOG_TIMER_ARCH_PROTOCOL is used by core code.
>
> If you want to use your hardware watchdog as part of your platform specific
> code, that is absolutely fine and probably a very good idea - but it has nothing to
> do with this protocol. There is nothing forcing you to use the platform-
> independent EFI_WATCHDOG_TIMER_ARCH_PROTOCOL for this.
Yes, this was idea to use MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
and if needed, install a custom protocol for hardware wdt. And this to be used by platform specific code.
> Regards,
>
> Leif
next prev parent reply other threads:[~2018-12-18 12:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 12:55 SP805 driver Leif Lindholm
2018-12-18 5:20 ` Udit Kumar
2018-12-18 9:26 ` Leif Lindholm
2018-12-18 12:30 ` Udit Kumar
2018-12-18 12:49 ` Leif Lindholm
2018-12-18 12:57 ` Udit Kumar [this message]
2018-12-18 13:16 ` Leif Lindholm
2018-12-18 7:13 ` Thomas Abraham
2018-12-20 15:00 ` Ming Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB46404B6E414C23EB2B286C4B91BD0@VI1PR04MB4640.eurprd04.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox