From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.5.57; helo=eur03-ve1-obe.outbound.protection.outlook.com; envelope-from=udit.kumar@nxp.com; receiver=edk2-devel@lists.01.org Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50057.outbound.protection.outlook.com [40.107.5.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B34B021B02822 for ; Tue, 20 Nov 2018 03:10:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BgueZMg8jRkqPctZl2xQVLQBmo5QrRpBNwn/wSQKqEI=; b=jZc+mMGfqDnVJnKh/vnhrxCEAZVp+PabncPS5Ig3sdw6H12PKbQepuuWjjHQvV+ONFW8XGhC4nSBtFhJwDK/KrpQ9zDmmAg42+FBEx1z0eK0jMGwf6C1Zn8T0hLkmcH2ED4S+IQi8YGGf2VjbZkS04EioPZ63EkVnf89ZSN1/lc= Received: from VI1PR04MB4640.eurprd04.prod.outlook.com (20.177.56.27) by VI1PR04MB5312.eurprd04.prod.outlook.com (20.177.52.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.37; Tue, 20 Nov 2018 11:10:24 +0000 Received: from VI1PR04MB4640.eurprd04.prod.outlook.com ([fe80::a85c:5094:7bc5:8e83]) by VI1PR04MB4640.eurprd04.prod.outlook.com ([fe80::a85c:5094:7bc5:8e83%3]) with mapi id 15.20.1294.045; Tue, 20 Nov 2018 11:10:24 +0000 From: Udit Kumar To: Vijayenthiran Subramaniam , "edk2-devel@lists.01.org" , "siyuan.fu@intel.com" , "jiaxin.wu@intel.com" Thread-Topic: [edk2] [PATCH] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts Thread-Index: AQHUgMDeaemgyctT7ESmWoOkuFFafqVYgSdQ Date: Tue, 20 Nov 2018 11:10:24 +0000 Message-ID: References: <20181120103954.18938-1-vijayenthiran.subramaniam@arm.com> In-Reply-To: <20181120103954.18938-1-vijayenthiran.subramaniam@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=udit.kumar@nxp.com; x-originating-ip: [14.143.30.134] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR04MB5312; 6:UP/ebk5uqbKV2LWShl9ajoTXOszGjqeharo7oPYfoml1pfVTss2wg1XQ6SFq/kP4B3arFl3DIvNYkE+doWsJa92SJBWCPi+Fo5ItpWP8dZN+QwwGAr9lGY+U3lCcZUBLM8L9MtvUs0Sf99WiWcL6Oo8UvqM/xGRks7juarQck3Nv4vY+2JjYv0MtsGV+acepiuuVMGJ9VRv4xgOQW/8gzuo7ibxdLFqGiIdMKM4nTZUSaI9JI+K660j3dczo+JiZu1qiNpEXXIc5wcocESp0u1pTaz2JRR+QteSzgCkWXeUi9Yj4TniGElbZTtyjovxUMUFiJq4rGFnXb5gavO9zCY5nW4/f4cPpxBXKMhZyyaoAOC5mPrLF5Lr9QFRxXdmYmX1Nr8t5VaFtEoc3igy7WpIBLwR9m/Hwj5JEgoF8IpfEDFNiQf3t1hcYeyED7/GPmub1OsNdzTVxeaSAm1yJaw==; 5:xFOKWJcVhfO+VAJ/lkdjTeloQd0Frdc5hj46+/by37vNoVbs7Cfb+HwhN/smMcB45FF9ODSfQarS+d400NG81pRNsxSIFZgayb/YXvc82y8UeaVq4W2lKgOxBB8qtMlt6bfsNUYre2DCtUbfmRBm7y6YmMqGsJo5GRCs9DXOmcU=; 7:Xy9Kk3yUqJb/zsqByiQsSHGxd5jxGy7dOSzBWwpJyDtBuxttL5ko7m3deMmSjpMbEQqp6uOtwJE9Lb5qCEhMPN8eyDYkPMw3LVkpZ04j4JPfsfwTXq9GQ68CSzI0H+ZqkpulnrSosjzNkXDW7CZrsg== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: c1425581-9c86-499e-7b29-08d64ed8c4fc x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB5312; x-ms-traffictypediagnostic: VI1PR04MB5312: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(162533806227266)(228905959029699)(45079756050767)(189930954265078)(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231442)(944501410)(52105112)(10201501046)(3002001)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:VI1PR04MB5312; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB5312; x-forefront-prvs: 08626BE3A5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(376002)(366004)(396003)(136003)(199004)(189003)(13464003)(229853002)(966005)(74316002)(446003)(8676002)(256004)(3846002)(8936002)(44832011)(14454004)(6116002)(81156014)(81166006)(7696005)(14444005)(53546011)(11346002)(2501003)(106356001)(105586002)(55236004)(99286004)(102836004)(7736002)(33656002)(2906002)(305945005)(25786009)(476003)(2900100001)(5660300001)(478600001)(316002)(78486014)(68736007)(66066001)(186003)(6506007)(53936002)(6436002)(2201001)(110136005)(71190400001)(97736004)(55016002)(45080400002)(575784001)(71200400001)(86362001)(76176011)(9686003)(6306002)(6246003)(486006)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5312; H:VI1PR04MB4640.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: dZ+F8LMkXBfoOO+JO9ACNLVXfs3RDKaIx+9OBrYKcwKG8tP1IjCzWUcIM21XnLUcXsQnQpG+9iCdMCXR2hojmnYsCTdSO8TnO/K3zKkQF3VvlLQ8cNkNLQcp3BotMLyZ12Uj/bp3rFkuPQz7nPfJ9NP6TtNFt4q+KTM9StsGQRaw+4AFSPGxmA45RXS9fo8MD+eZm4ERGJDjj2+J2Z5xkRoIFceQz67YA9/bE9PCD9wLYhCqp7ZUyAz5ZxOmmQ9jUC8upqz5l3gB8jOOgTFkyBFTdUzaiKlFiFjrLBVrkdeO5HdijzcHZoyRj6TNFIQtrtA1N3eRjNp26nkovz/EsbnIurXvTAm7NxvIMnl5BJ8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1425581-9c86-499e-7b29-08d64ed8c4fc X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2018 11:10:24.2756 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5312 Subject: Re: [PATCH] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 11:10:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: edk2-devel On Behalf Of > Vijayenthiran Subramaniam > Sent: Tuesday, November 20, 2018 4:10 PM > To: edk2-devel@lists.01.org; siyuan.fu@intel.com; jiaxin.wu@intel.com > Cc: Vijayenthiran Subramaniam > Subject: [edk2] [PATCH] NetworkPkg/IScsiDxe: add debug logs for failed > SetVariable attempts >=20 > Add debug messages for failed attempts to write to a variable. >=20 > Cc: Siyuan Fu > Cc: Jiaxin Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vijayenthiran Subramaniam > > --- > NetworkPkg/IScsiDxe/IScsiMisc.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiM= isc.c > index dd0d32dcda16..46760d79a8f3 100644 > --- a/NetworkPkg/IScsiDxe/IScsiMisc.c > +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c > @@ -845,6 +845,8 @@ IScsiCreateAttempts ( > ); > FreePool (AttemptConfigOrder); > if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: SetVariable failed with return: %r\n", > + __FUNCTION__, Status)); > return Status; > } >=20 > @@ -887,6 +889,8 @@ IScsiCreateAttempts ( > ); > FreePool (AttemptConfigData); > if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a: SetVariable failed with return: %r\n", > + __FUNCTION__, Status)); > return Status; > } > } Since you are printing, same text for both failure , how will you decide wh= ich SetVariable is failed=20 You can choose to have different text or __LINE__ should help=20 > -- > 2.17.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flist= s.01 > .org%2Fmailman%2Flistinfo%2Fedk2- > devel&data=3D02%7C01%7Cudit.kumar%40nxp.com%7C5faa1c1f546046d1f1 > a708d64ed7ff20%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C6367 > 83086961408415&sdata=3DRZdmCRaq8x0ps9gu13YAoWf8lsGS9zH2fAdnDLbP > 3rE%3D&reserved=3D0