From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.59]) by mx.groups.io with SMTP id smtpd.web10.8670.1586746819846621870 for ; Sun, 12 Apr 2020 20:00:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=Mpvu7U3y; spf=pass (domain: oss.nxp.com, ip: 40.107.22.59, mailfrom: pankaj.bansal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D+bXv3Ff96loF361wxMeGeW34Oh+tdy3a4z6eRQSnj6UV6rGtusEsAHXTpWkar5VzkjjCn8f19IxCvuogHdBMIxuJfL+yQbuwOCpZ2ZxdG1Inyhlf+W6t0xql43oMH2XOyLuRfBYC5NYj8wT61IPTq/p/N9FIgIHGd+yGAMQghpz7rMv7GTMjaWNGR+lqoTnec7VvnlJjiOnkCJCFtilyCU5m4pi5KXa4fm3udZ+G8SNj6bDGNJd8KPUfeVLzsMtPgxw9Bj3GZFdJr0RBUy2lrg3x+kJnUAjU2zprWyO9evo3Yi3IxdTBPCcfaLLNswGZLxuKZYEVd1D+CsmIyB2IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R+zIx6oQEOsV/STzEfLugBHaJn7x8TaXibWds23fp9k=; b=TDJFlr1/hYA5I1P+2Zu5oYJw935AHkJTRhpojqr80RBxkZrxxeRP5Kc98h0m8QEztGVTt1s3OK0ezX/MAa4evp4GaYyAtxT5F+GUZu2DE+rEbV71eMdGIkLCPIE6wFMUH6hE9i/mDEvs7XzK3ogn86YhBXTgvv0S0X6IMx4XTV+adgAGhv39m+UtGe7UBQtWSDVYyv8Rx/8f4pLx7K+a3Z5SHZ95OnBFGWCYsUqsGXUHaYvPQE8L8m9CwkhOeDBm/bPse1mEAqUX+THQtsRZd/OUjxelOflqFxlWjzx51tnebKH8NgpKJBRUH6sWPfqfO8s6Ga/CLIRExwVEHS8JhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R+zIx6oQEOsV/STzEfLugBHaJn7x8TaXibWds23fp9k=; b=Mpvu7U3y+cfmp95LdgmZsoiXI5Ft55RGPPkPOUyrdd7MEBZj99ZkUjh2Incwb4BB9I8N4k2+wOFQT/Ddc26BY6109hNz04FrVfP6jqAbkjABrb1I821Dj9fP8uSy37uZm7c7evZUCTLHjqbiYCOuCUAGiAOeBPWAs/hEGuPvvFU= Received: from VI1PR04MB5933.eurprd04.prod.outlook.com (20.178.205.16) by VI1PR04MB4095.eurprd04.prod.outlook.com (52.133.12.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.17; Mon, 13 Apr 2020 03:00:17 +0000 Received: from VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513]) by VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513%7]) with mapi id 15.20.2900.028; Mon, 13 Apr 2020 03:00:17 +0000 From: "Pankaj Bansal" To: Leif Lindholm , "Pankaj Bansal (OSS)" CC: Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib Thread-Topic: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib Thread-Index: AQHWET+oVVoAFtdrKUqqzIrg5Eq9Zw== Date: Mon, 13 Apr 2020 03:00:16 +0000 Message-ID: References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-8-pankaj.bansal@oss.nxp.com> <20200401095329.GO7468@vanye> In-Reply-To: <20200401095329.GO7468@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=pankaj.bansal@oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [49.36.131.169] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 329113ca-f860-472e-4aaa-08d7df56cb81 x-ms-traffictypediagnostic: VI1PR04MB4095:|VI1PR04MB4095: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 037291602B x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5933.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(33656002)(54906003)(6506007)(110136005)(5660300002)(316002)(9686003)(55016002)(71200400001)(52536014)(66476007)(76116006)(66946007)(8676002)(66556008)(8936002)(19627235002)(26005)(4326008)(7696005)(2906002)(66446008)(64756008)(186003)(966005)(478600001)(86362001)(81156014);DIR:OUT;SFP:1101; received-spf: None (protection.outlook.com: oss.nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ebDinTiviOoRFq1TmGH/53WHEncKp2/nXYh1bhbv/CX2L+A6u/vpdSCbTM2/n6L9Odbxi7dPMEmnzSdzFhgh+XtWgaw6zzNz/rKUwAIWUpbMyZqWzI90zcNEXvFV4VlXdYYRg5C73vKVutPOddAa5q+y+JwLw8ptTJsRVGY12wM3E5dw2xWrdPwXHDoFRJb4UqavkLoKrmOic/ZJiCXOHU7bzoGKmeAtNyPrqom2XUMrz9YKxi0kV7DDpHCoChOm145voZAWXnbnp9VB6cfw2aVy90QCrxug9LUxzhJVCB2OEdV83Diiv7UGpb9IRfZKttZb1R8uBPtzcfYbc4XBvqbGthAV71SmtD4Bp4FTI404U7F2dE2s84Osan6Mh06mV1cVTdKp6+PGTl40WQDQldapziO5bYZqPoBi1o6nVDTVllF2H5nn3e1skcfUASujRdMRAoxRsK8hIkhQFSO3A6ky61CZ9imVNVwv4Z67Ya2ert1pCrdNrA0dXW+ZsliMynWdTNnVKaRr2g1Rr9yEIg== x-ms-exchange-antispam-messagedata: Ap8sq+Wuw8HAdxIQuhPDYcASq2LDjb/Yq4LA3ushITsmEUtIv5YI4MxoPKii0SqOpXvfMWmLEsMHBTcGFHieBcq0gf6qFf1KgsldBzzAuGtHr6GoP25A5dbV9HmEGxGZMnbk4luF/H5NaeSPHONmfA== MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 329113ca-f860-472e-4aaa-08d7df56cb81 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2020 03:00:16.8115 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9pmCCvVTevifEy7nkiWUvmGtcEcmkmOIgIRVIA9kzG5BHjkHLWo2KE5ZbKr15MvQ8ildTE9vHyqJ+jOnjtd1gQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4095 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > > --- > > .../SerialUartClockLib/SerialUartClockLib.c | 27 +++++++++++++++++++ > > .../SerialUartClockLib/SerialUartClockLib.inf | 26 ++++++++++++++++++ >=20 > I requested after the initial submission that you "either follow the > manual git setup steps from > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt- > git-guide-for-edk2-contributors-and-maintainers > or execute edk2/BaseTools/Scripts/SetupGit.py in each of the tianocore > repositories" >=20 > Now, neither appears to have happened, as .c still comes before .inf > and paths are still truncated. >=20 > But in addition to that, we realised that git happily ignores settings > for --stat. So, please, execute aforementioned script, but then > generate v3 with --stat=3D1000 --stat-graph-width=3D20. >=20 I am preparing the v3 of patches, and I am still seeing this issue after ru= nning SetupGit.py again. After some tinkering I figured out the problem. The git diff is ignoring the diff.Orderfile The reason is line ending of edk2/BaseTools/Conf/diff.order The current line ending of diff.order is windows, while I am using Linux to= prepare patches. If I change it to unix (dos2unix), then git is able to show proper diff I wonder if same problem is with edk2/BaseTools/Conf/gitattributes ? Looks like SetupGit.py needs to be modified to take into account the git ru= nning environment.