From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.78]) by mx.groups.io with SMTP id smtpd.web11.8752.1590841195956194565 for ; Sat, 30 May 2020 05:19:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=GHjsmKAH; spf=pass (domain: oss.nxp.com, ip: 40.107.2.78, mailfrom: pankaj.bansal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kIND8+BmLVra3QaJf7//83K360wiEWpGROneH/Nk+iu8WJXd5kGpcfBdJNWoQk/ry2YYPV3/MCN83umpa62WpCjWUQZvGUlTkTrhp/pMajzRkHbDvRQl3sI2jaU2GK7Bq7ngo3fC4/9whT52he7sSB5WtHw0x0XWzXJCRrYREkJwRtsF067fVLUtek/Czh5XQ2K/Y82+CZQ4U7mX6lOMaJobLR93yIenUlBeTm9iGxMtX00+UJf2GHjGYG0ec1rNyEjZt4IZ5RBbADbFbbUmSbjYxCKu2CMWWbFcqZ48kLDDvdQbZHi0ZOC7YirJfujW4lOAOb6/ahZhJvcbrFMoJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+v/zqQnj6s1QXlxZETIcCK7gZBb/X7uLjRfcYVx+25g=; b=myoYdtGUowb7a3NbbWQLt1HfszHLT+xtdMmFfZVTT7LD57iAznqZuBMtfc+g7iNcWpF1ASDzaXrHAqXA8FEZw0x64/8VgcmWcmpNOqVUle3UB72BdrMEkFXYMH2E1jgffheZAhN/Urvev0khcEzFDPgMuinzSGLK/YwuEarpoZhT3itpNcwXUfzywD5Ha78K7EKfeOmytv9ooZCcf6ir7xi/XTIjvBN58xhCqiiGNnu3YQkm6Fdjg0vJaumjQ8o4PYtijPdzSTUrekxj6y4QADatYio5L3oU9duZpeCrDfHew0Kz99T5z0DiKQLIiVExftv8bJ87AU+pGoEJwVbA8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+v/zqQnj6s1QXlxZETIcCK7gZBb/X7uLjRfcYVx+25g=; b=GHjsmKAHCffTjZOCvEEDnYYpTAMh6RWfE3YSUWepkudcsVxu8oqcvHx00Mzh3OIGAATkU8chmapuEtI7o2pXH0O1hUXxLResxykQ83NOuD+QvAAG6VKE0IKy1kD0g6W0e7G3Q3BJyUCl8FSG0lHJMrIbMWrpOo6HJuo9htpDuLk= Received: from VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) by VI1PR04MB6125.eurprd04.prod.outlook.com (2603:10a6:803:f9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19; Sat, 30 May 2020 12:19:52 +0000 Received: from VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513]) by VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513%7]) with mapi id 15.20.3045.022; Sat, 30 May 2020 12:19:52 +0000 From: "Pankaj Bansal" To: Leif Lindholm , "Pankaj Bansal (OSS)" CC: Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton , Ard Biesheuvel Subject: Re: [PATCH edk2-platforms v2 8/9] Platform/NXP: Add LX2160ARDB Platform Thread-Topic: [PATCH edk2-platforms v2 8/9] Platform/NXP: Add LX2160ARDB Platform Thread-Index: AQHWNnyelXRg0kLdI06LUgEPR49AJA== Date: Sat, 30 May 2020 12:19:52 +0000 Message-ID: References: <20200527085135.16717-1-pankaj.bansal@oss.nxp.com> <20200527085135.16717-9-pankaj.bansal@oss.nxp.com> <20200528150051.GH1923@vanye> <20200529114929.GL1923@vanye> <20200529140310.GN1923@vanye> In-Reply-To: <20200529140310.GN1923@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [49.36.131.89] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 082c8976-d916-47d8-c156-08d80493c19d x-ms-traffictypediagnostic: VI1PR04MB6125: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 041963B986 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fKzLmzKrt0RJuh8mhFsEzsYEHwVQ1lI8mWYw4pZcHD8kSMozOw2kjxkGz9g18NWjPQ22/OaZI9gyDFJrXECGmZHki0Fzc1Oj81ohjTzuqhvVZzupSn7v1+VkBmrQSVBAtQLVX6GOaXZVoAldih5RrqzASgBuU52X7IWDb3shcTVxyJNMSm3JI5stiOHQPxHwkPksaI3ONaJxHn/T6nypP/w2rIgZzyfXLxr00L9chgsxKlDROWUnMMaHDR0p1CTjU2XXPmrvKOCFuSIKQJspYZyhw/VUJzGLIzQV2HM+q2aqGoIwsODkT3AJszy+HQOL85Q44P8doiGURnbWvGgwBTYXFonsKT1Hblth5U9KTUZPJvRxN7aDJbLTx//aeD4T9ZcQQKMZBKWX20LFZLb/uw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5933.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(39860400002)(396003)(136003)(376002)(366004)(2906002)(83380400001)(186003)(6506007)(316002)(53546011)(26005)(478600001)(966005)(86362001)(7696005)(110136005)(54906003)(8936002)(4326008)(8676002)(66946007)(5660300002)(66446008)(19627235002)(52536014)(9686003)(66476007)(66556008)(76116006)(55016002)(71200400001)(33656002)(64756008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: P2rzui6/9eMoVy8nMaiWPCDTfC+N6CbGh/52gQZDi0xMU7CZqu4egrdhGkKzLs3vSB45C0A5SekSddvKcteM7ojqflFtUdKWUdP7CE/m+i4ls5jSeg+TRkuqgyZL9VqTxTJjFzMdMzuGB3dV9ytOwmprTFetV+LsU2uygQGzQ+xRoEhGouWkT795FygeUvLDEU+IsRTN8aLh4ykSm2H1Gc30r6qdeUBWOJqRN9PwVj4F7uKHrH0ycF331oR/0A/BKOL8c6vjSD8xgbcqHUc+qgdSHYluCvqzTOijUNuzYh5GGtrmvB3QVIypO0eFMhsNUlk8wVbGiKyxb5GqJbOgPja5Us46Os4j5RETsp08Kc/YZ2RQT90HPDvpdGQkDA8EwIBfCTJX0R8E/Ov8zCL2BnP70scatmZOMYjDUsA8VRwpfQ4ibIcwvtmTaTz7mmLxF/RT/Vgbh05nL3lUtNLzOPyp8XYbRVQzle99Z2WyM90= MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 082c8976-d916-47d8-c156-08d80493c19d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2020 12:19:52.6221 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U5UDtBfiegIzevPlh0SLlRUsJI+nU6S7Ba4/6/6XXet3nuB19I8UdpSmT14J+za3MWICFU+orc0jcqFtmsbnqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6125 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > On Fri, May 29, 2020 at 12:25:43 +0000, Pankaj Bansal (OSS) wrote: > > > > I intentionally kept these in this order. because Soc depends on Ch= assis > for any > > > include files > > > > Chassis depends on NxpQoriqLs.dec for any include files. > > > > > > OK, I see the logic behind that, but as it has no functional meaning = I > > > don't think it outweighs the benefit of alphabetical sorting. > > > > > > > I referred to the inf specifications for this: > > https://edk2-docs.gitbook.io/edk-ii-inf- > specification/3_edk_ii_inf_file_format/37_-packages-_sections > > > > "Packages must be listed in the order that may be required for > > specifying include path statements for a compiler. > > For example, the MdePkg/MdePkg.dec file must be listed before the > > MdeModulePkg/MdeModulePkg.dec file" >=20 > I see that. (And sigh.) Clearly, that needs to be fixed. I have cc:d > you on the patch to do that. >=20 > I am sure that made sense when that text was originally written, which > was presumably the previous millenium. But this is akin to "optimising" > the order in which header files is included. >=20 hmm. I think it was written to maintain the dependency between include file= s. But I guess if we follow edk2 c guideline we can avoid this problem. https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_sour= ce_files/53_include_files#5-3-4-include-files-may-include-only-those-header= s-that-it-directly-depends-upon > > By design the Chassis package files can include generic NXP package > > files. not the other way around. > > same goes for SOC package files. SOC package files can include > > Chassis Package file but not the other way around > > and we can extend this further. any platform package files can > > include SOC package files > > > > > I *do* tend to say "alphabetically, unless there is a better logical > > > order", but by that I usually mean grouping related Pcd dependency > > > declarations. > > > > as I mentioned above, there *is* a logical order to packages. >=20 > And as I said "I see the logic behind that". > I'm saying readability trumps that logic. Ok. it makes sense. >=20 > > > > > > This is my only remaining niggle with this set - are you OK with me > > > folding in > > > > > > --- > a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > > +++ > > > > b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > > @@ -18,9 +18,9 @@ [Packages] > > > MdeModulePkg/MdeModulePkg.dec > > > ArmPkg/ArmPkg.dec > > > ArmPlatformPkg/ArmPlatformPkg.dec > > > - Silicon/NXP/NxpQoriqLs.dec > > > Silicon/NXP/Chassis3V2/Chassis3V2.dec > > > Silicon/NXP/LX2160A/LX2160A.dec > > > + Silicon/NXP/NxpQoriqLs.dec > > > > > > to v3 9/10 and pushing the set? Ok. can you please sort all the dec files under [Packages] based on names b= efore pushing ? I think this file also needs alphabetical sorting: https://github.com/tianocore/edk2/blob/master/ArmPlatformPkg/Library/ArmPla= tformLibNull/ArmPlatformLibNull.inf#L16 > > > > > > / > > > Leif