From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (EUR02-AM5-obe.outbound.protection.outlook.com [40.107.0.75]) by mx.groups.io with SMTP id smtpd.web12.33411.1590755146919985823 for ; Fri, 29 May 2020 05:25:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=P0unTAtQ; spf=pass (domain: oss.nxp.com, ip: 40.107.0.75, mailfrom: pankaj.bansal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HdXHVnyuR++L9Cjd3toN2C6HZdvw/+FXjxa5g8N6kq9cpJ08kWIvbzb1YpgW1ydCXwOZapt8f/4uno+HSDeWa5a7tPPnpo0RrCUKdy0FFl7X7k9wd1H4RicrQGVKXj1aSzDArN0CVz38iDzHTx4PJcQd8ZUKTVQzTQsJS+W8zcAc1qZatPDcacJlSfkWxHEembLefI9b4eMUSLRm1DPF01uCyOXR4KaQfv5y78+KN1pqBOVa+K5cMPpei2rY7A8jaCJovtLtpOZMotfbbJyPHymCOYeZoHgXrgABgT2KOPY1X/1M8L9slLZBAz3Wh9ywLbYt0RRg1oC0XjtF42uuPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kaUeBCcTwsfHHwDUQ6g5L4VmczzRDJDkrZVinFBogZo=; b=GxjV0hOF9RkGuAFddYQgoqGiEMIz3y0PTEqZt/ui4oGzmjd//g7tiiRLAI+EiUQjEGyXV96LC4Fe3lujoNqiUyin/NVhj3QkMbzVXAMD6OWoGpPuSMiH6v/l0Gy9Z98Ult0vSXkNy67nXHPR7hr8TQ9l4pXTd3lVFdFCKX3YVYlfzGNL7cAq2JWru4ZcrjweQRZ95ACN0AYxkApzP+Yx2c9IyWhxInOETHzmj1lU63msHEyo9aqDWRP8BzMpNjHV0pfOhX3U81W/xzHrp7f6PRcKMzMIYZpJp6MWP1+psMYa0pN7DFhM8V2wBgpYL3LgPFTC2yiaRIfFMWem1htPTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kaUeBCcTwsfHHwDUQ6g5L4VmczzRDJDkrZVinFBogZo=; b=P0unTAtQ95wvezHyv3A2QLkpj55caRL99Z4hu8e0P3ASjJkx1xzk7ecYrzwHsZiY0B3ueh7MfC/iafHUqmxnknNGQEQVrTrUj0aSmSfKrBRS4m9M/HNIKyJ+vIHUjwQ3BjC0bhQ6OvcQMSHFZRFqkW+qfrYY99071vtA+t7S80o= Received: from VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) by VI1PR04MB4589.eurprd04.prod.outlook.com (2603:10a6:803:6f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.27; Fri, 29 May 2020 12:25:43 +0000 Received: from VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513]) by VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513%7]) with mapi id 15.20.3045.018; Fri, 29 May 2020 12:25:43 +0000 From: "Pankaj Bansal" To: Leif Lindholm , "Pankaj Bansal (OSS)" CC: Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton , Ard Biesheuvel Subject: Re: [PATCH edk2-platforms v2 8/9] Platform/NXP: Add LX2160ARDB Platform Thread-Topic: [PATCH edk2-platforms v2 8/9] Platform/NXP: Add LX2160ARDB Platform Thread-Index: AQHWNbRFrFBV64GVnE6laHptmUfkDA== Date: Fri, 29 May 2020 12:25:43 +0000 Message-ID: References: <20200527085135.16717-1-pankaj.bansal@oss.nxp.com> <20200527085135.16717-9-pankaj.bansal@oss.nxp.com> <20200528150051.GH1923@vanye> <20200529114929.GL1923@vanye> In-Reply-To: <20200529114929.GL1923@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [49.36.131.89] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 6d2877cd-8d94-4ef5-4ffd-08d803cb6869 x-ms-traffictypediagnostic: VI1PR04MB4589: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 04180B6720 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qPxksRav92npS9xThD/Lyq0yl2ykEJxKTGEnxZuWkv73gxHJo2kcvbBRmsPZvlv3PRHpBsbbmz29rk2op2NgfIop1YFPO47pLVrixDJMbyP46mJTeSVUsiwVp4ztwexbCUdOlS8hcAYRvbf08yjzDANR/49siIF+03GMXOKt9aeofaP8/YTeThhFsYwC483EVSZ2+YFAudsaY+95W4nUyA4jv1b/kwpeEujneozYOej9M4GggxCjP3KJZ7XfwFxKbdsuH/VFIbHw2vzvtVOE1ZcfGsqw5c+Ak2QKfd0A+7idnnMClSOk3WgiT5GsFzuKx9d2+Izq6B7HuFrIXvienDKzB1yARF68mmF+/IAV3/1ttzf+UvX60LtT+z8vAxasonnBIkQIKNQP2g0jMhn94Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5933.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(136003)(396003)(346002)(39860400002)(366004)(6506007)(478600001)(33656002)(4326008)(7696005)(86362001)(52536014)(53546011)(186003)(110136005)(9686003)(26005)(2906002)(316002)(966005)(66476007)(66446008)(55016002)(66946007)(66556008)(76116006)(54906003)(8676002)(71200400001)(8936002)(19627235002)(83380400001)(64756008)(5660300002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: Jv+MEd2wGGWVHl/39XTUWR0vJndIMDPxrxlQNp9Jr6qz0iE4qkhG19OXKTVuBaFZNlhJCQxivXyTTeBvSV9YgsWx7hRk7Uem45X+g9RtaWOl5e960RLGPnrMjVCM0dSzWMkx3GM6+XW8oYQdGy63RP9vauHxFbsl6c/FbMhZFJWobGq1WDjdRiYakbsS89TcjFdJy0EcHxhYlQ4HXAOfDyJXDGamBNP5yqzfg2zgED8msM5g/gpCyCgBPsW8wsBpnyEj/71rSGJTVDq1J0VaL84wUVvq8M2RyxDcWhXkfdreoXGoKaWCpzaNVix1yDVWfverziLOqRDOwT2u8+i8J5Tf8VfMF08OjVdfrUhNZXQOH1krkuFxwCg/+tzoXf48cL4ZC6B6DEFMgY5J2x6si4JQ/aNngPg+BkAHcs2ZKt7IL5Tcn7yiLcfrE6OsPHB0WYRgsLMSKCUVJlsn+HtwQbRyLe5cqgBQGf3ooISUWN0= MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d2877cd-8d94-4ef5-4ffd-08d803cb6869 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2020 12:25:43.6302 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V8ziB2Faztw7zOpjMTT0FCCzZ+Ia4DmOLtQMuyRcwoKaRK6vfYyla7sxZeogIyyCwla2NcsvvUZ3gQsUOhUIVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4589 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > On Fri, May 29, 2020 at 05:21:24 +0000, Pankaj Bansal (OSS) wrote: > > > > --- > > > > a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > > > +++ > > > > b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > > > @@ -19,9 +19,12 @@ > > > > ArmPkg/ArmPkg.dec > > > > ArmPlatformPkg/ArmPlatformPkg.dec > > > > Silicon/NXP/NxpQoriqLs.dec > > > > + Silicon/NXP/Chassis3V2/Chassis3V2.dec > > > > + Silicon/NXP/LX2160A/LX2160A.dec > > > > > > Please insert alphabetically sorted. > > > > I intentionally kept these in this order. because Soc depends on Chassi= s for any > include files > > Chassis depends on NxpQoriqLs.dec for any include files. >=20 > OK, I see the logic behind that, but as it has no functional meaning I > don't think it outweighs the benefit of alphabetical sorting. >=20 I referred to the inf specifications for this: https://edk2-docs.gitbook.io/edk-ii-inf-specification/3_edk_ii_inf_file_for= mat/37_-packages-_sections "Packages must be listed in the order that may be required for specifying i= nclude path statements for a compiler. For example, the MdePkg/MdePkg.dec file must be listed before the MdeModule= Pkg/MdeModulePkg.dec file" By design the Chassis package files can include generic NXP package files. = not the other way around. same goes for SOC package files. SOC package files can include Chassis Pack= age file but not the other way around and we can extend this further. any platform package files can include SOC = package files > I *do* tend to say "alphabetically, unless there is a better logical > order", but by that I usually mean grouping related Pcd dependency > declarations. as I mentioned above, there *is* a logical order to packages. >=20 > This is my only remaining niggle with this set - are you OK with me > folding in >=20 > --- a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.in= f > +++ > b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > @@ -18,9 +18,9 @@ [Packages] > MdeModulePkg/MdeModulePkg.dec > ArmPkg/ArmPkg.dec > ArmPlatformPkg/ArmPlatformPkg.dec > - Silicon/NXP/NxpQoriqLs.dec > Silicon/NXP/Chassis3V2/Chassis3V2.dec > Silicon/NXP/LX2160A/LX2160A.dec > + Silicon/NXP/NxpQoriqLs.dec >=20 > to v3 9/10 and pushing the set? >=20 > / > Leif