From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.71]) by mx.groups.io with SMTP id smtpd.web10.28962.1590729688539284553 for ; Thu, 28 May 2020 22:21:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=YodX9AfF; spf=pass (domain: oss.nxp.com, ip: 40.107.22.71, mailfrom: pankaj.bansal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JvMliy1kuHjBgNzxindy0S+UPewQ0HNHoCkEVnCblVorUtfWHA54e+pBzy8pihRhFy6rSDfFTmp3oczuBNgdtIVIKg+64QLqw687TKm+uH2iWOyAbDx4wTjC2hB0/BpTkckE1fG12MaBcnCN7Kv4APxFUsN72TkEblGODg34CoF9kq5/+HTWXweWBX5dpm5jrN5swvzw0FwX6b5GEDexzWsmCY/j+kLPGykaXWj/Qw28UgUN/SA3v9LNRGauEsvru+Ev2jgcCuaaLeZvMBXjAGPbczlNE7z7bm/fEDezs5sUhByBszJ2Q+mv1bq37qRwBLTm4Z42MDwFAC34nZDDdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=izwOH299fg8K2GpYKWoSx5u7hHij6Jp5gISU28jgUho=; b=PavFRMNUErd54m0i4q65wTqHFFjVA8Ml6r/ORXzcNvWzWfAPU5kMyZY3Dx/OggUMkoCspgkyPMj/yoQd5wpD7lgjwvJx3XrVCji2eq+ZH6hy0Gsg6GgMalbKEcRuWhr1IRveFhUSBFkSibJCHI09Wu+JFAJ78+FcTuOfc6/9eMZ4bxgR4yVNp38E5q6AyNyWQym0dF4RSuyXpf0B90aPY+4N9bPpY1jOXhQ3+cTOB3+uHVGHb3JFOxbaLyaDW3V5FdEFJBIUuXq7p/8nYrctj0bFpjwvrC9j8m41U/0uzooLsyDl45WTBYPpf5tUlAUpPBFnfVwQrqnHDIWn7AYCpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=izwOH299fg8K2GpYKWoSx5u7hHij6Jp5gISU28jgUho=; b=YodX9AfFihv4Aoas3W0hvRkD6jYdiUDhQv31anh2VefBpB5siF7uwbmIbIL3KXSI62UDs+4toMqmkpzTLItw9qrUCgoHfOetG9Ro2DZazvZnPjLJx/MkKLgFGeiG1UzxcxB0clqUGbFiEPn79WO7Nx7HkU1Tnm4xANda/hyf9to= Received: from VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) by VI1PR04MB3006.eurprd04.prod.outlook.com (2603:10a6:802:4::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.21; Fri, 29 May 2020 05:21:25 +0000 Received: from VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513]) by VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513%7]) with mapi id 15.20.3045.018; Fri, 29 May 2020 05:21:25 +0000 From: "Pankaj Bansal" To: Leif Lindholm , "Pankaj Bansal (OSS)" CC: Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton , Ard Biesheuvel Subject: Re: [PATCH edk2-platforms v2 8/9] Platform/NXP: Add LX2160ARDB Platform Thread-Topic: [PATCH edk2-platforms v2 8/9] Platform/NXP: Add LX2160ARDB Platform Thread-Index: AQHWNXj/94I9Ugq/s0ut1YigRCwwrw== Date: Fri, 29 May 2020 05:21:24 +0000 Message-ID: References: <20200527085135.16717-1-pankaj.bansal@oss.nxp.com> <20200527085135.16717-9-pankaj.bansal@oss.nxp.com> <20200528150051.GH1923@vanye> In-Reply-To: <20200528150051.GH1923@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [49.36.131.89] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d8006b45-0e43-4057-cae4-08d8039021d8 x-ms-traffictypediagnostic: VI1PR04MB3006: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 04180B6720 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wbkIf2A9h6pzI8QStqu5H3chbwjJp8+4LIHzocVNurgYFHatVAWgIABZIKvcLtCD9wcFOo+gCgwMxEUXNj2AAB2J0zWoQ591BXcPot8lJdZ9GGszTDmLn/bHiSQG/lF1vqj48IJEnYNZzZbEse4d84BblVPY6wGhfqvKGiaDrdJKpfRPGIFXRlehuK0AhqwzUXfaL+iFCqIQF5ogDFrWdkVfmsWSfKPj32UEd8qEu74k7N6zoQRU7SUMsyaUhWPmvjR8W04luyktTNVmihXmFShFp4xD1zq896i3VETIJ7Kvu91ISGBNxxUNaC8IlKuU x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5933.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(366004)(136003)(376002)(346002)(396003)(8676002)(316002)(52536014)(54906003)(110136005)(7696005)(71200400001)(6506007)(186003)(478600001)(26005)(55016002)(8936002)(2906002)(9686003)(5660300002)(33656002)(83380400001)(4326008)(76116006)(66446008)(64756008)(66556008)(66476007)(66946007)(19627235002)(4744005)(86362001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: enB5DurCVCz4P9N/dxX4TRTwbDjgiceVFt5mOWfXRJ18PTHuiGagBRtw+zQPItAS1LsTFjs2X8wxRfWlPyouBoF8HgN4cRL5KLLJAWeBre44Uw9sM3LrFUukUfdg59MEtfhSfbuQC2FhVah8TF4ZBkfpF+fDMpvgBpXU4KT4uYFV6EPLY7GDkAsypjXmgi/lJIlXJyfK/tCvgINxnoRD+fl1jjmS1vFpp1/kpB3QlZVTr8c3CoJXCLFAk98GAbIL62luwzZ/jBYQpuaM1w811ytJrsVUBru11aKFRTPyQNF6ifzdHKW2U925Wu2D6ghbr4nzrISAC9xpA9gsdq4KB8b3bh9jlr9rJ019Aln6BEKhI4Q2lihumIIBU/9jpYFb9PcvQgMvnrrbTO4TR+axY49O6O9otXYN68RFwbCulSRXvSyAbqI05IcdmEkWgrTSFQZnvjWRolUYC014xNZslWmUzwkQoV6IGNucCGXTL4I= MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8006b45-0e43-4057-cae4-08d8039021d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2020 05:21:24.8416 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8w58i/PLFxZ7D0Ht0jjLEoCFty+QmCpgHf676szrEuKjnLhfmq3olfclt4n1575/1VeDUy8jCjaeE7IR1bcukg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3006 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > > --- > a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > +++ > b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > @@ -19,9 +19,12 @@ > > ArmPkg/ArmPkg.dec > > ArmPlatformPkg/ArmPlatformPkg.dec > > Silicon/NXP/NxpQoriqLs.dec > > + Silicon/NXP/Chassis3V2/Chassis3V2.dec > > + Silicon/NXP/LX2160A/LX2160A.dec >=20 > Please insert alphabetically sorted. I intentionally kept these in this order. because Soc depends on Chassis fo= r any include files Chassis depends on NxpQoriqLs.dec for any include files. >=20 > > > > [LibraryClasses] > > ArmLib > > + SocLib > > DebugLib >=20 > Please insert alphabetically sorted. This I can take care >=20 > No further comments on this set for v2. > For the patches I have not commented on: > Reviewed-by: Leif Lindholm >=20 > / > Leif >=20 > >