Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib

["Pankaj Bansal" <pankaj.bansal@nxp.com>]

> -----Original Message-----
> From: Leif Lindholm <leif@nuviainc.com>
> Sent: Wednesday, April 1, 2020 3:23 PM
> To: Pankaj Bansal (OSS) <pankaj.bansal@oss.nxp.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; devel@edk2.groups.io; Varun Sethi
> <V.Sethi@nxp.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>; Jon Nettleton <jon@solid-run.com>
> Subject: Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib
> 
> On Fri, Mar 20, 2020 at 20:05:22 +0530, Pankaj Bansal wrote:
> > From: Pankaj Bansal <pankaj.bansal@nxp.com>
> >
> > Implement SerialUartClockLib for all NXP Layerscape Platforms.
> >
> > Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
> > ---
> >  .../SerialUartClockLib/SerialUartClockLib.c   | 27 +++++++++++++++++++
> >  .../SerialUartClockLib/SerialUartClockLib.inf | 26 ++++++++++++++++++
> 
> I requested after the initial submission that you "either follow the
> manual git setup steps from
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-
> git-guide-for-edk2-contributors-and-maintainers
> or execute edk2/BaseTools/Scripts/SetupGit.py in each of the tianocore
> repositories"
> 
> Now, neither appears to have happened, as .c still comes before .inf
> and paths are still truncated.

I had executed the SetupGit.py script, I will check again.

> 
> But in addition to that, we realised that git happily ignores settings
> for --stat. So, please, execute aforementioned script, but then
> generate v3 with --stat=1000 --stat-graph-width=20.
> 

Ok. I will follow these steps as well.

> For this particular patch, the side discussion on the edk2 portion may
> make it redundant, so I'm deferring review.

Right now, I am yet to work on the review comments of other edk2 patch
and since it touches other platforms as well, it requires thorough vetting from other
platform maintainers. It seems like that would take more time. If I send this patch
series without removing DuartLib (i.e. drop patches 7, 8, 9 from this series), can you
please merge. Parallelly, I will work on edk2 patch and once that is accepted, I will send
patches 7, 8, 9 after that in new series ? 

> 
> /
>     Leif
> 
> >  2 files changed, 53 insertions(+)
> >  create mode 100644
> Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
> >  create mode 100644
> Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
> >
> > diff --git a/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
> b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
> > new file mode 100644
> > index 000000000000..9d49d7b4748b
> > --- /dev/null
> > +++ b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
> > @@ -0,0 +1,27 @@
> > +/** @file
> > +*
> > +*  Copyright 2020 NXP
> > +*
> > +*  SPDX-License-Identifier: BSD-2-Clause-Patent
> > +*
> > +**/
> > +
> > +#include <Base.h>
> > +
> > +extern
> > +UINT64
> > +GetBusFrequency (
> > +  VOID
> > +  );
> > +
> > +/**
> > +  Return clock in for Uart IP
> > +**/
> > +UINT32
> > +EFIAPI
> > +BaseSerialPortGetClock (
> > +  VOID
> > +  )
> > +{
> > +  return GetBusFrequency ();
> > +}
> > diff --git a/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
> b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
> > new file mode 100644
> > index 000000000000..9a3e80cf521d
> > --- /dev/null
> > +++ b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
> > @@ -0,0 +1,26 @@
> > +#  @file
> > +#  Copyright 2020 NXP
> > +#
> > +#  SPDX-License-Identifier: BSD-2-Clause-Patent
> > +#
> > +#
> > +
> > +[Defines]
> > +  INF_VERSION                    = 1.27
> > +  BASE_NAME                      = SerialUartClockLib
> > +  FILE_GUID                      = fa65495e-d3c8-4ea3-9737-994e9ccbaf11
> > +  MODULE_TYPE                    = BASE
> > +  VERSION_STRING                 = 1.0
> > +  LIBRARY_CLASS                  = SerialUartClockLib
> > +
> > +[Packages]
> > +  MdeModulePkg/MdeModulePkg.dec
> > +  MdePkg/MdePkg.dec
> > +  Silicon/NXP/NxpQoriqLs.dec
> > +
> > +[Sources.common]
> > +  SerialUartClockLib.c
> > +
> > +[LibraryClasses]
> > +  SocLib
> > +
> > --
> > 2.17.1
> >