From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.86]) by mx.groups.io with SMTP id smtpd.web12.6097.1586154823219434363 for ; Sun, 05 Apr 2020 23:33:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=Wo8KhetX; spf=pass (domain: oss.nxp.com, ip: 40.107.5.86, mailfrom: pankaj.bansal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i8WvM/HqrLZ3TRKZKiLZTCRurBBA6ieXAAdiA5dQoYVcUXvcO4rv13XvJkUu8sZokTBrOJBgOU4UG0MlkgFsrOEDFsRi29P3ATigXB+xH06IT7SLxH0Dc/UsA/mS91cC7xL6OncprM+Xb/a/Rq7hg1/y2ftsZGVi+hFgakWth8Ff7t5T0pVueneCe+IKq5MlGSGIvd7FqJSwb/6knF5LMAS+4aAk0oF1r3iNHkvqAj2L/Da06njoyUcktuDqyTYIo35Jq0DMYwePq0VLN+EHRrTK6RjlrES+Icrj+6v4lPxvzQVftEEbt8JaWiWHTZHNJ3KmAkDKIy51b1ICdV4+Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kYFbPadwsSBqA5lr3jC14vqVMnEbYd08Gtq0mfN4qh0=; b=TDJHlejHHmYcixcVLqFzz68RCYg3l5z8lgC36Ams1PzAjdqeaHZkkydkwx/ZY1MtdvlBRBZPDOA2LOKQ0+3Wt0lnPeZ41KtVBhNL8Ba9v6aLNlwtkLSfDibFTjya2ubSbwVKDfAHiRFLHmZzkGhGHUirARsLoseEd3A2jAer2zDh/Wv9uMJeCYIkKktB6vFcuazk5uvDaeGQal3in1taDy4oL6khAeVqXp0Vb4q++JyzpxE4vmC/TCLSa6r0e0EtCEZhglcmA9s+aZS6TdH3Qgal73kZ0P63hIYaC623f/I33rhFP/RXmPGKdQ+7ai0AxNzOs9vptP5krB1oAn5Htg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kYFbPadwsSBqA5lr3jC14vqVMnEbYd08Gtq0mfN4qh0=; b=Wo8KhetXcCiasL9hyu2TDq6LdgXk4bYBw4GPFpZ+N2M+qJgy5UXg1U+Hl8vVkEdcEc88AiyMtLJqySegTt44Hq3OHcYP1xxJFAtCnTsxG/LyLetmWTN2kzI1tyca49XCw0vAGHD5dle5xuHiZpdJPk+si2IxeziTso9v0NW2CSM= Received: from VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) by VI1PR04MB6126.eurprd04.prod.outlook.com (2603:10a6:803:102::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15; Mon, 6 Apr 2020 06:33:40 +0000 Received: from VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::e581:c145:2f3c:fa18]) by VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::e581:c145:2f3c:fa18%6]) with mapi id 15.20.2878.018; Mon, 6 Apr 2020 06:33:40 +0000 From: "Pankaj Bansal" To: Leif Lindholm , "Pankaj Bansal (OSS)" CC: Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib Thread-Topic: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib Thread-Index: AQHWC91P8isFp0rbZ0+im4EQQ+S/Wg== Date: Mon, 6 Apr 2020 06:33:40 +0000 Message-ID: References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-8-pankaj.bansal@oss.nxp.com> <20200401095329.GO7468@vanye> In-Reply-To: <20200401095329.GO7468@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=pankaj.bansal@oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [49.36.135.41] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1696e624-7f3c-4842-07a6-08d7d9f471ec x-ms-traffictypediagnostic: VI1PR04MB6126:|VI1PR04MB6126: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0365C0E14B x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5933.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(346002)(396003)(136003)(39860400002)(366004)(26005)(186003)(52536014)(8676002)(66476007)(76116006)(66946007)(66556008)(81166006)(5660300002)(7696005)(8936002)(81156014)(86362001)(19627235002)(6506007)(53546011)(110136005)(4326008)(33656002)(64756008)(66446008)(71200400001)(316002)(54906003)(2906002)(9686003)(966005)(478600001)(55016002);DIR:OUT;SFP:1101; received-spf: None (protection.outlook.com: oss.nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tm/S47tuu+BxpFbz0ca88xbtar2VFKFA0UMmTUSePeTxCLELxlto6uICBcyiTOjjtIhiN+FqkfjbdP92xlUjJJ1iljI+WskpkQ+qja9zIT5ncqWSbaU3T/BIOurI6VvJFs7uAd2cvL98D37EltBM39KRZkHHoY2Xu325fsMCrK/c6KOpsoiWvsfPxEXYcW+IllRRGaaZi4VylqMkNw9SEX11PS81KLGzv7ZL9T5PRWqs5qQgBmbLWWyVsrV4mJCP9po3ClDQa0Ns1VFODG6N3dM4AzReBcFkXsXKsW8EesntZNBXC+XOACoewioF2kGFt44YzjdQircuhJpLn7hK/XCt5VurgJXnpTljvz2ClN78G/4jbYdsYvyNA/nBwhlhNuEKKo+CsJ0icVgtgmVeSvr2+nFrxjyPW7QkF6AhHQ/CjwgUg9Wge/Yqdvk4ni6ABWg5yLeFQeK2gG1vf0bRsVfTppov5gpAoa02gnvgwVRciRoYIfx4j7bA9had+6h3lH6tRCU6cdehbLsA+Kul6g== x-ms-exchange-antispam-messagedata: 261TBR0JAOIJ+Sy2defnwUVF9YriaJ5JsOhorPnCLKSRB901qBf+NNYySO5t7BbQsuLQ6EyqC287uxN57uym+2g6S/LcSQgoJ5JMgNtIQCzRrGEqWda0oXcyLUNAcwyzT+YVrkrNUbkfQ04kfWd6Aw== MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1696e624-7f3c-4842-07a6-08d7d9f471ec X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2020 06:33:40.1286 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9ikzZkq8+oT/KUJUvZUhagjlaj+AmscyS9/3mg7j7h2OWNu+2y/riwwJz5YEpXJ7d6Ewm8dj+zNoAfAKWOA7Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6126 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm > Sent: Wednesday, April 1, 2020 3:23 PM > To: Pankaj Bansal (OSS) > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; devel@edk2.groups.io; Varun Sethi > ; Samer El-Haj-Mahmoud Mahmoud@arm.com>; Jon Nettleton > Subject: Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib >=20 > On Fri, Mar 20, 2020 at 20:05:22 +0530, Pankaj Bansal wrote: > > From: Pankaj Bansal > > > > Implement SerialUartClockLib for all NXP Layerscape Platforms. > > > > Signed-off-by: Pankaj Bansal > > --- > > .../SerialUartClockLib/SerialUartClockLib.c | 27 +++++++++++++++++++ > > .../SerialUartClockLib/SerialUartClockLib.inf | 26 ++++++++++++++++++ >=20 > I requested after the initial submission that you "either follow the > manual git setup steps from > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt- > git-guide-for-edk2-contributors-and-maintainers > or execute edk2/BaseTools/Scripts/SetupGit.py in each of the tianocore > repositories" >=20 > Now, neither appears to have happened, as .c still comes before .inf > and paths are still truncated. I had executed the SetupGit.py script, I will check again. >=20 > But in addition to that, we realised that git happily ignores settings > for --stat. So, please, execute aforementioned script, but then > generate v3 with --stat=3D1000 --stat-graph-width=3D20. >=20 Ok. I will follow these steps as well. > For this particular patch, the side discussion on the edk2 portion may > make it redundant, so I'm deferring review. Right now, I am yet to work on the review comments of other edk2 patch and since it touches other platforms as well, it requires thorough vetting = from other platform maintainers. It seems like that would take more time. If I send th= is patch series without removing DuartLib (i.e. drop patches 7, 8, 9 from this serie= s), can you please merge. Parallelly, I will work on edk2 patch and once that is accept= ed, I will send patches 7, 8, 9 after that in new series ?=20 >=20 > / > Leif >=20 > > 2 files changed, 53 insertions(+) > > create mode 100644 > Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c > > create mode 100644 > Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf > > > > diff --git a/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.= c > b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c > > new file mode 100644 > > index 000000000000..9d49d7b4748b > > --- /dev/null > > +++ b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c > > @@ -0,0 +1,27 @@ > > +/** @file > > +* > > +* Copyright 2020 NXP > > +* > > +* SPDX-License-Identifier: BSD-2-Clause-Patent > > +* > > +**/ > > + > > +#include > > + > > +extern > > +UINT64 > > +GetBusFrequency ( > > + VOID > > + ); > > + > > +/** > > + Return clock in for Uart IP > > +**/ > > +UINT32 > > +EFIAPI > > +BaseSerialPortGetClock ( > > + VOID > > + ) > > +{ > > + return GetBusFrequency (); > > +} > > diff --git a/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.= inf > b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf > > new file mode 100644 > > index 000000000000..9a3e80cf521d > > --- /dev/null > > +++ b/Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf > > @@ -0,0 +1,26 @@ > > +# @file > > +# Copyright 2020 NXP > > +# > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > +# > > +# > > + > > +[Defines] > > + INF_VERSION =3D 1.27 > > + BASE_NAME =3D SerialUartClockLib > > + FILE_GUID =3D fa65495e-d3c8-4ea3-9737-994e9ccba= f11 > > + MODULE_TYPE =3D BASE > > + VERSION_STRING =3D 1.0 > > + LIBRARY_CLASS =3D SerialUartClockLib > > + > > +[Packages] > > + MdeModulePkg/MdeModulePkg.dec > > + MdePkg/MdePkg.dec > > + Silicon/NXP/NxpQoriqLs.dec > > + > > +[Sources.common] > > + SerialUartClockLib.c > > + > > +[LibraryClasses] > > + SocLib > > + > > -- > > 2.17.1 > >