From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.77]) by mx.groups.io with SMTP id smtpd.web12.374.1586278853972544875 for ; Tue, 07 Apr 2020 10:00:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=TZ6RqXbb; spf=pass (domain: oss.nxp.com, ip: 40.107.13.77, mailfrom: pankaj.bansal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=odjkf7fnRwepYpvb5f+T8cgkPhSB49Sqg7MhgPHnO4c3VEj5z3ZeHudJ9GDocCJmg1YV5UPfGP1CAzRudC7xQj7XKrPwJvRSAGzyPAPyOtztY6vvHutObqJUF3vDtHIkxg+Y08LLCuvjMuIATXJ4J1mDh70+kWQdx7aUn1DcaXUiPjfoz80p8aA1S3SLnoIcxjyCEPGY+hYU77amc/iKopBjCHGMnsuf8bI8aHDK3V3dC29JrEjWaJxFxKFn1lJDPPxf57QPh476RVlds07/JlB/qaMi2keOeqtzLSqtky85q3oWG8pcq91JRdWbJzM9vgicGUzqfNYH+YGAYZsaOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F3MSA2kGo8UtAt18ipMoS11deOsrztZjElhVFII4Q9w=; b=PQKUVlw/WbHYmXtqQPtZrqH4YczGQRbJcNIhU8q8hwovPzSZZLdG5LEBzHzrYjJJwl02XG5qZCMUaxZN8+ctkbgHbSaccg3zHmlovkOMl0/h4Y6/h/yfZyPk222VWGvdw41tAbXcCNIw98TDp8cwRWt5Lp6ERTnnZYsOFjIm1qw51oFX7dKL4bfJ5BoxlsG97ACKWDgkpA9NI2xa1tYxuFyNliaAkZZ5GVfeL2bHUkTt/skCqDaCXPKAELehMFkaLvtJVBOBrxtja+pTaStXffObyKTzv7ZaLRH22c8674eTO9EU/mTGZczc8RkZhH4soKhWrKjZVHSrJgRcWMJylg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F3MSA2kGo8UtAt18ipMoS11deOsrztZjElhVFII4Q9w=; b=TZ6RqXbbEE8Zp03NC/96jhBErXHBA2CU5vcwjOy7k7CLdcAhjFEGWh6tSAgujolB/GuL3dKWN8H5utHRZRhzzoSrTXn09NK6h2nhZXf99kGTj3RUJlZHwQM1h7Kw4lFGoBwkWnwcJ+XmBx7nIvqfQMIwCsEUWZw2gtQ0h71acRI= Received: from VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) by VI1PR04MB6096.eurprd04.prod.outlook.com (2603:10a6:803:f6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.16; Tue, 7 Apr 2020 17:00:50 +0000 Received: from VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::e581:c145:2f3c:fa18]) by VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::e581:c145:2f3c:fa18%6]) with mapi id 15.20.2878.018; Tue, 7 Apr 2020 17:00:50 +0000 From: "Pankaj Bansal" To: Leif Lindholm , "Pankaj Bansal (OSS)" CC: Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib Thread-Topic: [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib Thread-Index: AQHWDP4X6qnAtCikVUmoHL9YT3vFfQ== Date: Tue, 7 Apr 2020 17:00:50 +0000 Message-ID: References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-22-pankaj.bansal@oss.nxp.com> <20200401145324.GD7468@vanye> <20200407125359.GO14075@vanye> In-Reply-To: <20200407125359.GO14075@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=pankaj.bansal@oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [49.36.135.41] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 10842ccb-e228-4d87-b0ff-08d7db1539d5 x-ms-traffictypediagnostic: VI1PR04MB6096:|VI1PR04MB6096: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 036614DD9C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5933.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(39850400004)(396003)(376002)(346002)(366004)(136003)(26005)(33656002)(966005)(5660300002)(110136005)(2906002)(76116006)(316002)(52536014)(54906003)(66446008)(64756008)(66556008)(7696005)(81166006)(55016002)(4326008)(66946007)(71200400001)(66476007)(8676002)(81156014)(86362001)(9686003)(186003)(478600001)(8936002)(6506007);DIR:OUT;SFP:1101; received-spf: None (protection.outlook.com: oss.nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Bxb3XPY14lPYcwB0G81EsXxsvs+E7eJXgAgv1iutTE9XIn4gfBUBj/Zi4s2NMp498tw9rTU81Smjhi6Z92onEW6UBK9RegyGysD9xSloRPgCptPJICDKuaNbCyyz2iDu3pSp8NLda4QjA2SxVpHuBXMPc8CfUY0X+aQMFJKqOxIHMwQxB9DvD2ulRHb5ikaZ0k3HdxEihWcVXMX8BBQ1ciCx1A5OKmWtO3m1YqApX/qPIcBfKaSo0+mjwMbkPrgV2239AirXjDjdnEuLPI3fRLsnKQ1dCNfnqPD3tBt7u++1p9GKILfCbWQR6xGyjmN5Fx+MppcFGu/T8syuiXfMNY2pX6b2gVSoZ0atBbquh1JsDC/KAAxz128zi0DNbXvNI9+Gizjmt2vtV3xdqqf13FpD0GDAV2YvpSFutSePXdlCX+Cmskhi1+O7HnEWQDEGpOTuZ/6g/jrJ2gYH4Ni7+fbZPdKmFxpi86W60z3ZlF4SkXXtGk+A2MX6xvKZFmaX/UbYblI5DazJskFVimnHtw== x-ms-exchange-antispam-messagedata: 6kL0m1u9yeGg/MOhP536E5pY+IWariMdr8QK/YNWgVs0CC7CxzKTSTZWPKXKRRYHMrFmYbe+tI4tJYScEXYBlatZUYFkMj7b7gBMysGqmwbdq9eyAQULQcrw7FZxgSLMI+2wPgW/7xRCvf7wuSxRBg== MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10842ccb-e228-4d87-b0ff-08d7db1539d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2020 17:00:50.5617 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GArIOYgt9k2EhF7Yka5yxHulZW+2aMZ+DAi+TfvQJoAabaF0fC/epGznmqwoty/smMvmRE+KwNRH1u7PDLeIlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6096 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > OK, taking another look at this patch, this simply needs to be > deleted. Here is the sum total relevant difference compared to the > ArmPlatformPkg one. >=20 > DEBUG ((DEBUG_INIT, "Edk2 version is %a\n", XPRINT > (WORKSPACE_GIT_VERSION))); > DEBUG ((DEBUG_INIT, "Edk2 platforms version is %a\n", XPRINT > (PACKAGES_PATH_GIT_VERSION))); >=20 > If all you want to do is to print that sort of thing, please don't > fork a core library to do so. Not just the commit info. The plan is to print core/cluster info also from this peim. As I have already stated in PATCH 10/28, that some print informa= tion would be put into common code instead of SOC specific code. In fact the further plan is to fixup device tree in this library before DXE= phase starts. So, this fork is needed. >=20 > First of all, please do like most other platforms and override > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString > if -D FIRMWARE_VER is specified on your build command line. >=20 > You can then extract current top commits of your respective > repositories and not worry about getting this. > I would suggest iterating across all locations in PACKAGES_PATH and > then doing something similar to > https://git.linaro.org/uefi/uefi-tools.git/tree/edk2-build.sh#n400 > appending together. >=20 OK, I can use this for printing git commit info. > If something like this should be integrated into the build system > (which might not be a bad idea), then it needs to be so properly, > rather than shoehorned in for each platform. I agree. Actually IMO, best place would be python script to do this. I don't have much experience with python script. That is why I made changes in shell script. > (In the past, this was difficult because we supported both git and > svn, but I would say we have given up pretending that is possible.) >=20 > For now, you could add the printout in a standalone Depex TRUE PEIM > added to your [FV.FVMAIN_COMPACT]. As I said, that version print is just one of the many things that we wish t= o do in platform PEIM. >=20 > / > Leif >=20 > On Mon, Apr 06, 2020 at 14:53:02 +0000, Pankaj Bansal (OSS) wrote: