From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.87]) by mx.groups.io with SMTP id smtpd.web12.6054.1585650231608064752 for ; Tue, 31 Mar 2020 03:23:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=F/EgxiJh; spf=pass (domain: oss.nxp.com, ip: 40.107.6.87, mailfrom: pankaj.bansal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gz+4iqHpX8X+oV8sC4ewei36kgvwF2L6gZI57yRG20AlwFJtCbyUkE6n1m/0mKWKLYZM06kMpccY5JE3xI/0qkrKjSZty/DUs6lIZrgv9Mrt5ounbbrok6dGNYRzPI9S74crVHRms1TFF6zeBYWIjrB9ulmu3IyO49a0CX0hqOzQsqyPk+GMaJYY74bo5vbBTV9qSF2MjYnbQ2EhUBvrLbP5sjIAMO8x+VFrV9gPB+7KtKrwYUhpDoMgRObZ9ar6pwO8gTylRtWdw4ZDD2h8IXUuMPWtVud7VjuISaNrp8HPtm/Uo8El2ebP2LYRxv5UBntdGPbbJ8Fi46+2FM/P6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s4h41EAhAffn00HKmLiSjHv3Q7hbmXeDXJHFnrGtJ5c=; b=mAWESS7vIf2IRydYyKYAvpekq+9sAJvbWojIOeTdBxoT2zAXVdwMzyCFCRipldyHIzZdSQyU8mCXP7nmvh0HSQSPJNw2C2NeVXaNuR437KQirMfifWEbbwbrUoLM0jv/w1ncNobPGEm0etjR/JaXX3KjpLtBRr+SwMLAPA1IWIOGTqg6vnr7pQJnaUWzNNSzQAo1det+4J7RPi4O5H3oh0FH33SNB36FWnCYcyLUh0tyuw/KhzCGSMhsx5LDiMz6IZwrvVoGwMUpD1E11k39lacjwS9ANZo7UMq1CZn5aUTqMc6X7DFoJYjz1Hz4XVststDS1epxyIMVZZ0KyP5xyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s4h41EAhAffn00HKmLiSjHv3Q7hbmXeDXJHFnrGtJ5c=; b=F/EgxiJheL9nl3bDJGIEMPHd3Rx0niveYO3h3p/+wVgAklt5Rv0gZQGkZISBP5iKm90fA02nQ3kcaDSRFKqcYKa61zCxTHxEgday4NIpMarhskduve+y0eRArXvYt/NNSlNs/1gxL0xQTwhLipO7e2JCfhkuHfKhvIIW6dc0daM= Received: from VI1PR04MB5933.eurprd04.prod.outlook.com (20.178.205.16) by VI1PR04MB6191.eurprd04.prod.outlook.com (20.179.26.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Tue, 31 Mar 2020 10:23:48 +0000 Received: from VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::e581:c145:2f3c:fa18]) by VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::e581:c145:2f3c:fa18%6]) with mapi id 15.20.2856.019; Tue, 31 Mar 2020 10:23:48 +0000 From: "Pankaj Bansal" To: Leif Lindholm , "Pankaj Bansal (OSS)" CC: Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 28/28] Platform/NXP/LS1043aRdbPkg: Add PEI Phase Thread-Topic: [PATCH v2 28/28] Platform/NXP/LS1043aRdbPkg: Add PEI Phase Thread-Index: AQHWB0Z3Eq36UO1nRUaqHXP9em8VRQ== Date: Tue, 31 Mar 2020 10:23:48 +0000 Message-ID: References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-29-pankaj.bansal@oss.nxp.com> <20200330121859.GA7543@vanye> In-Reply-To: <20200330121859.GA7543@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=pankaj.bansal@oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [49.36.131.169] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f73dfcaf-bd4c-497b-f5ee-08d7d55d99ad x-ms-traffictypediagnostic: VI1PR04MB6191:|VI1PR04MB6191: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0359162B6D x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5933.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(346002)(376002)(39860400002)(366004)(136003)(396003)(186003)(26005)(52536014)(30864003)(6506007)(86362001)(7696005)(478600001)(53546011)(71200400001)(2906002)(5660300002)(81156014)(66476007)(66946007)(316002)(54906003)(19627235002)(33656002)(4326008)(8676002)(55016002)(66556008)(76116006)(8936002)(9686003)(64756008)(66446008)(110136005)(81166006);DIR:OUT;SFP:1101; received-spf: None (protection.outlook.com: oss.nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7Nh7ewxlxJy3b2JdxcG8jZGDakOsrTqORdlsQx8PLgPDyZ0baGmHC+wo4Ho37dDpbMwyJnX6SZiMciVlHdFbK14JoAkBB1Rd2GCEKmsy4zRnSytG2N0vlBO+SrYvWtaP9ZOw5uDg5aIRUMmh5d7V0kckdqPPmIReYIgglVds4B7pixBZXbO+E24y+rR9NJCt2bPVwIaobrmkwU+KT8yDHLBs1fqwcvd8pELRVb5zd9+pY4V6I5jgFOyJeWOozPO6iKYZi1XP2tFRvrTKsGdLPNwXcAD1mtjG1APw0BuCmq4EouvmETQdWglhS1o1FPCDnx8AvUSe72UyFWxRbz6MkaJoLwHxRf0g0nRqfSKF9rR1lwIn91ckHRpgE2oTwYzx/EdUYM3DS0T/8s9grwOzNHvuVjH0N2CSOrutiAI82Sv21JbN3b/y+1DbH4iip/3Q x-ms-exchange-antispam-messagedata: IuuuKwJMD/ApelOAr1vnqUYtZPhwCl8+aTqDGqMdp9m4o57tjQBAS5S2w2gF6+uymb+aFr0EmnHnscSwoArPlJ0SISlU5rxRc8fLlPU82t1Aek2wzos0nbySSnJWSFwOFumEtwyK2NTTh8NHYCm5pQ== MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f73dfcaf-bd4c-497b-f5ee-08d7d55d99ad X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2020 10:23:48.1135 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oExZNlke9ZGIfYH/NLAO/GD2iKzVgNiV4ny8URjaDqCtfwGbSDeAgv1mwDDcsi2SGUqG9qeJhVaeNv6ixUNIJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6191 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm > Sent: Monday, March 30, 2020 5:49 PM > To: Pankaj Bansal (OSS) > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; devel@edk2.groups.io; Varun Sethi > ; Samer El-Haj-Mahmoud Mahmoud@arm.com>; Jon Nettleton > Subject: Re: [PATCH v2 28/28] Platform/NXP/LS1043aRdbPkg: Add PEI Phase >=20 > On Fri, Mar 20, 2020 at 20:05:43 +0530, Pankaj Bansal wrote: > > From: Pankaj Bansal > > > > Add PEI phase to LS1043aRdb. This is needed becuase we need to have > > dynamic PCDs support to be able to reserve memory before reporting > > memory to UEFI fimrware. > > > > Signed-off-by: Pankaj Bansal > > --- > > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 9 --- > > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 18 +++-- > > .../MemoryInitPeiLib/MemoryInitPeiLib.c | 77 ++++++++++--------- > > .../MemoryInitPeiLib/MemoryInitPeiLib.inf | 3 +- > > Silicon/NXP/NxpQoriqLs.dsc.inc | 59 ++++++++++---- > > 5 files changed, 99 insertions(+), 67 deletions(-) > > > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > > index d486c9b36fab..d45fd67c03b5 100644 > > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > > @@ -30,15 +30,6 @@ [LibraryClasses.common] > > RealTimeClockLib|Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.inf > > > > [PcdsFixedAtBuild.common] > > - > > - # > > - # LS1043a board Specific PCDs > > - # XX (DRAM - Region 1 2GB) > > - # (NOR - IFC Region 1 512MB) > > - gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000 > > - gArmTokenSpaceGuid.PcdSystemMemorySize|0x7BE00000 > > - > gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x02000000 > > - > > # > > # RTC Pcds > > # > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > > index 99fbc87e1200..931d0bb14f9b 100644 > > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > > @@ -24,10 +24,10 @@ > > > > [FD.LS1043ARDB_EFI] > > BaseAddress =3D 0x82000000|gArmTokenSpaceGuid.PcdFdBaseAddress #The > base address of the FLASH Device. > > -Size =3D 0x000ED000|gArmTokenSpaceGuid.PcdFdSize #The= size in > bytes of the FLASH Device > > +Size =3D 0x00140000|gArmTokenSpaceGuid.PcdFdSize #The= size in > bytes of the FLASH Device > > ErasePolarity =3D 1 > > -BlockSize =3D 0x1 > > -NumBlocks =3D 0xED000 > > +BlockSize =3D 0x40000 > > +NumBlocks =3D 0x5 > > > > > ################################################################# > ############### > > # > > @@ -44,7 +44,7 @@ [FD.LS1043ARDB_EFI] > > # RegionType > > # > > > ################################################################# > ############### > > -0x00000000|0x000ED000 > > +0x00000000|0x00140000 > > gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > > FV =3D FVMAIN_COMPACT > > > > @@ -159,7 +159,15 @@ [FV.FVMAIN_COMPACT] > > READ_LOCK_CAP =3D TRUE > > READ_LOCK_STATUS =3D TRUE > > > > - INF ArmPlatformPkg/PrePi/PeiUniCore.inf > > + INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf > > + INF MdeModulePkg/Core/Pei/PeiMain.inf > > + INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf > > + INF > MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf > > + INF MdeModulePkg/Universal/Variable/Pei/VariablePei.inf > > + INF ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf > > + INF ArmPkg/Drivers/CpuPei/CpuPei.inf > > + INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf > > + INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf > > > > FILE FV_IMAGE =3D 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 { > > SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF > PROCESSING_REQUIRED =3D TRUE { > > diff --git a/Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.c > b/Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.c > > index 54d026ef1270..7fdf9cb77a6e 100644 > > --- a/Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.c > > +++ b/Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.c > > @@ -46,30 +46,12 @@ InitMmu ( > > } > > } > > > > -/*++ > > - > > -Routine Description: > > - > > - > > - > > -Arguments: > > - > > - FileHandle - Handle of the file being invoked. > > - PeiServices - Describes the list of possible PEI Services. > > - > > -Returns: > > - > > - Status - EFI_SUCCESS if the boot mode could be set > > - > > ---*/ >=20 > The above line caused me an unexpected level of excitement this > morning, as my "put back the CRs SMTP strips out" script treated the > --- as a diff separator. >=20 > Now, I *have* seen the use of /*++ --*/ elsewhere in the tree, but > this syntax is *not* described in the coding style and should not be > used. While this is a delete statement, there is an addition below > using the same format. The doxygen tags to use are /** and **/. >=20 > Fortunately, I can't spot any of these in the rest of the set. >=20 > Please send an updated version of this patch - alone if it's the only > patch that needs changes, or with a v4 if such is required. I have not received any comments on other patches so far. Does that mean all patches are OK (except above)? If that is the case, then I can send only this patch after update. If some rework is needed for other patches as well, I will send this patch = along with other reworked patches in v3. >=20 > > EFI_STATUS > > EFIAPI > > -MemoryPeim ( > > - IN EFI_PHYSICAL_ADDRESS UefiMemoryBase, > > - IN UINT64 UefiMemorySize > > +MemoryInitPeiLibConstructor ( > > + VOID > > ) > > { > > - ARM_MEMORY_REGION_DESCRIPTOR *MemoryTable; > > ARM_SMC_ARGS ArmSmcArgs; > > INT32 Index; > > UINTN DramSize; > > @@ -82,18 +64,6 @@ MemoryPeim ( > > UINTN FdTop; > > BOOLEAN FoundSystemMem; > > > > - // Get Virtual Memory Map from the Platform Library > > - ArmPlatformGetVirtualMemoryMap (&MemoryTable); > > - > > - // > > - // Ensure MemoryTable[0].Length which is size of DRAM has been set > > - // by ArmPlatformGetVirtualMemoryMap () > > - // > > - ASSERT (MemoryTable[0].Length !=3D 0); > > - > > - // > > - // Now, the permanent memory has been installed, we can call > AllocatePages() > > - // > > ResourceAttributes =3D ( > > EFI_RESOURCE_ATTRIBUTE_PRESENT | > > EFI_RESOURCE_ATTRIBUTE_INITIALIZED | > > @@ -133,8 +103,8 @@ MemoryPeim ( > > > > ASSERT (!DramSize); > > > > - FdBase =3D (UINTN)FixedPcdGet64 (PcdFdBaseAddress); > > - FdTop =3D FdBase + (UINTN)FixedPcdGet32 (PcdFdSize); > > + FdBase =3D (UINTN)PcdGet64 (PcdFdBaseAddress); > > + FdTop =3D FdBase + (UINTN)PcdGet32 (PcdFdSize); > > > > // Declare memory regios to system > > for (Index =3D MAX_DRAM_REGIONS - 1; Index >=3D 0; Index--) { > > @@ -178,8 +148,8 @@ MemoryPeim ( > > ); > > }; > > // Mark the memory covering the Firmware Device as boot services= data > > - BuildMemoryAllocationHob (FixedPcdGet64 (PcdFdBaseAddress), > > - FixedPcdGet32 (PcdFdSize), > > + BuildMemoryAllocationHob (PcdGet64 (PcdFdBaseAddress), > > + PcdGet32 (PcdFdSize), > > EfiBootServicesData); > > } else { > > BuildResourceDescriptorHob ( > > @@ -199,16 +169,49 @@ MemoryPeim ( > > Top =3D DramRegions[Index].BaseAddress + DramRegions[Index].Size; > > > > if (FdBase >=3D BaseAddress && FdTop <=3D Top) { > > - Size -=3D (UINTN)FixedPcdGet32 (PcdFdSize); > > + Size -=3D (UINTN)PcdGet32 (PcdFdSize); > > } > > > > if (Size >=3D FixedPcdGet32 (PcdSystemMemoryUefiRegionSize)) { > > FoundSystemMem =3D TRUE; > > + PcdSet64S (PcdSystemMemoryBase, BaseAddress); > > + PcdSet64S (PcdSystemMemorySize, Size); > > } > > } > > > > ASSERT (FoundSystemMem); > > > > + return EFI_SUCCESS; > > +} > > + > > +/*++ >=20 > Here is the incorrect addition. >=20 > (I'm not reviewing the set backwards, this was just the only patch > that wouldn't apply cleanly after conversion.) >=20 > / > Leif >=20 > > + > > +Routine Description: > > + > > + > > + > > +Arguments: > > + > > + FileHandle - Handle of the file being invoked. > > + PeiServices - Describes the list of possible PEI Services. > > + > > +Returns: > > + > > + Status - EFI_SUCCESS if the boot mode could be set > > + > > +--*/ > > +EFI_STATUS > > +EFIAPI > > +MemoryPeim ( > > + IN EFI_PHYSICAL_ADDRESS UefiMemoryBase, > > + IN UINT64 UefiMemorySize > > + ) > > +{ > > + ARM_MEMORY_REGION_DESCRIPTOR *MemoryTable; > > + > > + // Get Virtual Memory Map from the Platform Library > > + ArmPlatformGetVirtualMemoryMap (&MemoryTable); > > + > > // Build Memory Allocation Hob > > InitMmu (MemoryTable); > > > > diff --git a/Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf > b/Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf > > index ad2371115b17..a33f8cd3f743 100644 > > --- a/Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf > > +++ b/Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf > > @@ -13,7 +13,8 @@ [Defines] > > FILE_GUID =3D 55ddb6e0-70b5-11e0-b33e-0002a5d5c= 51b > > MODULE_TYPE =3D BASE > > VERSION_STRING =3D 1.0 > > - LIBRARY_CLASS =3D MemoryInitPeiLib|SEC PEIM DXE_DRI= VER > > + LIBRARY_CLASS =3D MemoryInitPeiLib|PEIM > > + CONSTRUCTOR =3D MemoryInitPeiLibConstructor > > > > [Sources] > > MemoryInitPeiLib.c > > diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.ds= c.inc > > index b2b10ce28a93..a3f18abb37b1 100644 > > --- a/Silicon/NXP/NxpQoriqLs.dsc.inc > > +++ b/Silicon/NXP/NxpQoriqLs.dsc.inc > > @@ -93,6 +93,7 @@ [LibraryClasses.common] > > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > > NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverabl > eDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > > > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeRep > ortStatusCodeLib.inf > > + > UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecomp > ressLib.inf > > > > I2cLib|Silicon/NXP/Library/I2cLib/I2cLib.inf > > > ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetS > ystemLib.inf > > @@ -106,20 +107,24 @@ [LibraryClasses.common] > > > > [LibraryClasses.common.SEC] > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > - > UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecomp > ressLib.inf > > - > ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/= P > rePiExtractGuidedSectionLib.inf > > - > LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/Lzma > CustomDecompressLib.inf > > - PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > > - HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf > > - > PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PreP= iH > obListPointerLib.inf > > - > MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiM > emoryAllocationLib.inf > > + > DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymb > olsBaseLib.inf > > + HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > > + PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > > + > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLib/PeiS= ervi > cesTablePointerLib.inf > > + > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllo > cationLib.inf > > + > > +[LibraryClasses.common.PEI_CORE] > > + PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf > > + HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > > + PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > > + > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllo > cationLib.inf > > + > PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf > > > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib > .inf > > + > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtr= ac > tGuidedSectionLib.inf > > + > ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiRepo > rtStatusCodeLib.inf > > + > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/ > OemHookStatusCodeLibNull.inf > > > > - # 1/123 faster than Stm or Vstm version > > - BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > > - > > - # Uncomment to turn on GDB stub in SEC. > > - > #DebugAgentLib|EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.inf > > + > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLib/PeiS= ervi > cesTablePointerLib.inf > > > > [LibraryClasses.common.PEIM] > > PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf > > @@ -128,14 +133,16 @@ [LibraryClasses.common.PEIM] > > > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLib/PeiS= ervi > cesTablePointerLib.inf > > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > > > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllo > cationLib.inf > > + > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib > .inf > > + > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtr= ac > tGuidedSectionLib.inf > > > ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiRepo > rtStatusCodeLib.inf > > + > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/ > OemHookStatusCodeLibNull.inf > > > > [LibraryClasses.common.DXE_CORE] > > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf > > > MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/D > xeCoreMemoryAllocationLib.inf > > > DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf > > > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtr= a > ctGuidedSectionLib.inf > > - > UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecomp > ressLib.inf > > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > > > PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerf > ormanceLib.inf > > > > @@ -207,6 +214,9 @@ [PcdsDynamicDefault.common] > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoHorizontalResolution|640 > > gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoVerticalResolution|480 > > > > + gArmTokenSpaceGuid.PcdSystemMemoryBase|0 > > + gArmTokenSpaceGuid.PcdSystemMemorySize|0 > > + > > [PcdsDynamicHii.common.DEFAULT] > > > gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|L"Timeout"|gEfiGlobalV > ariableGuid|0x0|10 > > > > @@ -227,6 +237,12 @@ [PcdsFixedAtBuild.common] > > gEfiMdePkgTokenSpaceGuid.PcdPostCodePropertyMask|0 > > gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|320 > > > > + ## Base of DRAM > > + ## since TFA puts Fd at 0x2000000 offset from DRAM base, we can use = this > space > > + ## for temporary ram > > + gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0x80000000 > > + > gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x02000000 > > + > > !if $(TARGET) =3D=3D RELEASE > > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x27 > > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x81000001 > > @@ -284,13 +300,26 @@ [PcdsFixedAtBuild.common] > > > ################################################################# > ############### > > [Components.common] > > # > > - # SEC > > + # PEI Phase modules > > # > > - ArmPlatformPkg/PrePi/PeiUniCore.inf > > + ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf > > + > > + MdeModulePkg/Core/Pei/PeiMain.inf > > MdeModulePkg/Universal/PCD/Pei/Pcd.inf { > > > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > } > > + MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.i= nf > > + MdeModulePkg/Universal/Variable/Pei/VariablePei.inf > > + > > + ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf > > + ArmPkg/Drivers/CpuPei/CpuPei.inf > > + ArmPlatformPkg/PlatformPei/PlatformPeim.inf > > + > > + MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf { > > + > > + > NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecom > pressLib.inf > > + } > > > > # > > # DXE > > -- > > 2.17.1 > >