From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.79]) by mx.groups.io with SMTP id smtpd.web11.13233.1586186809128627684 for ; Mon, 06 Apr 2020 08:26:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=RgjBMW3a; spf=pass (domain: oss.nxp.com, ip: 40.107.22.79, mailfrom: pankaj.bansal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MzEXUNWJgEvBvFR3ODb9ef0xVeuUZWwMDE0N4bxEVkqE1HPhLL8r+rtIxnSc2ZIKtUvAHqowv66D5nBuR0UhPtuVxtP17wzOXPNwJMh1RVqvLL5NCZzoqOCQKQFfto179+y7nRZs06zCOn9euBeZKZUsa6gZeZd5oqzoYVFTzw/jyBEUBkwFDFcgmohI0yq+iiKaxBhaGajdRoYDZnGMqoluIs9oddBffqTH+OMv2FUYZdtroK3M7Qgc2leCxsX206DAi27l6Wq3Yis0cHN3skFOwVu7NLBBhjnYvXq6UhUR0S313hookvmyDt3qYkgXDFtAfNXrgQGvkHMfF8Dm6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G4xgMYyn5xHMEgDFSNowhsVCev8MyXLTxC2F9tfsOtk=; b=Tt3BljfBMExicRwxuH+uawu+7eEIPH4PYNts8mHV+EydWoD3ibyy6AZ4FPqIxT3RJIMkaG99+1Mv1Pl5sgBx0jt299HXMjIcUqlQsgRQl+jcAwKa0OExGmLmtemUl9lL8CEJU8rXuZNaHprUXLKftbKj5ojL1gdROjq1OpwpttGZGHSK4TumubMocs9ABFqqt+iotOmP5rlSB0HfSIE4cLBk89DhIVwh1RqrAG1F+1guZl5LAdj3SG0n+FJ4FjdbZQdYpDia3FfQSU2W9GmrQASi3qW4lHp+Qyd0ehoODxIZggMXEVUwiizHxTbhhcmASm05G61bZ6h/YRrxQL3AFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G4xgMYyn5xHMEgDFSNowhsVCev8MyXLTxC2F9tfsOtk=; b=RgjBMW3axp1nr3wijABG+oPA6K8IroutGxg9xvj/N2YyVGurOhScxJWgajApgTVlc0kSjeLpee2GVMD6urUZGgnq6tBevuBySf0Tg6055w4jKbycBMOVhff4XmM8DVe9p1KXHB3IS1Psr07i9wpfS/YDfKKw9xGPDNJLYB8tPhM= Received: from VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) by VI1PR04MB4637.eurprd04.prod.outlook.com (2603:10a6:803:70::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15; Mon, 6 Apr 2020 15:26:45 +0000 Received: from VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::e581:c145:2f3c:fa18]) by VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::e581:c145:2f3c:fa18%6]) with mapi id 15.20.2878.018; Mon, 6 Apr 2020 15:26:45 +0000 From: "Pankaj Bansal" To: Leif Lindholm , "Pankaj Bansal (OSS)" CC: Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 23/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Use Allocate pool Thread-Topic: [PATCH v2 23/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Use Allocate pool Thread-Index: AQHWDCfHCRwaeCKYfkulDLKdtRbXkA== Date: Mon, 6 Apr 2020 15:26:45 +0000 Message-ID: References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-24-pankaj.bansal@oss.nxp.com> <20200401180337.GF7468@vanye> In-Reply-To: <20200401180337.GF7468@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=pankaj.bansal@oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [49.36.135.41] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b3822f1b-f514-460a-1b39-08d7da3eeaa2 x-ms-traffictypediagnostic: VI1PR04MB4637:|VI1PR04MB4637: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0365C0E14B x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5933.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(366004)(136003)(396003)(39860400002)(376002)(346002)(64756008)(6506007)(76116006)(54906003)(55016002)(52536014)(66446008)(33656002)(66946007)(9686003)(66556008)(110136005)(7696005)(4326008)(316002)(53546011)(66476007)(478600001)(81156014)(2906002)(5660300002)(71200400001)(81166006)(8676002)(26005)(186003)(8936002)(86362001);DIR:OUT;SFP:1101; received-spf: None (protection.outlook.com: oss.nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ga3CXrMCGxAxOQd7U80DYOUrchpyvtWyrzExjAmzEPf8s96PYA/pf9Egp9n391wRFKLy4N76zqTPKELZPEGQtlx9CZi1EZZ9wZ/Y7uU08FpPPI5q8JXVGX2Q+tqzxQ2M585uOuyvV3VLhKxWTkzTKJjCUKI2HhK1Sd6SIkr5POjsnub6H9+ToQ9O5b0+TQWCNwq2sq6b9ifU2flu5JW53xZpjZpWlsxXax+Cefg14qXQOdMZg+49zB5BQ3sFYsIwiMNnAx9IturnI/s3xJFdyRphiwxHzCm014F/WctDQOi2bENEaEyAvuUg/+fc7vXPQrN9r09KgSFvznfOdKnftOr3XB7BWkEiyJ8thmhLppFkzKqtwANyHKSOgO+Ug2INtV6h5J8r+ks9C1M9+5MwBqrePuy/9ZB8mKkiRw6ivFSnWcRSU0VGzDr70YwVqh5N x-ms-exchange-antispam-messagedata: OvIBH4U9nzJZ9Y5jZ11ylolFwMMAC30orVtqgrtqQOwyFnNJ4OqCG4NBZ76h3Vhv9xpYl5FvrAwrbcjf0qf6igCc6rdlyvYueZeGI8gmyKgqLCqRWiJfjBaWxGzJ8P0kSmme4YSan9iVOkv66z1ktg== MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3822f1b-f514-460a-1b39-08d7da3eeaa2 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2020 15:26:45.3635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zormcC4zgKDuJfINHsS7/fEFMNQZONAOBeWRkoWldgt2qKJ6TiKfzJob/hl4al69A4EwA7RmoG1qylMZRja6iw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4637 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm > Sent: Wednesday, April 1, 2020 11:34 PM > To: Pankaj Bansal (OSS) > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; devel@edk2.groups.io; Varun Sethi > ; Samer El-Haj-Mahmoud Mahmoud@arm.com>; Jon Nettleton > Subject: Re: [PATCH v2 23/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Use > Allocate pool >=20 > On Fri, Mar 20, 2020 at 20:05:38 +0530, Pankaj Bansal wrote: > > From: Pankaj Bansal > > > > Allocate Pages may allocate more memory than required for > > VirtualMemoryTable. > > There is no special requirement that VirtualMemoryTable size should be > > page size aligned. > > > > Therefore, replace AllocatePages with AllocatePool. > > > > Signed-off-by: Pankaj Bansal >=20 > I don't object to this as such (although one comment), but what is the > purpose of this change? >=20 > My comment is that most other platforms use AllocatePages for this. So > this is diverging from the norm.=20 I referred ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c > Secondly, while I don't necessarily > *like* the current design (copied across most ARM platforms), it's > somewhat mitigated by the AllocatePages giving you a minimum of 128 > entries before you start overwriting things. I don't know what you'll > overwrite if you do go too far, but you will overwrite it *before* the > ASSERT ever gets evaluated. >=20 We can improve this by evaluating ASSERT after each entry like this : VirtualMemoryTable[Index].PhysicalBase =3D 0xXXXXXXXX; VirtualMemoryTable[Index].VirtualBase =3D 0xXXXXXXXX; VirtualMemoryTable[Index].Length =3D 0xXXXXXXXX; VirtualMemoryTable[Index++].Attributes =3D 0xXXXXXXXX; ASSERT (Index < MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS); > / > Leif >=20 > > --- > > .../LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf | 1 + > > .../LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem.c | 5 +++-- > > 2 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git > a/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > index 1faf99b99c54..c64032f32772 100644 > > --- > a/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > +++ > b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > @@ -25,6 +25,7 @@ [Packages] > > > > [LibraryClasses] > > ArmLib > > + DebugLib > > SocLib > > > > [Sources.common] > > diff --git > a/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem. > c > b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem. > c > > index f5fa308551aa..f8dd642e3cff 100644 > > --- > a/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem. > c > > +++ > b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem. > c > > @@ -43,10 +43,11 @@ ArmPlatformGetVirtualMemoryMap ( > > > > ASSERT (VirtualMemoryMap !=3D NULL); > > > > - VirtualMemoryTable =3D > (ARM_MEMORY_REGION_DESCRIPTOR*)AllocatePages ( > > - EFI_SIZE_TO_PAGES (sizeof (ARM_MEMORY_REGION_DESCRIPTOR) * > MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS)); > > + VirtualMemoryTable =3D AllocatePool (sizeof > (ARM_MEMORY_REGION_DESCRIPTOR) * > > + MAX_VIRTUAL_MEMORY_MAP_DESCRIPTOR= S); > > > > if (VirtualMemoryTable =3D=3D NULL) { > > + DEBUG ((DEBUG_ERROR, "%a: Error: Failed AllocatePool()\n", > __FUNCTION__)); > > return; > > } > > > > -- > > 2.17.1 > >