From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.5.74; helo=eur03-ve1-obe.outbound.protection.outlook.com; envelope-from=alexei.fedorov@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50074.outbound.protection.outlook.com [40.107.5.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F2EA420837969 for ; Thu, 10 May 2018 02:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2G7VDQ+/C09EoJcDAkxU0yc0+uRytSv2e3LowcH7eFk=; b=K2cmgrp7m/Yew0dqan7ZuUFzMB6cgZDZWBTGT6WSctuSlSafbDdzAE5Z6Rf+xUZH6321wemHp20YdZtYbvCQO3ajFxPqBnDioLuSpfadOgQxeaKWuuP/WlC/RZ/JNlVJQeiAj7RepJ3XnOAYXLxsjGz/p2YSG2b5iZyTnD2EcZQ= Received: from VI1PR0801MB1773.eurprd08.prod.outlook.com (10.168.67.138) by VI1PR0801MB1502.eurprd08.prod.outlook.com (10.167.210.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.17; Thu, 10 May 2018 09:56:01 +0000 Received: from VI1PR0801MB1773.eurprd08.prod.outlook.com ([fe80::599a:cb66:1864:4ee3]) by VI1PR0801MB1773.eurprd08.prod.outlook.com ([fe80::599a:cb66:1864:4ee3%18]) with mapi id 15.20.0735.016; Thu, 10 May 2018 09:56:00 +0000 From: Alexei Fedorov To: Leif Lindholm CC: "edk2-devel@lists.01.org" , Arvind Chauhan , Daniil Egranov , "Thomas Abraham" , "Ard.Biesheuvel@linaro.org" , Matteo Carlini , Stephanie Hughes-Fitt , nd , "Evan Lloyd" , Sami Mujawar Thread-Topic: [PATCH edk2-platforms v1] Platform/ARM: Add PeiReportStatusCodeLib Thread-Index: AQHT57I0s1OLNJhD+Eaw3MVoOy9WN6QnnUPLgABIiACAANStvA== Date: Thu, 10 May 2018 09:56:00 +0000 Message-ID: References: <1525339461-12432-1-git-send-email-alexei.fedorov@arm.com> <20180509162423.qt45fahwk7skl6hk@bivouac.eciton.net> , <20180509211336.jnwec2hpnnkh2bu3@bivouac.eciton.net> In-Reply-To: <20180509211336.jnwec2hpnnkh2bu3@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0801MB1502; 7:194MmKXQ/y1RDYjIvkrxY4yTz3WZZ+Zh/a3BICPSw5N7LdOb9PYym1hxc8gYFJtvEfHgOcJHW/SmWDsXJ/5jwzsRjpHBXwDcSqnd8Gj/Xq4Ek8jICYd5Vc4T8M/mhawJ37iOKVL9qWUI+UaOk+di8wmhQoXjn8Y7DcgFhgFGA55E24/NG+LUd52pi0kphYCKCxFIhFbDUigm+yrKHV5cw14YeoAf8F5GHYUB23O7qSSm0zis3NPYJ/Tk7Q0EuxDl x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0801MB1502; x-ms-traffictypediagnostic: VI1PR0801MB1502: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexei.Fedorov@arm.com; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(166708455590820)(162533806227266); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(6072148)(201708071742011); SRVR:VI1PR0801MB1502; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0801MB1502; x-forefront-prvs: 066898046A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(366004)(396003)(39380400002)(346002)(199004)(189003)(53546011)(6506007)(93886005)(3280700002)(6246003)(53936002)(81156014)(6436002)(99286004)(54896002)(55016002)(236005)(6306002)(102836004)(229853002)(8936002)(4326008)(26005)(3660700001)(25786009)(606006)(7736002)(19627405001)(81166006)(186003)(105586002)(106356001)(8676002)(33656002)(59450400001)(966005)(2906002)(9686003)(76176011)(6606003)(72206003)(97736004)(14454004)(5660300001)(316002)(5250100002)(575784001)(68736007)(74316002)(7696005)(478600001)(476003)(66066001)(11346002)(86362001)(2900100001)(6916009)(3846002)(446003)(486006)(6116002)(54906003)(213903007)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0801MB1502; H:VI1PR0801MB1773.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 3M1fMlWM+isdnZwtWTlcJbIg1IbZSYE+tpeIVxv5KLQZN9nZYE+bCZ+4cbsx1YVWbuVTdF401ijcGwx/Sq2R+WaKzz+QylDvBLvCLjdmgy76payCM+JLJvK7xl47bo289Xy6PBSdNL/gbQSA/LX3TWVUNV98grSX6NQrW3s5hm3HtJiHwJxu4nAaOa7ZNC0r spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 149ce911-1a42-4ebc-7d78-08d5b65c3c63 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 149ce911-1a42-4ebc-7d78-08d5b65c3c63 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2018 09:56:00.5599 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1502 X-Content-Filtered-By: Mailman/MimeDel 2.1.26 Subject: Re: [PATCH edk2-platforms v1] Platform/ARM: Add PeiReportStatusCodeLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 09:56:05 -0000 Content-Language: en-GB Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, >Could you fold that into the patch and update the subject line to something like "fix FVP build with -D ARM_FVP_RUN_NORFLASH"? Yes, I'll provide a new patch. Alexei ________________________________ From: Leif Lindholm Sent: 09 May 2018 22:13:36 To: Alexei Fedorov Cc: edk2-devel@lists.01.org; Arvind Chauhan; Daniil Egranov; Thomas Abraham= ; Ard.Biesheuvel@linaro.org; Matteo Carlini; Stephanie Hughes-Fitt; nd; Eva= n Lloyd; Sami Mujawar Subject: Re: [PATCH edk2-platforms v1] Platform/ARM: Add PeiReportStatusCod= eLib On Wed, May 09, 2018 at 04:58:52PM +0000, Alexei Fedorov wrote: > Hi Leif, > > You wrote: > > Yes, this fixes a bug, however I am still unable to build FVP with > > -D ARM_FVP_RUN_NORFLASH: > > --- > > In file included from > > /work/git/edk2-platforms/Platform/ARM/VExpressPkg/Library/ArmVExpressLi= bRTSM/RTSM.c:22:0: > > /work/git/edk2-platforms/Platform/ARM/VExpressPkg/Include/Platform/RTSM= /ArmPlatform.h:19:33: > > fatal error: VExpressMotherBoard.h: No such file or directory > > #include > > ^ > > compilation terminated. > > --- > > > > Presumably this has been broken since commit 8ad58788b5c did not carry = across > > -I$(WORKSPACE)/ArmPlatformPkg/ArmVExpressPkg/Include in > > GCC:*_*_AARCH64_PLATFORM_FLAGS when migrating ArmVExpressPkg from edk2. > > > > Can you confirm whether you can reproduce this?" > > > > Yes, & it was fixed it by adding > > -I$(WORKSPACE)/Platform/ARM/VExpressPkg/Include > > in GCC:*_*_AARCH64_PLATFORM_FLAGS of ArmVExpress-FVP-AArch64.dsc: > > GCC:*_*_AARCH64_PLATFORM_FLAGS =3D=3D -I$(WORKSPACE)/Platform/ARM/VExpres= sPkg/Include -I$(WORKSPACE)/Platform/ARM/VExpressPkg/Include/Platform/RTSM I still prefer the .dec way over ading more explicit platform-specific -I flags. Could you fold that into the patch and update the subject line to something like "fix FVP build with -D ARM_FVP_RUN_NORFLASH"? Regards, Leif > > Regards. > > Alexei > > ________________________________ > From: Leif Lindholm > Sent: 09 May 2018 17:24:23 > To: Alexei Fedorov > Cc: edk2-devel@lists.01.org; Arvind Chauhan; Daniil Egranov; Thomas Abrah= am; Ard.Biesheuvel@linaro.org; Matteo Carlini; Stephanie Hughes-Fitt; nd; E= van Lloyd; Sami Mujawar > Subject: Re: [PATCH edk2-platforms v1] Platform/ARM: Add PeiReportStatusC= odeLib > > Hi Alexei, > > On Thu, May 03, 2018 at 10:24:21AM +0100, Alexei Fedorov wrote: > > From: Alexei Fedorov > > > > UEFI build fails for ArmVExpress-FVP-AArch64 when using > > "-D ARM_FVP_RUN_NORFLASH" build option, which prevents > > EDK2_SKIP_PEICORE macro from being defined in > > ArmVExpress-FVP-AArch64.dsc: > > > > !ifndef ARM_FVP_RUN_NORFLASH > > DEFINE EDK2_SKIP_PEICORE=3D1 > > !endif > > > > When EDK2_SKIP_PEICORE macro is not defined, build fails with > > errors 1001: > > Module type [PEI_CORE] is not supported by library instance > > [MdeModulePkg\Library\DxeReportStatusCodeLib\DxeReportStatusCodeLib.inf= ] > > consumed by [n:\edk2\MdeModulePkg\Core\Pei\PeiMain.inf] > > and > > Module type [PEIM] is not supported by library instance > > [MdeModulePkg\Library\DxeReportStatusCodeLib\DxeReportStatusCodeLib.inf= ] > > consumed by [n:\edk2\MdeModulePkg\Core\DxeIplPeim\DxeIpl.inf] > > > > This patch fixes the above build errors by adding > > MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf > > in [LibraryClasses.common.PEI_CORE] and [LibraryClasses.common.PEIM] > > sections of ArmVExpress.dsc.inc. > > Yes, this fixes a bug, however I am still unable to build FVP with > -D ARM_FVP_RUN_NORFLASH: > --- > In file included from > /work/git/edk2-platforms/Platform/ARM/VExpressPkg/Library/ArmVExpressLibR= TSM/RTSM.c:22:0: > /work/git/edk2-platforms/Platform/ARM/VExpressPkg/Include/Platform/RTSM/A= rmPlatform.h:19:33: > fatal error: VExpressMotherBoard.h: No such file or directory > #include > ^ > compilation terminated. > --- > > Presumably this has been broken since commit 8ad58788b5c did not carry ac= ross > -I$(WORKSPACE)/ArmPlatformPkg/ArmVExpressPkg/Include in > GCC:*_*_AARCH64_PLATFORM_FLAGS when migrating ArmVExpressPkg from edk2. > > Can you confirm whether you can reproduce this? > > If so, the following stanza resolves the issue for me: > diff --git > a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.i= nf > b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.i= nf > index 2287756cf8..ed9720e8ce 100644 > --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibS= ec.inf > +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibS= ec.inf > @@ -22,6 +22,7 @@ [Defines] > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + Platform/ARM/VExpressPkg/ArmVExpressPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > ArmPkg/ArmPkg.dec > ArmPlatformPkg/ArmPlatformPkg.dec > > Best Regards, > > Leif > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Alexei Fedorov > > Reviewed-by: Evan Lloyd > > --- > > All the changes can be reviewed at: > > https://github.com/AlexeiFedorov/edk2-platforms/tree/237_add_peireports= tatuscodelib_v1 > > > > Notes: > > v1: > > - Add PeiReportStatusCodeLib in PEI_CORE and PEIM sections [Alexe= i] > > > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/AR= M/VExpressPkg/ArmVExpress.dsc.inc > > index de201b0c81d020e1e06ee320cf0f14f186723657..bb899b91c525ee821b9506c= ca75224f4bc41e3ae 100644 > > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > @@ -166,6 +166,7 @@ [LibraryClasses.common.PEI_CORE] > > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryA= llocationLib.inf > > PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint= .inf > > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformance= Lib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiR= eportStatusCodeLib.inf > > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/O= emHookStatusCodeLibNull.inf > > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Bas= ePeCoffGetEntryPointLib.inf > > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/Pe= iExtractGuidedSectionLib.inf > > @@ -179,6 +180,7 @@ [LibraryClasses.common.PEIM] > > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryA= llocationLib.inf > > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformance= Lib.inf > > + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiR= eportStatusCodeLib.inf > > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/O= emHookStatusCodeLibNull.inf > > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Bas= ePeCoffGetEntryPointLib.inf > > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/P= eiResourcePublicationLib.inf > > -- > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > >