From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.92.64.23; helo=eur01-db5-obe.outbound.protection.outlook.com; envelope-from=marvin.haeuser@outlook.com; receiver=edk2-devel@lists.01.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064023.outbound.protection.outlook.com [40.92.64.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CC8382282E5AB for ; Sat, 5 May 2018 07:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XdWZGhch+kUNiz9UkebZPEtXtvesx1N9jV+WbVmfbxg=; b=Elfv3nLyDUHMEC1ghWPEMlVPwsARhyy7gM/3OpLVZ8n3VLdWkxbKmDhEhrQ4a+DeBGhz2JW9Sc/F4Chfr2r6KnvKESMWU4cwEkCzvNe7qLuXAT5wOPG0lt6n5rYX4C1YNpOxTfVQkxLEPT3zLWxiQ/FdlBrTY8lZJA5Mo0BZlfSoAmVC4G6UmZIUtOfgbmyPCxaAH0cNk9DEj7yrwbpurk97HrFvysCMow0nemN4+6Z29yNyGLtNpeC2+PrLl+TI5wGRCTPrr51z/S/d1BolouhfsYWt4NipOOQA/Rw+lrxhlOnDajT9CNq801TxCqgD5MbMPlNV85PA5krMZtChTw== Received: from DB5EUR01FT004.eop-EUR01.prod.protection.outlook.com (10.152.4.57) by DB5EUR01HT143.eop-EUR01.prod.protection.outlook.com (10.152.5.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.735.16; Sat, 5 May 2018 14:24:02 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com (10.152.4.53) by DB5EUR01FT004.mail.protection.outlook.com (10.152.4.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.735.16 via Frontend Transport; Sat, 5 May 2018 14:24:02 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7c79:584b:2e12:783e]) by VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7c79:584b:2e12:783e%17]) with mapi id 15.20.0715.024; Sat, 5 May 2018 14:24:02 +0000 From: =?iso-8859-1?Q?Marvin_H=E4user?= To: "edk2-devel@lists.01.org" CC: "michael.d.kinney@intel.com" , "liming.gao@intel.com" Thread-Topic: [PATCH v2 2/2] IntelFrameworkPkg/FrameworkUefiLib: Add 'OUT' decorator where necessary. Thread-Index: AQHT5HyyIOpt6i6kpki08Z5WVenNAA== Date: Sat, 5 May 2018 14:23:55 +0000 Message-ID: References: In-Reply-To: Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM0PR02CA0023.eurprd02.prod.outlook.com (2603:10a6:208:3e::36) To VI1PR0801MB1790.eurprd08.prod.outlook.com (2603:10a6:800:5b::15) x-incomingtopheadermarker: OriginalChecksum:54E97506ECEE893F52E00E2492F20A66800F46736A77D777C7277A2F882E93FB; UpperCasedChecksum:55575C97A592ABE622A635B04CCACC507E0634ABC8A112A4FD96C5A168C03292; SizeAsReceived:7733; Count:50 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [kYeUzrLGDHAYdvdJH/14oaolb7r4QgyV] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5EUR01HT143; 7:mxNZPDkw0tILz/CEK1ygWeDg6xiXNYcNzzjBIUJR170KHwMM15PcIUAKJAGVmN9hSEBqe02jNICRHFiCyDM4nMH+XdmQ94FEVJKBLm7jOlt4hPGUmEvW0W2r8rQ+ov+IONTvi6Ou4Kj7V9u2d8Id3QRYaHaHnWGJLvMuU5ZKUsajSBt1snajLs5CiF7bHnsukVV8Ojn9ipiTlSjcnllHMgKFmJXVMwVYvpY8b3eF7a/8874FfbVlne9dn7hEMqoO x-incomingheadercount: 50 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125374)(1701031045); SRVR:DB5EUR01HT143; x-ms-traffictypediagnostic: DB5EUR01HT143: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:DB5EUR01HT143; BCL:0; PCL:0; RULEID:; SRVR:DB5EUR01HT143; x-forefront-prvs: 0663390E1B x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:DB5EUR01HT143; H:VI1PR0801MB1790.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:; x-microsoft-antispam-message-info: X5kINyxI2XR8hSM0EDcPjwdG9WKd6gukLaRe8FIrWVzv6GWsXm3oOPxXdhuXzHdURHRgkANiBYMyzg1lIOUmSv2Mt56UJZYxN/bm6hxSFiw2zxjlc9eKKyvztyArDfslrfN+zdwdNVu1vnHoOhzNRisDnJZjT74EC16FFv9An6UgC9f1UhQqpR3vR2+HGAY3 MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: def90cc0-8ffe-4e41-039f-08d5b293d51f X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-Network-Message-Id: def90cc0-8ffe-4e41-039f-08d5b293d51f X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2018 14:23:55.4715 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR01HT143 Subject: [PATCH v2 2/2] IntelFrameworkPkg/FrameworkUefiLib: Add 'OUT' decorator where necessary. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2018 14:24:09 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable The functions AddUnicodeString() and AddUnicodeString2() might return a new value into their parameter UnicodeStringTable, hence add the appropiate 'OUT' decorator. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c | 19 +++++++++-------= --- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c b/IntelFr= ameworkPkg/Library/FrameworkUefiLib/UefiLib.c index 895ff39fc140..61a32e297606 100644 --- a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c +++ b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c @@ -865,11 +865,10 @@ LookupUnicodeString2 ( **/ EFI_STATUS EFIAPI -AddUnicodeString ( - IN CONST CHAR8 *Language, - IN CONST CHAR8 *SupportedLanguages, - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable, - IN CONST CHAR16 *UnicodeString + IN CONST CHAR8 *Language, + IN CONST CHAR8 *SupportedLanguages, + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable, + IN CONST CHAR16 *UnicodeString ) { UINTN NumberOfEntries; @@ -1043,11 +1042,11 @@ AddUnicodeString ( EFI_STATUS EFIAPI AddUnicodeString2 ( - IN CONST CHAR8 *Language, - IN CONST CHAR8 *SupportedLanguages, - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable, - IN CONST CHAR16 *UnicodeString, - IN BOOLEAN Iso639Language + IN CONST CHAR8 *Language, + IN CONST CHAR8 *SupportedLanguages, + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable, + IN CONST CHAR16 *UnicodeString, + IN BOOLEAN Iso639Language ) { UINTN NumberOfEntries; --=20 2.17.0.windows.1