From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a01:111:f400:fe1f::81f; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=marvin.haeuser@outlook.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01olkn081f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1f::81f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7DB6A211CBDB4 for ; Wed, 13 Jun 2018 13:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=87Hfri0nrFKT6hAgvkaj4XC79k166NlLNMevuRUzRAQ=; b=X1iwVDoIqLGVObB/p48HaHSSS6sKhUnpcRqwwlMk8XtOWtU+uXyGzlEr/OqXT634Qmx6evgNSKdHb50DR5U6uylm9HZfrkAzfKyWaooLLN8PgcOp9rPPOKDBQcf34m6sz1wG9JziuUXG3zOIA9dxgbgLmv+l4oZeOplGATPYnlQ1Sf2HGixWOEo71mxWes6jsE+oWFytCR5Zb6rFNl3+p0lcyHXwtR5fFinJ5AdjrPMdAZedEBFoh1SCraWVyMb0bXZ9DvKTa6cqfxD3C1KQ7LOHDTHmP341qBL54jBRY7k87YWe/AxuEeqYAKhiBxoPJN3AIAiq4JXS5rODeP9Bnw== Received: from VE1EUR01FT039.eop-EUR01.prod.protection.outlook.com (10.152.2.60) by VE1EUR01HT058.eop-EUR01.prod.protection.outlook.com (10.152.3.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.863.11; Wed, 13 Jun 2018 20:29:53 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com (10.152.2.55) by VE1EUR01FT039.mail.protection.outlook.com (10.152.3.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.863.11 via Frontend Transport; Wed, 13 Jun 2018 20:29:53 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::b8fa:4bfe:9d63:439c]) by VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::b8fa:4bfe:9d63:439c%2]) with mapi id 15.20.0841.019; Wed, 13 Jun 2018 20:29:53 +0000 From: =?iso-8859-1?Q?Marvin_H=E4user?= To: "edk2-devel@lists.01.org" , "ruiyu.ni@intel.com" CC: "jaben.carsey@intel.com" Thread-Topic: [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone. Thread-Index: AQHT7dyPP02JU0LAdUmmha366FmPxqQz9xxQgCrXKhA= Date: Wed, 13 Jun 2018 20:29:53 +0000 Message-ID: References: In-Reply-To: Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:E9F5973EC8FB1EF735D6F3909C6A5D76FCD9A2403084D581682C2135C4115FEE; UpperCasedChecksum:B9965E38594736B404CC5FD77D7A5C4BC8541630B2E3F2335189B90FD7BF820D; SizeAsReceived:7347; Count:46 x-tmn: [vX2dh+AH4qFhtftsit3hWsGq6W6fRTfq] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VE1EUR01HT058; 7:7pKX8ZMipsazZ66i3s2a8PV+Zyhb58fs63KeYWx/TILMK/ORlazxj0FFH5R1Y6bBnfVUwOEqIskIr8dm1Su5fdaKYhNHPB4eStFY60SYYwomrpTJI/6y3X8NwD5e5B2bOIk9MbhhTM6aOGicq3CfJvaEqxadmwWNzIxeUx8jY2wZG7jip9DksvSriXVaKs6+G/1OGRotAdLwlp2NEOMhef1qKFlpTcQsJrM2t4kR7RpeMCfaFlQIAiR8OXP+0SQs x-incomingheadercount: 46 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125500)(1701031045); SRVR:VE1EUR01HT058; x-ms-traffictypediagnostic: VE1EUR01HT058: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:VE1EUR01HT058; BCL:0; PCL:0; RULEID:; SRVR:VE1EUR01HT058; x-forefront-prvs: 07025866F6 x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(199004)(189003)(13464003)(2501003)(87572001)(53546011)(2900100001)(59450400001)(25786009)(110136005)(6346003)(6436002)(55016002)(229853002)(5660300001)(104016004)(102836004)(5250100002)(68736007)(6306002)(76176011)(20460500001)(99286004)(7696005)(105586002)(6246003)(106356001)(446003)(72206003)(486006)(97736004)(33656002)(305945005)(3660700001)(74316002)(15760500003)(11346002)(3280700002)(82202002)(8936002)(81156014)(8676002)(966005)(476003)(14454004)(86362001)(4326008)(426003)(26005)(19627235001); DIR:OUT; SFP:1901; SCL:1; SRVR:VE1EUR01HT058; H:VI1PR0801MB1790.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:; received-spf: None (protection.outlook.com: outlook.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Marvin.Haeuser@outlook.com; x-microsoft-antispam-message-info: oyIPy6s5CrRdfjRxGDZ1c9tJTXIUrY/gu/nTRcHrFL7q+bZF3NnegrK8Q3gbmiGh1eA0A0SyVIFGUpt54GibCeRlmg9s9CAS1WiknBlbFgUkHAfd1S4WEhJxGvMrg4hi/OmHtVzLvLaz13/TH4SHIX5qsEboq83Ja9sOp5ZRco3cbWOwfknwco4rGZfxSPDi MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: c284fac3-1e7d-4581-5d74-08d5d16c6b60 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-Network-Message-Id: c284fac3-1e7d-4581-5d74-08d5d16c6b60 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2018 20:29:53.0243 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR01HT058 Subject: Re: [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2018 20:30:00 -0000 Content-Language: de-DE Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Good day Ruiyu, Sorry, but you have not ack'd this V2 yet. Is there anything wrong you want= me to correct? Thanks, Marvin. > -----Original Message----- > From: Carsey, Jaben > Sent: Thursday, May 17, 2018 4:15 PM > To: Marvin H=E4user ; edk2- > devel@lists.01.org > Cc: Ni, Ruiyu > Subject: RE: [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support > unspecified local Timezone. >=20 > Still looks good to me. Ray? >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Marvin H=E4user > > Sent: Thursday, May 17, 2018 5:43 AM > > To: edk2-devel@lists.01.org > > Cc: Carsey, Jaben ; Ni, Ruiyu > > > > Subject: [edk2] [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: > > Support unspecified local Timezone. > > Importance: High > > > > EFI_RUNTIME_SERVICES.GetTime() might return an unspecified Timezone, > > such as when SetTime() has not been called after the PC-AT CMOS RTC > > was cut off power. Consider this case by not attempting Timezone > > translations for when it is invalid. > > > > V2: > > - Do not change the copyright date as requested. > > - Added R-bs from V1 as no functional changes have been made. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Marvin Haeuser > > Reviewed-by: Jaben Carsey > > Reviewed-by: Ruiyu Ni > > --- > > ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > > b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > > index 7d2e15f5206b..e502685a1dbb 100644 > > --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > > +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > > @@ -506,7 +506,7 @@ PrintLsOutput( > > // Change the file time to local time. > > // > > Status =3D gRT->GetTime(&LocalTime, NULL); > > - if (!EFI_ERROR (Status)) { > > + if (!EFI_ERROR (Status) && (LocalTime.TimeZone !=3D > > EFI_UNSPECIFIED_TIMEZONE)) { > > if ((Node->Info->CreateTime.TimeZone !=3D > > EFI_UNSPECIFIED_TIMEZONE) && > > (Node->Info->CreateTime.Month >=3D 1 && Node->Info- > > >CreateTime.Month <=3D 12)) { > > // > > -- > > 2.17.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel