From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a01:111:f400:fe1e::831; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=marvin.haeuser@outlook.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn0831.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::831]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D45AC210E2DC2 for ; Mon, 18 Jun 2018 08:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uGQUbW7OYPiBQM6KrkekGHFwjHKakPQ7t5gQkL+T4kI=; b=jhXSdGxjTyb1737bqm/Z/1tOjRD6/fr3HAGSVn+C+WKcquJ9VKO57oM0vR4V7y1Te190dE+hJ/AJ+GhaBiSo2iFELqBwlKtLxTVMLJ7vZhYQR66fmspHjsfjQKq1yRGwChsEX+urcaWZdrdGacEI6OWy2atAlDNWAwCd0pmbm+OwLSyq+WQf+M1Orwf385aeptOCZJIqsrRVg+ClNTUIeF60c9hbvOcSH53JKzDzHzNqCT57nk6Pj2Zy9yEcovyH95l4Ls3MvQxvJMlLgF16DpiFdCm+lfnVepKksOT7HDFOjFjwVRliPREq7qfWz9E2tmK0yEBqUNIwSpA2r+KtpQ== Received: from DB5EUR01FT059.eop-EUR01.prod.protection.outlook.com (10.152.4.55) by DB5EUR01HT128.eop-EUR01.prod.protection.outlook.com (10.152.5.245) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.863.11; Mon, 18 Jun 2018 15:49:35 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com (10.152.4.56) by DB5EUR01FT059.mail.protection.outlook.com (10.152.4.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.863.11 via Frontend Transport; Mon, 18 Jun 2018 15:49:35 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::b8fa:4bfe:9d63:439c]) by VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::b8fa:4bfe:9d63:439c%2]) with mapi id 15.20.0863.016; Mon, 18 Jun 2018 15:49:35 +0000 From: =?iso-8859-1?Q?Marvin_H=E4user?= To: "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib. Thread-Index: AQHUBY01DcIqwlHcT0O1VC0gOMNNEKRmHe7wgAAOlZA= Date: Mon, 18 Jun 2018 15:49:35 +0000 Message-ID: References: <82083b2c0427eb12806fb9e1ba5e806ea21e5b50.1529165460.git.Marvin.Haeuser@outlook.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E2983B1@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2983B1@SHSMSX104.ccr.corp.intel.com> Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:93E50AF9B9999E72DFD09F3722EDDFE4713DDAAA44CED881F06EC5DD5A374498; UpperCasedChecksum:FD792799D9E58375E08ADDE08556076CB2FE3187EBD611A9182645278B5BA5CF; SizeAsReceived:7344; Count:46 x-tmn: [YOlce501cCZ1aOVjcZwRWyxUDoyVxAvR] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5EUR01HT128; 7:XZjHXUMZo1N90hChuAnU33rz94XqZOfvZf6x9OkuXt8SRFKGD8cRNOal/Vzhl1yOt5Gyl048BiRHpnjp+1Uel+uMU03a4GanJcR9gKfSGT1mnFYlRpsyWYESrFaNyVZcLRCyZwJwDe0L084bfTrYbuQUwgBYz1b3B4mEY9vJZ7VuERkSCtohCRTgYlz6k6r26qJ933IecolFcp0F2bt4KsOlBpkhoTJb3DVKKgNfc9Zy5WiiTWhltWOZ1WDrnjMo x-incomingheadercount: 46 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1601125500)(1603101448)(1701031045); SRVR:DB5EUR01HT128; x-ms-traffictypediagnostic: DB5EUR01HT128: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:DB5EUR01HT128; BCL:0; PCL:0; RULEID:; SRVR:DB5EUR01HT128; x-forefront-prvs: 0707248B64 x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(199004)(189003)(13464003)(104016004)(6436002)(5640700003)(2900100001)(87572001)(45080400002)(33656002)(14454004)(86362001)(68736007)(2501003)(5250100002)(72206003)(55016002)(97736004)(4326008)(99286004)(8936002)(82202002)(20460500001)(25786009)(8676002)(5660300001)(74316002)(11346002)(81156014)(105586002)(426003)(106356001)(6246003)(446003)(305945005)(486006)(6916009)(229853002)(476003)(7696005)(3280700002)(76176011)(102836004)(2351001)(3660700001)(53546011)(6346003)(26005)(213903007); DIR:OUT; SFP:1901; SCL:1; SRVR:DB5EUR01HT128; H:VI1PR0801MB1790.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:; received-spf: None (protection.outlook.com: outlook.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Marvin.Haeuser@outlook.com; x-microsoft-antispam-message-info: gDR1uB48u9X4sdTXtHb1ab9J+JIpkD40o3UQ4jj+5cZBFTUcQPS/AySId1E93bs8BFEzy5rFUWotaAUix3nVZqMyEFjnbQnCrVeAr/KRLBo1mVBOVe52Uzq7ariM+cPuBqpDJTMxLix/nGMNBwNQRoEHyYoi5yy2xP6FSxpBPcz835IqK4blnB/DelAOUDR3 MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-Network-Message-Id: bf349f9c-d0da-487c-6b83-08d5d5331796 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2018 15:49:35.7474 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR01HT128 Subject: Re: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 15:49:40 -0000 Content-Language: de-DE Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sorry, you are right. The linker somehow blamed UefiDebugLibConOut for a mo= dule not declaring that dependency. Regards, Marvin. > -----Original Message----- > From: Gao, Liming > Sent: Monday, June 18, 2018 4:57 PM > To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org > Cc: Kinney, Michael D > Subject: RE: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume > UefiLib. >=20 > UefiDebugLibConOut depends on PrintLib. It doesn't call any API in UefiLi= b. >=20 > > -----Original Message----- > > From: Marvin H=E4user [mailto:Marvin.Haeuser@outlook.com] > > Sent: Sunday, June 17, 2018 12:15 AM > > To: edk2-devel@lists.01.org > > Cc: Kinney, Michael D ; Gao, Liming > > > > Subject: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume > UefiLib. > > > > UefiDebugLibConOut does currently not consume UefiLib, from which it > > uses the Print() function. This commit adds an explicit dependency. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Marvin Haeuser > > --- > > MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > > b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > > index 583872f54e81..64651c4169a8 100644 > > --- a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > > +++ b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > > @@ -46,6 +46,7 @@ [LibraryClasses] > > PrintLib > > UefiBootServicesTableLib > > DebugPrintErrorLevelLib > > + UefiLib > > > > [Pcd] > > gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue ## > SOMETIMES_CONSUMES > > -- > > 2.17.1.windows.2