From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.92.71.101; helo=eur03-db5-obe.outbound.protection.outlook.com; envelope-from=marvin.haeuser@outlook.com; receiver=edk2-devel@lists.01.org Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-oln040092071101.outbound.protection.outlook.com [40.92.71.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ABB9121B02845 for ; Mon, 23 Jul 2018 06:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/DGsMS5DU6J7RZpITKWs6gvTcr0EO5Ve3Bssia9vStM=; b=bTU9WcuCnO6qseDwgsAu058Hjj/REHHafRg9tsv+pKQIaMLKm89sjYlgEM/BX6Sj0wAGImrW7ftyjGGNe8bdYHxw6kYmIjIAspcaygYPATGYEREeA6SZN5sGhztYSrSVmzfOQLEXoiHMvzpz9R8jn2tViVPLioR0N+ALAJ2c1m/0zcnC0MNFaeZTO18GOUgQWwxK9Z6KPN45uaBeX87MMMZuVSjXUPUWMtEQF5fUy/Ft89Fyai58RlkR/49Jp5/JsShKvElblNa5bD22gBBqmkpWndIG6H7A/UpOPNpSeP1Tsx3DhTIh2NcJLcMBZXIduV1m9eKt8qMD+RlWmgNnSw== Received: from DB5EUR03FT009.eop-EUR03.prod.protection.outlook.com (10.152.20.58) by DB5EUR03HT003.eop-EUR03.prod.protection.outlook.com (10.152.20.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.952.17; Mon, 23 Jul 2018 13:01:35 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com (10.152.20.56) by DB5EUR03FT009.mail.protection.outlook.com (10.152.20.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.995.12 via Frontend Transport; Mon, 23 Jul 2018 13:01:35 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7532:4dc6:e9f7:4765]) by VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7532:4dc6:e9f7:4765%2]) with mapi id 15.20.0973.022; Mon, 23 Jul 2018 13:01:35 +0000 From: Marvin H?user To: "edk2-devel@lists.01.org" , "Gao, Liming" CC: "ruiyu.ni@intel.com" Thread-Topic: [PATCH] PcAtChipsetPkg/AcpiTimerLib: Support Standalone MM. Thread-Index: AQHUIhB7GSTxFqqMxkmssOyakdK+N6ScW0XAgABphdA= Date: Mon, 23 Jul 2018 13:01:34 +0000 Message-ID: References: <3e63e0c06e38886af03bfc7a7e90ce6608f44ce8.1532300587.git.Marvin.Haeuser@outlook.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E2BF982@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2BF982@SHSMSX104.ccr.corp.intel.com> Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:C96DF84B0DA3C31F30FB6D1CB94641B0592568C86C374272EC85CEAA4E8F5912; UpperCasedChecksum:FED71E46E960394D748B751B59355F75A29A053A9F0B8997431355A1D912934A; SizeAsReceived:7373; Count:46 x-tmn: [oWNVyoFuyMwUpHJMAWafbqjKPnVGt7r/] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5EUR03HT003; 7:uyElHexaXrNYQ3QoJUF/BNFuBgmbVQ/hgHLuTNY6J5CM0N6b/uNEw4FZeWTZrXi0Ut0G0eIIXIq1BvLgBtvrZNsZ0y/lnh2PxR7FCYy0DTcDaAdqRCq1sN4OCDkBtKs2eQ5Z6Wq9bRrg1nWtMWZVCM3y2xiUD124y7d5kJHo+lX2JHlx3lFw79JRu51IofY8EHZSk1CYBxtx4A8jIq6Qz0laxiWVeEiAf4DpCINAb+WTQhQrIGAPy1LPKYASM47Q x-incomingheadercount: 46 x-eopattributedmessage: 0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125500)(1701031045); SRVR:DB5EUR03HT003; x-ms-traffictypediagnostic: DB5EUR03HT003: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(82015058); SRVR:DB5EUR03HT003; BCL:0; PCL:0; RULEID:; SRVR:DB5EUR03HT003; x-forefront-prvs: 0742443479 x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(6029001)(199004)(189003)(13464003)(8936002)(53546011)(6436002)(20460500001)(14454004)(305945005)(6306002)(87572001)(55016002)(33656002)(446003)(105586002)(486006)(11346002)(476003)(426003)(76176011)(81156014)(8676002)(68736007)(229853002)(5660300001)(26005)(106356001)(97736004)(5250100002)(102836004)(74316002)(6346003)(4326008)(2501003)(6246003)(25786009)(72206003)(99286004)(2900100001)(45080400002)(110136005)(7696005)(82202002)(56003)(104016004)(86362001)(256004); DIR:OUT; SFP:1901; SCL:1; SRVR:DB5EUR03HT003; H:VI1PR0801MB1790.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:; received-spf: None (protection.outlook.com: outlook.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Marvin.Haeuser@outlook.com; x-microsoft-antispam-message-info: CdRKBt+lBjEkfnisFG709DhGGrVoU5gEZeknc/a5IFm3ZeN/G/z4Js2eGdtpCTdFTRcBCRYXnJoEmmI7hT8rR/oPhVOd9UUF7KoL54WclzzNAT8TeVy7+Bs6Anj+Y6wYd5rlueAwohu1Umb/QIa/+f/kRqgmZTFtOwnllq3OBZyj3Uo5EFn6Q+KtRdGyG9t4btnek2mEwJ0fwcxpKXIHibyE7JQ80ItHHO96GU29NDk= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-Network-Message-Id: 6cb3e84f-65b5-4c8f-fee3-08d5f09c6b6e X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2018 13:01:35.0083 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR03HT003 Subject: Re: [PATCH] PcAtChipsetPkg/AcpiTimerLib: Support Standalone MM. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 13:01:44 -0000 Content-Language: de-DE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Best regards, Marvin. > -----Original Message----- > From: Gao, Liming > Sent: Monday, July 23, 2018 8:46 AM > To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: RE: [PATCH] PcAtChipsetPkg/AcpiTimerLib: Support Standalone MM. >=20 > Marvin: > If this library supports standalone MM module only, I agree its source = file > includes Standalone MM > But, this library instance also supports DXE, SMM. I don't think > StandaloneMm name is good for them. I called all files "DxeStandaloneMm", the same way as other libraries appen= d environment types ("PeiDxePostCodeLib", etc). Did I overlook something? >=20 > Besides, I want to know why you changes this library instance. Are ther= e the > standalone MM module to depend on this AcpiTimerLib? I wanted to try out porting a private module which happened to depend on Ac= piTimerLib and thus HobLib. HobLib will follow once the MmServicesTableLib patch has been decided on an= d I will adapt others too once I run into needing them. >=20 > Thanks > Liming > >-----Original Message----- > >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > >Marvin H?user > >Sent: Monday, July 23, 2018 7:05 AM > >To: edk2-devel@lists.01.org > >Cc: Ni, Ruiyu > >Subject: [edk2] [PATCH] PcAtChipsetPkg/AcpiTimerLib: Support Standalone > >MM. > > > >To support Standalone MM, the current DXE implementation, which is also > >used to support DXE SMM Drivers, has been modified. Its type was > >changed to BASE to make the constructor function generic, > MM_STANDALONE > >modules types have been added to the support list and the internal > >files were adapted to show support. > > > >"DxeAcpiTimerLib.inf" has not been renamed to not break packages. > >This might be addressed with a separate patch. > > > >Contributed-under: TianoCore Contribution Agreement 1.1 > >Signed-off-by: Marvin Haeuser > >--- > > PcAtChipsetPkg/Library/AcpiTimerLib/{DxeAcpiTimerLib.c =3D> > >DxeStandaloneMmAcpiTimerLib.c} | 9 +++------ > > PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf > >| 14 +++++++------- > > PcAtChipsetPkg/Library/AcpiTimerLib/{DxeAcpiTimerLib.uni =3D> > >StandaloneMmDxeAcpiTimerLib.uni} | 2 +- > > 3 files changed, 11 insertions(+), 14 deletions(-) > > > >diff --git a/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.c > >b/PcAtChipsetPkg/Library/AcpiTimerLib/DxeStandaloneMmAcpiTimerLib.c > >similarity index 88% > >rename from PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.c > >rename to > >PcAtChipsetPkg/Library/AcpiTimerLib/DxeStandaloneMmAcpiTimerLib.c > >index 9ed10ef2e297..784f33871d75 100644 > >--- a/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.c > >+++ > >b/PcAtChipsetPkg/Library/AcpiTimerLib/DxeStandaloneMmAcpiTimerLib.c > >@@ -13,6 +13,7 @@ > > **/ > > > > #include > >+#include > > #include > > #include > > #include > >@@ -78,17 +79,13 @@ InternalGetPerformanceCounterFrequency ( > > /** > > The constructor function enables ACPI IO space, and caches > >PerformanceCounterFrequency. > > > >- @param ImageHandle The firmware allocated handle for the EFI image= . > >- @param SystemTable A pointer to the EFI System Table. > >- > > @retval EFI_SUCCESS The constructor always returns RETURN_SUCCESS. > > > > **/ > > EFI_STATUS > > EFIAPI > >-DxeAcpiTimerLibConstructor ( > >- IN EFI_HANDLE ImageHandle, > >- IN EFI_SYSTEM_TABLE *SystemTable > >+DxeStandaloneMmAcpiTimerLibConstructor ( > >+ VOID > > ) > > { > > EFI_HOB_GUID_TYPE *GuidHob; > >diff --git a/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf > >b/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf > >index 601041c80137..f1f62247649e 100644 > >--- a/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf > >+++ b/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf > >@@ -1,5 +1,5 @@ > > ## @file > >-# DXE ACPI Timer Library > >+# DXE and Standalone MM ACPI Timer Library > > # > > # Provides basic timer support using the ACPI timer hardware. The > >performance # counter features are provided by the processors time > >stamp counter. > >@@ -20,17 +20,17 @@ > > > > [Defines] > > INF_VERSION =3D 0x00010005 > >- BASE_NAME =3D DxeAcpiTimerLib > >+ BASE_NAME =3D DxeStandaloneMmAcpiTimerLib > > FILE_GUID =3D E624B98C-845A-4b94-9B50-B20475D552= B9 > >- MODULE_TYPE =3D DXE_DRIVER > >+ MODULE_TYPE =3D BASE > > VERSION_STRING =3D 1.0 > >- LIBRARY_CLASS =3D TimerLib|DXE_CORE DXE_DRIVER > >DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION > UEFI_DRIVER SMM_CORE > >- CONSTRUCTOR =3D DxeAcpiTimerLibConstructor > >- MODULE_UNI_FILE =3D DxeAcpiTimerLib.uni > >+ LIBRARY_CLASS =3D TimerLib|DXE_CORE DXE_DRIVER > >DXE_RUNTIME_DRIVER DXE_SMM_DRIVER MM_STANDALONE > UEFI_APPLICATION > >UEFI_DRIVER SMM_CORE MM_CORE_STANDALONE > >+ CONSTRUCTOR =3D DxeStandaloneMmAcpiTimerLibConstru= ctor > >+ MODULE_UNI_FILE =3D DxeStandaloneMmAcpiTimerLib.uni > > > > [Sources] > > AcpiTimerLib.c > >- DxeAcpiTimerLib.c > >+ DxeStandaloneMmAcpiTimerLib.c > > > > [Packages] > > MdePkg/MdePkg.dec > >diff --git a/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.uni > >b/PcAtChipsetPkg/Library/AcpiTimerLib/StandaloneMmDxeAcpiTimerLib.u > ni > >similarity index 92% > >rename from PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.uni > >rename to > >PcAtChipsetPkg/Library/AcpiTimerLib/StandaloneMmDxeAcpiTimerLib.uni > >index bf31abf81d68..6b3abb85ebc8 100644 > >--- a/PcAtChipsetPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.uni > >+++ > >b/PcAtChipsetPkg/Library/AcpiTimerLib/StandaloneMmDxeAcpiTimerLib.u > ni > >@@ -1,5 +1,5 @@ > > // /** @file > >-// DXE ACPI Timer Library > >+// DXE and Standalone MM ACPI Timer Library > > // > > // Provides basic timer support using the ACPI timer hardware. The > >performance // counter features are provided by the processors time > >stamp counter. > >-- > >2.18.0.windows.1 > > > >_______________________________________________ > >edk2-devel mailing list > >edk2-devel@lists.01.org > >https://lists.01.org/mailman/listinfo/edk2-devel