public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/1] BaseTools: Update Makefile to exclude deleted file.
@ 2018-10-15  3:32 Marvin Häuser
  2018-10-19  0:30 ` Zhu, Yonghong
  0 siblings, 1 reply; 2+ messages in thread
From: Marvin Häuser @ 2018-10-15  3:32 UTC (permalink / raw)
  To: edk2-devel@lists.01.org; +Cc: liming.gao@intel.com, yonghong.zhu@intel.com

GenFds/Attributes.py has been deleted in 1ad635b, but was not removed
from the Python Makefile. Remove it for successful compilation on
Windows.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
---
 BaseTools/Source/Python/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/BaseTools/Source/Python/Makefile b/BaseTools/Source/Python/Makefile
index ac99259eb18a..2a80f1cf7fe9 100644
--- a/BaseTools/Source/Python/Makefile
+++ b/BaseTools/Source/Python/Makefile
@@ -114,7 +114,6 @@ CMD_BUILD=$(BASE_TOOLS_PATH)\Source\Python\build\BuildReport.py \
     $(BASE_TOOLS_PATH)\Source\Python\Eot\Report.py
 
 CMD_GENFDS=$(BASE_TOOLS_PATH)\Source\Python\GenFds\AprioriSection.py \
-    $(BASE_TOOLS_PATH)\Source\Python\GenFds\Attribute.py \
     $(BASE_TOOLS_PATH)\Source\Python\GenFds\Capsule.py \
     $(BASE_TOOLS_PATH)\Source\Python\GenFds\CapsuleData.py \
     $(BASE_TOOLS_PATH)\Source\Python\GenFds\ComponentStatement.py \
-- 
2.19.1.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] BaseTools: Update Makefile to exclude deleted file.
  2018-10-15  3:32 [PATCH 1/1] BaseTools: Update Makefile to exclude deleted file Marvin Häuser
@ 2018-10-19  0:30 ` Zhu, Yonghong
  0 siblings, 0 replies; 2+ messages in thread
From: Zhu, Yonghong @ 2018-10-19  0:30 UTC (permalink / raw)
  To: Marvin.Haeuser@outlook.com, edk2-devel@lists.01.org
  Cc: Gao, Liming, Zhu, Yonghong

Hi Marvin Häuser,

Liming sent some mail to notice that we drop the support of BaseTools Python run from the freeze binary in Windows OS, and he also sent patch to remove the steps to freeze python tool. So I don't think we need this patch now, please check it. Thanks.

https://lists.01.org/pipermail/edk2-devel/2018-September/029436.html 
 https://lists.01.org/pipermail/edk2-devel/2018-October/030969.html 
https://lists.01.org/pipermail/edk2-devel/2018-October/030589.html 

Best Regards,
Zhu Yonghong

-----Original Message-----
From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com] 
Sent: Monday, October 15, 2018 11:33 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: [PATCH 1/1] BaseTools: Update Makefile to exclude deleted file.

GenFds/Attributes.py has been deleted in 1ad635b, but was not removed from the Python Makefile. Remove it for successful compilation on Windows.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
---
 BaseTools/Source/Python/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/BaseTools/Source/Python/Makefile b/BaseTools/Source/Python/Makefile
index ac99259eb18a..2a80f1cf7fe9 100644
--- a/BaseTools/Source/Python/Makefile
+++ b/BaseTools/Source/Python/Makefile
@@ -114,7 +114,6 @@ CMD_BUILD=$(BASE_TOOLS_PATH)\Source\Python\build\BuildReport.py \
     $(BASE_TOOLS_PATH)\Source\Python\Eot\Report.py
 
 CMD_GENFDS=$(BASE_TOOLS_PATH)\Source\Python\GenFds\AprioriSection.py \
-    $(BASE_TOOLS_PATH)\Source\Python\GenFds\Attribute.py \
     $(BASE_TOOLS_PATH)\Source\Python\GenFds\Capsule.py \
     $(BASE_TOOLS_PATH)\Source\Python\GenFds\CapsuleData.py \
     $(BASE_TOOLS_PATH)\Source\Python\GenFds\ComponentStatement.py \
--
2.19.1.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-19  0:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-15  3:32 [PATCH 1/1] BaseTools: Update Makefile to exclude deleted file Marvin Häuser
2018-10-19  0:30 ` Zhu, Yonghong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox