public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Marvin Häuser" <Marvin.Haeuser@outlook.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "michael.d.kinney@intel.com" <michael.d.kinney@intel.com>,
	"liming.gao@intel.com" <liming.gao@intel.com>,
	"star.zeng@intel.com" <star.zeng@intel.com>,
	"eric.dong@intel.com" <eric.dong@intel.com>,
	"ruiyu.ni@intel.com" <ruiyu.ni@intel.com>,
	"lersek@redhat.com" <lersek@redhat.com>,
	"kelly.steele@intel.com" <kelly.steele@intel.com>,
	"jordan.l.justen@intel.com" <jordan.l.justen@intel.com>,
	"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>
Subject: [PATCH 5/8] QuarkSocPkg/SmmAccessPei: Update MM PPI usages.
Date: Tue, 24 Jul 2018 01:40:38 +0000	[thread overview]
Message-ID: <VI1PR0801MB17904F81AAD9BA66922CAC4580550@VI1PR0801MB1790.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <d625966ce7c0ac98b65f1e946b2cf833f6801706.1532395896.git.Marvin.Haeuser@outlook.com>

Update all references to the SMM PPIs from MdeModulePkg to rather use
MdePkg's MM PPI declarations.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
---
 QuarkSocPkg/QuarkNorthCluster/Smm/Pei/SmmAccessPei/SmmAccessPei.c   | 48 ++++++++++----------
 QuarkSocPkg/QuarkNorthCluster/Smm/Pei/SmmAccessPei/SmmAccessPei.inf |  2 +-
 2 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/QuarkSocPkg/QuarkNorthCluster/Smm/Pei/SmmAccessPei/SmmAccessPei.c b/QuarkSocPkg/QuarkNorthCluster/Smm/Pei/SmmAccessPei/SmmAccessPei.c
index 70fdf096117f..6686d87a3fda 100644
--- a/QuarkSocPkg/QuarkNorthCluster/Smm/Pei/SmmAccessPei/SmmAccessPei.c
+++ b/QuarkSocPkg/QuarkNorthCluster/Smm/Pei/SmmAccessPei/SmmAccessPei.c
@@ -14,7 +14,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 
 **/
 #include <PiPei.h>
-#include <Ppi/SmmAccess.h>
+#include <Ppi/MmAccess.h>
 #include <Guid/SmramMemoryReserve.h>
 #include <Library/BaseMemoryLib.h>
 #include <Library/MemoryAllocationLib.h>
@@ -29,7 +29,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
   CR ( \
   a, \
   SMM_ACCESS_PRIVATE_DATA, \
-  SmmAccess, \
+  MmAccess, \
   SMM_ACCESS_PRIVATE_DATA_SIGNATURE \
   )
 
@@ -39,7 +39,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 typedef struct {
   UINTN                            Signature;
   EFI_HANDLE                       Handle;
-  PEI_SMM_ACCESS_PPI               SmmAccess;
+  EFI_PEI_MM_ACCESS_PPI            MmAccess;
   UINTN                            NumberRegions;
   EFI_SMRAM_DESCRIPTOR             SmramDesc[MAX_SMRAM_RANGES];
   UINT8                            TsegSize;
@@ -55,7 +55,7 @@ EFI_STATUS
 EFIAPI
 Open (
   IN EFI_PEI_SERVICES           **PeiServices,
-  IN PEI_SMM_ACCESS_PPI         *This,
+  IN EFI_PEI_MM_ACCESS_PPI      *This,
   IN UINTN                      DescriptorIndex
   )
 /*++
@@ -70,7 +70,7 @@ Routine Description:
 Arguments:
 
   PeiServices      - General purpose services available to every PEIM.
-  This             -  Pointer to the SMM Access Interface.
+  This             -  Pointer to the MM Access Interface.
   DescriptorIndex  -  Region of SMRAM to Open.
 
 Returns:
@@ -102,7 +102,7 @@ Returns:
 
   SmmAccess->SmramDesc[DescriptorIndex].RegionState &= ~(EFI_SMRAM_CLOSED | EFI_ALLOCATED);
   SmmAccess->SmramDesc[DescriptorIndex].RegionState |= EFI_SMRAM_OPEN;
-  SmmAccess->SmmAccess.OpenState = TRUE;
+  SmmAccess->MmAccess.OpenState = TRUE;
 
   return EFI_SUCCESS;
 }
@@ -111,7 +111,7 @@ EFI_STATUS
 EFIAPI
 Close (
   IN EFI_PEI_SERVICES        **PeiServices,
-  IN PEI_SMM_ACCESS_PPI      *This,
+  IN EFI_PEI_MM_ACCESS_PPI   *This,
   IN UINTN                   DescriptorIndex
   )
 /*++
@@ -124,7 +124,7 @@ Routine Description:
 Arguments:
 
   PeiServices      - General purpose services available to every PEIM.
-  This             -  Pointer to the SMM Access Interface.
+  This             -  Pointer to the MM Access Interface.
   DescriptorIndex  -  Region of SMRAM to Close.
 
 Returns:
@@ -174,7 +174,7 @@ Returns:
     }
   }
 
-  SmmAccess->SmmAccess.OpenState = OpenState;
+  SmmAccess->MmAccess.OpenState = OpenState;
 
   return EFI_SUCCESS;
 }
@@ -183,7 +183,7 @@ EFI_STATUS
 EFIAPI
 Lock (
   IN EFI_PEI_SERVICES          **PeiServices,
-  IN PEI_SMM_ACCESS_PPI        *This,
+  IN EFI_PEI_MM_ACCESS_PPI     *This,
   IN UINTN                     DescriptorIndex
   )
 /*++
@@ -198,7 +198,7 @@ Routine Description:
 Arguments:
 
   PeiServices      - General purpose services available to every PEIM.
-  This             -  Pointer to the SMM Access Interface.
+  This             -  Pointer to the MM Access Interface.
   DescriptorIndex  -  Region of SMRAM to Lock.
 
 Returns:
@@ -216,12 +216,12 @@ Returns:
 
   if (DescriptorIndex >= SmmAccess->NumberRegions) {
     return EFI_INVALID_PARAMETER;
-  } else if (SmmAccess->SmmAccess.OpenState) {
+  } else if (SmmAccess->MmAccess.OpenState) {
     return EFI_DEVICE_ERROR;
   }
 
   SmmAccess->SmramDesc[DescriptorIndex].RegionState |= EFI_SMRAM_LOCKED;
-  SmmAccess->SmmAccess.LockState                     = TRUE;
+  SmmAccess->MmAccess.LockState                     = TRUE;
 
   //
   // Lock TSEG
@@ -235,7 +235,7 @@ EFI_STATUS
 EFIAPI
 GetCapabilities (
   IN EFI_PEI_SERVICES                **PeiServices,
-  IN PEI_SMM_ACCESS_PPI              *This,
+  IN EFI_PEI_MM_ACCESS_PPI           *This,
   IN OUT UINTN                       *SmramMapSize,
   IN OUT EFI_SMRAM_DESCRIPTOR        *SmramMap
   )
@@ -293,7 +293,7 @@ SmmAccessPeiEntryPoint (
 
 Routine Description:
 
-    This is the constructor for the SMM Access Ppi
+    This is the constructor for the MM Access Ppi
 
 Arguments:
 
@@ -354,17 +354,17 @@ Returns:
     SmmAccessPrivate->SmramDesc[Index].RegionState   = DescriptorBlock->Descriptor[Index].RegionState;
   }
 
-  SmmAccessPrivate->NumberRegions              = Index;
-  SmmAccessPrivate->SmmAccess.Open             = Open;
-  SmmAccessPrivate->SmmAccess.Close            = Close;
-  SmmAccessPrivate->SmmAccess.Lock             = Lock;
-  SmmAccessPrivate->SmmAccess.GetCapabilities  = GetCapabilities;
-  SmmAccessPrivate->SmmAccess.LockState        = FALSE;
-  SmmAccessPrivate->SmmAccess.OpenState        = FALSE;
+  SmmAccessPrivate->NumberRegions             = Index;
+  SmmAccessPrivate->MmAccess.Open             = Open;
+  SmmAccessPrivate->MmAccess.Close            = Close;
+  SmmAccessPrivate->MmAccess.Lock             = Lock;
+  SmmAccessPrivate->MmAccess.GetCapabilities  = GetCapabilities;
+  SmmAccessPrivate->MmAccess.LockState        = FALSE;
+  SmmAccessPrivate->MmAccess.OpenState        = FALSE;
 
   PpiList->Flags = (EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST);
-  PpiList->Guid  = &gPeiSmmAccessPpiGuid;
-  PpiList->Ppi   = &SmmAccessPrivate->SmmAccess;
+  PpiList->Guid  = &gEfiPeiMmAccessPpiGuid;
+  PpiList->Ppi   = &SmmAccessPrivate->MmAccess;
 
   Status      = (**PeiServices).InstallPpi (PeiServices, PpiList);
   ASSERT_EFI_ERROR(Status);
diff --git a/QuarkSocPkg/QuarkNorthCluster/Smm/Pei/SmmAccessPei/SmmAccessPei.inf b/QuarkSocPkg/QuarkNorthCluster/Smm/Pei/SmmAccessPei/SmmAccessPei.inf
index a1e4af7725ac..41566d5ecc2b 100644
--- a/QuarkSocPkg/QuarkNorthCluster/Smm/Pei/SmmAccessPei/SmmAccessPei.inf
+++ b/QuarkSocPkg/QuarkNorthCluster/Smm/Pei/SmmAccessPei/SmmAccessPei.inf
@@ -44,7 +44,7 @@ [Guids]
   gEfiSmmPeiSmramMemoryReserveGuid             # ALWAYS_CONSUMED
 
 [Ppis]
-  gPeiSmmAccessPpiGuid                         # ALWAYS_PRODUCED
+  gEfiPeiMmAccessPpiGuid                       # ALWAYS_PRODUCED
   gEfiPeiMemoryDiscoveredPpiGuid               # ALWAYS_CONSUMED
 
 [Depex]
-- 
2.18.0.windows.1



  parent reply	other threads:[~2018-07-24  1:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <d625966ce7c0ac98b65f1e946b2cf833f6801706.1532395896.git.Marvin.Haeuser@outlook.com>
2018-07-24  1:40 ` [PATCH 2/8] MdeModulePkg/SmmLockBoxPeiLib: Update MM PPI usages Marvin Häuser
2018-07-24  1:40 ` [PATCH 3/8] UefiCpuPkg/PiSmmCommunicationPei: " Marvin Häuser
2018-07-24  1:40 ` [PATCH 4/8] UefiCpuPkg/S3Resume2Pei: " Marvin Häuser
2018-07-24  1:40 ` Marvin Häuser [this message]
2018-07-24  1:40 ` [PATCH 6/8] QuarkSocPkg/SmmControlPei: " Marvin Häuser
2018-07-24  1:40 ` [PATCH 7/8] OvmfPkg/SmmAccessPei: " Marvin Häuser
2018-07-24  9:20   ` Laszlo Ersek
2018-07-24 12:16     ` Marvin Häuser
2018-07-24 12:39       ` Laszlo Ersek
2018-07-24  1:40 ` [PATCH 8/8] MdeModulePkg: Deprecate Smm* PPIs Marvin Häuser
2018-07-24  6:38   ` Gao, Liming
2018-07-24 10:04     ` Zeng, Star
2018-07-24 10:28     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0801MB17904F81AAD9BA66922CAC4580550@VI1PR0801MB1790.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox