From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.92.65.67; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=marvin.haeuser@outlook.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-oln040092065067.outbound.protection.outlook.com [40.92.65.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 26F75203BEA3B for ; Sat, 5 May 2018 07:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+DXMWxrn4PioYJsA0tdbyq0Rbl24VVswfho0fl5kAa8=; b=kfpXMRKQG07i35DQBMASmXbniONeSbHRY0kXHcGJ6bgG1O4OpGYwG4XdlUBN74j2NczPhZnXJnFY/VHQA1xdB1jDRIU5m9c7SeDdFEe0WLvUH7iPdwrXedtpDu/RgezGlp9A33HT1pxsBpT4L5szTaTKa6UMZ+p0SRB+okemuMyp4u0zUXWzyBMEjBOZJ5EY4QmOhIFB5Q5LBmR0LizOL3hk8ukv/kQc7jwhulaGBxr2axtTNtprWRGV2L/spLedNoy1w2fNz2m52k1l2wsHttl5O+YhWR7jfJEVb+Z1PinkCsMxuS2LAuCKw78XhFnKO273YXbFIPP5MDCIWnqwDg== Received: from DB5EUR01FT004.eop-EUR01.prod.protection.outlook.com (10.152.4.58) by DB5EUR01HT125.eop-EUR01.prod.protection.outlook.com (10.152.5.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.735.16; Sat, 5 May 2018 14:24:01 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com (10.152.4.53) by DB5EUR01FT004.mail.protection.outlook.com (10.152.4.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.735.16 via Frontend Transport; Sat, 5 May 2018 14:24:01 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7c79:584b:2e12:783e]) by VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7c79:584b:2e12:783e%17]) with mapi id 15.20.0715.024; Sat, 5 May 2018 14:23:54 +0000 From: =?iso-8859-1?Q?Marvin_H=E4user?= To: "edk2-devel@lists.01.org" CC: "michael.d.kinney@intel.com" , "liming.gao@intel.com" Thread-Topic: [PATCH v2 1/2] MdePkg/UefiLib: Add 'OUT' decorator where necessary. Thread-Index: AQHT5HyyYxQqXhf4ZUuwY8RwCSl6qw== Date: Sat, 5 May 2018 14:23:54 +0000 Message-ID: Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM0PR02CA0023.eurprd02.prod.outlook.com (2603:10a6:208:3e::36) To VI1PR0801MB1790.eurprd08.prod.outlook.com (2603:10a6:800:5b::15) x-incomingtopheadermarker: OriginalChecksum:9D96A9331F14A6418A48EC87989FA39845CA6E6A7CD9002C9B2D027E827B43E2; UpperCasedChecksum:87C1B2CB968A3F33C753E487F0C5F28E82191E914DED9A98BE1181894F162317; SizeAsReceived:7495; Count:48 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [HNkrFFokmOHrATnmEKleBZwbFH/6J4OH] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5EUR01HT125; 7:+jsm65otOgUe8KYlUDYunxLUoFVPBF5ZGfzs9e0j310WWH7nNnphLtOfuB1WyBl87xKdip3/OpvMVPIP/PSpi95Em9tEBvf0hE70r2Pi89oE7BAxWFuDhhKtk2gotlRBT546IZDb2PZM+1lcIeMTH2M3McdTuvxDGPYFGEUkaHmMbkHTf/4N1ls/vdYajAWNwcm+BkiZpwKQ9WzjspiE4SeTBeCKzqhVhKpluF5CT6tHd+mTVferivUJWXZe5OLW x-incomingheadercount: 48 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125374)(1701031045); SRVR:DB5EUR01HT125; x-ms-traffictypediagnostic: DB5EUR01HT125: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:DB5EUR01HT125; BCL:0; PCL:0; RULEID:; SRVR:DB5EUR01HT125; x-forefront-prvs: 0663390E1B x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:DB5EUR01HT125; H:VI1PR0801MB1790.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:; x-microsoft-antispam-message-info: aiDV1FrbslIas7wPZgg/td38in3Mqiy4eoTd/NlBAkbhVyCSYeFFoF97YoGtSpKwANwBX/DaGDuammtrgy/JjJk3aqKA6Jup3ZkrZcmB/5xuBeOWjG4JkCpQ0Sj7RHRKETk1/uMqF3FkLQaHnG+fHPd1FbgNOzvbpdYbV6/JaFMQ6eiysa2JzgGuX0HTDBtF MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 353a0c85-21af-4d5d-7fb8-08d5b293d499 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-Network-Message-Id: 353a0c85-21af-4d5d-7fb8-08d5b293d499 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2018 14:23:54.5496 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR01HT125 Subject: [PATCH v2 1/2] MdePkg/UefiLib: Add 'OUT' decorator where necessary. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2018 14:24:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable The functions AddUnicodeString() and AddUnicodeString2() might return a new value into their parameter UnicodeStringTable, hence add the appropiate 'OUT' decorator. V2: Update FrameworkUefiLib as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- MdePkg/Library/UefiLib/UefiLib.c | 18 +++++++++--------- MdePkg/Include/Library/UefiLib.h | 18 +++++++++--------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/MdePkg/Library/UefiLib/UefiLib.c b/MdePkg/Library/UefiLib/Uefi= Lib.c index f1a3f1c7af05..ba449a1c34ce 100644 --- a/MdePkg/Library/UefiLib/UefiLib.c +++ b/MdePkg/Library/UefiLib/UefiLib.c @@ -888,10 +888,10 @@ LookupUnicodeString2 ( EFI_STATUS EFIAPI AddUnicodeString ( - IN CONST CHAR8 *Language, - IN CONST CHAR8 *SupportedLanguages, - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable, - IN CONST CHAR16 *UnicodeString + IN CONST CHAR8 *Language, + IN CONST CHAR8 *SupportedLanguages, + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable, + IN CONST CHAR16 *UnicodeString ) { UINTN NumberOfEntries; @@ -1065,11 +1065,11 @@ AddUnicodeString ( EFI_STATUS EFIAPI AddUnicodeString2 ( - IN CONST CHAR8 *Language, - IN CONST CHAR8 *SupportedLanguages, - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable, - IN CONST CHAR16 *UnicodeString, - IN BOOLEAN Iso639Language + IN CONST CHAR8 *Language, + IN CONST CHAR8 *SupportedLanguages, + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable, + IN CONST CHAR16 *UnicodeString, + IN BOOLEAN Iso639Language ) { UINTN NumberOfEntries; diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/Uefi= Lib.h index 54bc2cc5a334..256498e3fd8d 100644 --- a/MdePkg/Include/Library/UefiLib.h +++ b/MdePkg/Include/Library/UefiLib.h @@ -587,10 +587,10 @@ LookupUnicodeString2 ( EFI_STATUS EFIAPI AddUnicodeString ( - IN CONST CHAR8 *Language, - IN CONST CHAR8 *SupportedLanguages, - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable, - IN CONST CHAR16 *UnicodeString + IN CONST CHAR8 *Language, + IN CONST CHAR8 *SupportedLanguages, + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable, + IN CONST CHAR16 *UnicodeString ); =20 /** @@ -638,11 +638,11 @@ AddUnicodeString ( EFI_STATUS EFIAPI AddUnicodeString2 ( - IN CONST CHAR8 *Language, - IN CONST CHAR8 *SupportedLanguages, - IN EFI_UNICODE_STRING_TABLE **UnicodeStringTable, - IN CONST CHAR16 *UnicodeString, - IN BOOLEAN Iso639Language + IN CONST CHAR8 *Language, + IN CONST CHAR8 *SupportedLanguages, + IN OUT EFI_UNICODE_STRING_TABLE **UnicodeStringTable, + IN CONST CHAR16 *UnicodeString, + IN BOOLEAN Iso639Language ); =20 /** --=20 2.17.0.windows.1