From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a01:111:f400:fe1f::820; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=marvin.haeuser@outlook.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01olkn0820.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1f::820]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 610A9207E36BB for ; Thu, 17 May 2018 04:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O3yRHT0pyxR+R2zdCs/RkIJT2diQsClEyarRuHc3gQE=; b=CcR2FJNZjDsx7trFCmDEFaw/GHxJeqw5OIFle2pSfBnb43UTdg0Z7Mo8a1ZJIvLU7Fm/B1YPrPnbmbSZAcxIUBQJ7AlTnAGRjI1rp1lJZoioo+tVjiBDTYx+TzX4tePq2wH26ZFreEAKKArTFDJYs9rmrqJVjgRcra7DCLKHF2XX9PACv97mNH60terCSSMMRBFrY2tgfN+pyvxCG+IR1ARJ4oRiyUFmCbY1/w9PlpH62nXpYIbBrh7U7VC46YpbFlGvOR52cxEYgLReceLwp1pMAvuStlPKYHQq+Cr02sH7MXOzycCOmw4DY31lQ6i0wSlSXLBXBavUlAVfjknQVQ== Received: from DB5EUR01FT032.eop-EUR01.prod.protection.outlook.com (10.152.4.53) by DB5EUR01HT136.eop-EUR01.prod.protection.outlook.com (10.152.5.241) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.10; Thu, 17 May 2018 11:44:53 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com (10.152.4.56) by DB5EUR01FT032.mail.protection.outlook.com (10.152.4.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.776.10 via Frontend Transport; Thu, 17 May 2018 11:44:52 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7010:5d5e:8dcf:d92e]) by VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7010:5d5e:8dcf:d92e%17]) with mapi id 15.20.0776.010; Thu, 17 May 2018 11:44:52 +0000 From: Marvin H?user To: "edk2-devel@lists.01.org" CC: "Zeng, Star" , "michael.d.kinney@intel.com" , "liming.gao@intel.com" , "jiewen.yao@intel.com" Thread-Topic: [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition. Thread-Index: AQHT7IPC73BiwYJ5j0qlJch2fSujo6QzIOmQgACuhlA= Date: Thu, 17 May 2018 11:44:52 +0000 Message-ID: References: <0C09AFA07DD0434D9E2A0C6AEB0483103BAECDF5@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BAECDF5@shsmsx102.ccr.corp.intel.com> Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:A85DA9D4DDE422619C6820F0000B1032289B2BB4D40BF61A69FFEB20845E8D2F; UpperCasedChecksum:79484F6682401F4AC28DAAD44F7ECEEC31D4E8E4A5AC3C0E227E7B9DE7FD108A; SizeAsReceived:7369; Count:46 x-tmn: [Zwj3Md6p5FLSHWWK1xycOjMh84Q7f9u5] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5EUR01HT136; 7:FrRNmMvJM6MM7kcbxbVNfODUZEWHDT/hgRojiB29Ur5WHWKEw+Kt41RThrdvjBs+PlxY+CXKIKH9nOQMpCek1V6mw/v98ph4ixvWec5KceTwzxugsaageNjeUwdop9aA81RHbwpqVYxxW4EJlaQ3rzvmaZCpK4EpobMgkt4aCl1qgRLZJTmWP1FL51yOhwcApOcVTUjwCGmiH0TWLFCBJUqxASSteQ3F23r2oWJvv9r4II2o1KTz3ZBTZPTxlYIi x-incomingheadercount: 46 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1601125466)(1603101448)(1701031045); SRVR:DB5EUR01HT136; x-ms-traffictypediagnostic: DB5EUR01HT136: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:DB5EUR01HT136; BCL:0; PCL:0; RULEID:; SRVR:DB5EUR01HT136; x-forefront-prvs: 067553F396 x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(199004)(13464003)(189003)(5660300001)(7696005)(4326008)(966005)(2501003)(104016004)(3660700001)(81156014)(86362001)(15974865002)(25786009)(2900100001)(6306002)(55016002)(3280700002)(59450400001)(6916009)(54906003)(45080400002)(11346002)(76176011)(305945005)(74316002)(476003)(486006)(446003)(97736004)(5640700003)(6346003)(102836004)(6436002)(33656002)(426003)(106356001)(229853002)(87572001)(26005)(99286004)(82202002)(53546011)(68736007)(72206003)(105586002)(8936002)(14454004)(5250100002)(20460500001)(2351001)(8676002)(6246003); DIR:OUT; SFP:1901; SCL:1; SRVR:DB5EUR01HT136; H:VI1PR0801MB1790.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:; received-spf: None (protection.outlook.com: outlook.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Marvin.Haeuser@outlook.com; x-microsoft-antispam-message-info: cfDClCehX5R+KPCE8slddj6VrQZLs9kyzdly5cFOlOHgrJT9DdTsONnAu9QQDTrLPlQ9eXztRw9LNtM6/Yca2kp0R76RXYSMDUf3pFH+C3tcguWLEd71BTuvdBswexputhRql8+xTdz7xmXifewO33+caFTIVIjb6FBByxRn1u7lXn2TZkuDou9N9SwoNUSN MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: f43fbba9-f8d8-448c-33a5-08d5bbeb9aa0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-Network-Message-Id: f43fbba9-f8d8-448c-33a5-08d5bbeb9aa0 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2018 11:44:52.8379 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR01HT136 Subject: Re: [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 11:44:57 -0000 Content-Language: de-DE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hey Star, Actually the definition added is part of the definition of the ACPI Table h= eader. I think there might be confusion because the first 32 bits match the first = 32 bits of the Capabilities register. However, they are defined separately and the ACPI field lacks the upper 32 = bits. Thanks, Marvin. > -----Original Message----- > From: Zeng, Star > Sent: Thursday, May 17, 2018 3:31 AM > To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > ; Yao, Jiewen ; Zeng, Star > > Subject: RE: [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition. >=20 > Was HighPrecisionEventTimerTable.h just created for ACPI related, but not > for HPET register related? >=20 > We also see AlertStandardFormatTable.h, DmaRemappingReportingTable.h, > etc. They are all ACPI related. > What is the criteria about including ACPI related, and including > register/command/message related? > Should they be included in same header file, or separated header files? >=20 > We also see HEPT register related defined in > PcAtChipsetPkg\Include\Register\Hpet.h. >=20 >=20 > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Marvin H?user > Sent: Wednesday, May 16, 2018 3:35 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [edk2] [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition. >=20 > This patch adds the HPET Event Timer Block ID definition that can be foun= d in > the IA-PC HPET Specification, section 3.2.4. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marvin Haeuser > --- > MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h | 18 > +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) >=20 > diff --git > a/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h > b/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h > index 0d83cd5335de..926445233944 100644 > --- a/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h > +++ b/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h > @@ -2,7 +2,7 @@ > ACPI high precision event timer table definition, at www.intel.com > Specification name is IA-PC HPET (High Precision Event Timers) > Specification. >=20 > - Copyright (c) 2007 - 2008, Intel Corporation. All rights reserved.
> + Copyright (c) 2007 - 2018, Intel Corporation. All rights > + reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be > found at > @@ -22,6 +22,22 @@ > // > #pragma pack(1) >=20 > +/// > +/// HPET Event Timer Block ID described in IA-PC HPET Specification, 3.2= .4. > +/// > +typedef union { > + struct { > + UINT32 Revision : 8; > + UINT32 NumberOfTimers : 5; > + UINT32 CounterSize : 1; > + UINT32 Reserved : 1; > + UINT32 LegacyRoute : 1; > + UINT32 VendorId : 16; > + } Bits; > + UINT32 Uint32; > +} EFI_ACPI_HIGH_PRECISION_EVENT_TIMER_BLOCK_ID; > + > + > /// > /// High Precision Event Timer Table header definition. > /// > -- > 2.17.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel