From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.92.65.89; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=marvin.haeuser@outlook.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-oln040092065089.outbound.protection.outlook.com [40.92.65.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C96A621B02845 for ; Fri, 20 Jul 2018 11:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkUa5PnVL70OhzG0pNeLJ2gAd4F5PMGVgBgFEgQMhxg=; b=gzTXtMcsUGDlFTofiavRquEC+n5aFlbpF+BtQxr2zZApN662deORQRiDXvta3iddUgbUNfOnLRu31hI4DkasDOWXA2+RZhXjjV48KwjWlExTzVqt3Q1MwrtXoHAnimzcrxaWhpdA7F+Xk7QyJS/rQgplTNfxdnw4trfeBIkSwgAUdf3iTbdiNOcGvK4+ipFYncMnCQjbpAYnoBiJzt6g6GGLDt39gQsrWT6EDSzpP3Bn7jLdHsxpIeK3ntfgsb4JZg1jfmI9m19L7lJbeGaF+UjDqPGGF7B1hm2VjpKMtLbBTk3I1KLeeHWj7X4fXwsZnyUIic0qm09jMgABTQZnYA== Received: from VE1EUR01FT048.eop-EUR01.prod.protection.outlook.com (10.152.2.60) by VE1EUR01HT233.eop-EUR01.prod.protection.outlook.com (10.152.3.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.952.17; Fri, 20 Jul 2018 18:57:38 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com (10.152.2.60) by VE1EUR01FT048.mail.protection.outlook.com (10.152.3.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.952.17 via Frontend Transport; Fri, 20 Jul 2018 18:57:38 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7532:4dc6:e9f7:4765]) by VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7532:4dc6:e9f7:4765%2]) with mapi id 15.20.0973.018; Fri, 20 Jul 2018 18:57:38 +0000 From: Marvin H?user To: "edk2-devel@lists.01.org" , "achin.gupta@arm.com" , "jiewen.yao@intel.com" , "supreeth.venkatesh@arm.com" Thread-Topic: StandaloneMmPkg comments Thread-Index: AdQgW3J0dw59JLcqShKnH2cq9fMwZQ== Date: Fri, 20 Jul 2018 18:57:38 +0000 Message-ID: Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:B6E4DC2D9A2F49333B4F60C6D92D0B4A344F45531F39CDB1E37ACF61086D68CC; UpperCasedChecksum:E5E8B5E7A85DE88E2347FFEAB737E6C90AF8E6FC5B67A84FEA1F55C684274A1A; SizeAsReceived:7016; Count:43 x-tmn: [qxefWvgkqBKHCkp3f42GaQ5yv14Ws6w5] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VE1EUR01HT233; 7:CRTnbv/GNg5QUCF1SjnVZ/GPUO+FXbx7NNuckxucwW7ZhVqWMn7IBG8WdZ1bVF/E21qF7wZIoD33ugAdkX1IzKQ25sde8jbHWwXZINxXRyLN/XlrKQSc7RhGhBXbPpWc20/zHnJuz/EGvbnM7vr1nKjinNqiD7q87y7AEa5LXksuZq6dqWzq6pDwC383wrgdyFfVYJuf+u4mLLPnKfwqkV1X5MOcYH6fwHXxiA1i90yDGq97+6RatRJstQleTAMA x-incomingheadercount: 43 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125500)(1701031045); SRVR:VE1EUR01HT233; x-ms-traffictypediagnostic: VE1EUR01HT233: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(82015058); SRVR:VE1EUR01HT233; BCL:0; PCL:0; RULEID:; SRVR:VE1EUR01HT233; x-forefront-prvs: 073966E86B x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(6029001)(189003)(199004)(86362001)(8936002)(8676002)(104016004)(99286004)(221733001)(2900100001)(5250100002)(81156014)(110136005)(25786009)(74316002)(87572001)(19627235002)(7696005)(26005)(2201001)(56003)(33656002)(102836004)(790700001)(476003)(2501003)(3480700004)(6436002)(54896002)(6306002)(6346003)(55016002)(256004)(14454004)(14444005)(82202002)(68736007)(105586002)(5660300001)(20460500001)(7116003)(106356001)(486006)(72206003)(426003)(97736004); DIR:OUT; SFP:1901; SCL:1; SRVR:VE1EUR01HT233; H:VI1PR0801MB1790.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:; received-spf: None (protection.outlook.com: outlook.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Marvin.Haeuser@outlook.com; x-microsoft-antispam-message-info: bUCJbbzDwVwOZrGs6xruzV32OhzmKCtwJKI2ZrImIlsDhCLjOTz/1GNeQWLAGi/Lljza9oElnRlEVi+SCb+nPW8ZaXQI/Gilw1QhlkI1lHIhp94gNcNb3HBCSezywv300HVCscGzFM5lH0SUtkLQ3MBqvShd7vGXFffN4m5D8tPINiuw+WqGPI/Zc7i+7lQ7sxuJppR6tlvMIZuZ3pA7bX7OoQT9aAE6lfmDx1MTkCM= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-Network-Message-Id: 439203ed-c710-4ce6-c695-08d5ee72a9f4 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2018 18:57:38.6976 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR01HT233 X-Content-Filtered-By: Mailman/MimeDel 2.1.27 Subject: StandaloneMmPkg comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jul 2018 18:57:42 -0000 Content-Language: de-DE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Good day, I have been reading through the recently imported StandaloneMmPkg and found= three odd things. 1. GUID prefixes: GUIDs defined in StandaloneMmPkg.dec either have no co= mmon prefix at all ("gMmFv") or use the "gEfi" prefix. Maybe the MdeModuleP= kg-style "gEdkii" prefix could be used for a uniform style? 2. The "gEfiMmConfigurationProtocolGuid" name is common between Standalo= ne (StandaloneMmPkg.dec) and Traditional (MdePkg.dec) MM context despite ha= ving a different value of course. Shouldn't the naming reflect which is tra= ditional and which is Standalone? I haven't checked in depth, but which is = chosen when a module consumes both MdePkg and StandaloneMmPkg? 3. While .dec already uses the "Mmram" naming scheme, its header declare= s the MemoryReserve GUID as "gEfiMmPeiS(!)mramMemoryReserveGuid". Furthermo= re, the header references the SMM CIS (which has been replaced with "MM CIS= " as part of the renaming), while the GUID has changed and the structure do= es not match the deprecated specification anyway. May I suggest to turn thi= s GUID into a "gEdkii"-style GUID and remove all references to the SMM CIS?= Maybe use the "EDKII_" prefix for "EFI_MMRAM_HOB_DESCRIPTOR_BLOCK" too? I = wanted to prepare a patch, but I cannot compile the package at the moment a= nd don't want to risk submitting anything broken. Thanks for your time! Regards, Marvin.