* [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib. [not found] <82083b2c0427eb12806fb9e1ba5e806ea21e5b50.1529165460.git.Marvin.Haeuser@outlook.com> @ 2018-06-16 16:15 ` Marvin Häuser 2018-06-18 14:57 ` Gao, Liming 0 siblings, 1 reply; 3+ messages in thread From: Marvin Häuser @ 2018-06-16 16:15 UTC (permalink / raw) To: edk2-devel@lists.01.org; +Cc: michael.d.kinney@intel.com, liming.gao@intel.com UefiDebugLibConOut does currently not consume UefiLib, from which it uses the Print() function. This commit adds an explicit dependency. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com> --- MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf | 1 + 1 file changed, 1 insertion(+) diff --git a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf index 583872f54e81..64651c4169a8 100644 --- a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf +++ b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf @@ -46,6 +46,7 @@ [LibraryClasses] PrintLib UefiBootServicesTableLib DebugPrintErrorLevelLib + UefiLib [Pcd] gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue ## SOMETIMES_CONSUMES -- 2.17.1.windows.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib. 2018-06-16 16:15 ` [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib Marvin Häuser @ 2018-06-18 14:57 ` Gao, Liming 2018-06-18 15:49 ` Marvin Häuser 0 siblings, 1 reply; 3+ messages in thread From: Gao, Liming @ 2018-06-18 14:57 UTC (permalink / raw) To: Marvin.Haeuser@outlook.com, edk2-devel@lists.01.org; +Cc: Kinney, Michael D UefiDebugLibConOut depends on PrintLib. It doesn't call any API in UefiLib. > -----Original Message----- > From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com] > Sent: Sunday, June 17, 2018 12:15 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com> > Subject: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib. > > UefiDebugLibConOut does currently not consume UefiLib, from which it > uses the Print() function. This commit adds an explicit dependency. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com> > --- > MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > index 583872f54e81..64651c4169a8 100644 > --- a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > +++ b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > @@ -46,6 +46,7 @@ [LibraryClasses] > PrintLib > UefiBootServicesTableLib > DebugPrintErrorLevelLib > + UefiLib > > [Pcd] > gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue ## SOMETIMES_CONSUMES > -- > 2.17.1.windows.2 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib. 2018-06-18 14:57 ` Gao, Liming @ 2018-06-18 15:49 ` Marvin Häuser 0 siblings, 0 replies; 3+ messages in thread From: Marvin Häuser @ 2018-06-18 15:49 UTC (permalink / raw) To: edk2-devel@lists.01.org; +Cc: Gao, Liming Sorry, you are right. The linker somehow blamed UefiDebugLibConOut for a module not declaring that dependency. Regards, Marvin. > -----Original Message----- > From: Gao, Liming <liming.gao@intel.com> > Sent: Monday, June 18, 2018 4:57 PM > To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kinney@intel.com> > Subject: RE: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume > UefiLib. > > UefiDebugLibConOut depends on PrintLib. It doesn't call any API in UefiLib. > > > -----Original Message----- > > From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com] > > Sent: Sunday, June 17, 2018 12:15 AM > > To: edk2-devel@lists.01.org > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming > > <liming.gao@intel.com> > > Subject: [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume > UefiLib. > > > > UefiDebugLibConOut does currently not consume UefiLib, from which it > > uses the Print() function. This commit adds an explicit dependency. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com> > > --- > > MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > > b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > > index 583872f54e81..64651c4169a8 100644 > > --- a/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > > +++ b/MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > > @@ -46,6 +46,7 @@ [LibraryClasses] > > PrintLib > > UefiBootServicesTableLib > > DebugPrintErrorLevelLib > > + UefiLib > > > > [Pcd] > > gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue ## > SOMETIMES_CONSUMES > > -- > > 2.17.1.windows.2 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-18 15:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <82083b2c0427eb12806fb9e1ba5e806ea21e5b50.1529165460.git.Marvin.Haeuser@outlook.com>
2018-06-16 16:15 ` [PATCH] MdePkg/UefiDebugLibConOut: Explicitely consume UefiLib Marvin Häuser
2018-06-18 14:57 ` Gao, Liming
2018-06-18 15:49 ` Marvin Häuser
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox